harleyttd (Harley Trung)

Name
Harley Trung
Email
Website/Blog
http://socialsci.com
Company
SocialSci
Location
New Have, CT
Member Since
Jan 03, 2009 (11 months)

Following 5 githubbers and watching 71 repositories view all →

Public Repositories (7)

  • InstrVisualizr

    A widget developed for Euterpea (http://code.haskell.org/Euterpea/)

    legend

    Last updated Mon Dec 14 04:46:18 -0800 2009

  • qtwitter

    A Qt-based microblogging client

    legend

    Forked from ayoy/qtwitter Sat Dec 05 12:37:23 -0800 2009

    Last updated Mon Dec 07 19:30:54 -0800 2009

  • keyboard-fretboard

    Virtual keyboard and fretboard widgets, written in Haskell using Euterpea framework

    legend

    Last updated Sun Nov 29 14:37:28 -0800 2009

  • acts-as-taggable-on

    A tagging plugin for Rails applications that allows for custom tagging along dynamic contexts.

    legend

    Forked from mbleigh/acts-as-taggable-on Wed Nov 25 04:46:03 -0800 2009

    Last updated Wed Nov 25 21:46:18 -0800 2009

  • newstc

    A rewrite of user admin and loc group access control logic. Work in progress

    legend

    Last updated Wed Jun 03 08:30:38 -0700 2009

  • stc-training

    Stuff I used in training sessions held for Ruby on Rails newbies

    legend

    Last updated Mon May 18 10:22:47 -0700 2009

  • github-unfuddle

    A web hook that takes GitHub commits and turns them into Unfuddle changesets posting using the Un...

    legend

    Forked from mbleigh/github-unfuddle Wed Nov 25 02:04:06 -0800 2009

    Last updated Wed Mar 26 14:31:10 -0700 2008

Public Activity feed

harley pushed to master at harleyttd/InstrVisualizr Mon Dec 14 04:46:19 -0800 2009
HEAD is 5f9625d25255c53b69ff1ef331e37ae48d350372

2 commits »

harleyttd started watching willdonnelly/dyre Thu Dec 10 21:10:02 -0800 2009
dyre's description:
A Dynamic Reconfiguration Library for Haskell Programs
harleyttd created branch master at harleyttd/InstrVisualizr Wed Dec 09 03:33:54 -0800 2009
harleyttd created repository InstrVisualizr Wed Dec 09 03:32:13 -0800 2009
New repository is at harleyttd/InstrVisualizr
harley pushed to master at harleyttd/qtwitter Mon Dec 07 19:30:55 -0800 2009
HEAD is 2614e95ceee82be455a42bfe15f8360b303449c3
  • harley committed 2614e95c:
    fix obvious bugs in the original qtwitter, between pointer and references; using &pm vs pm
harleyttd forked ayoy/qtwitter Sat Dec 05 12:37:24 -0800 2009
Forked repository is at harleyttd/qtwitter
harleyttd created branch gh-pages at harleyttd/harleyttd.github.com Fri Dec 04 17:02:21 -0800 2009
harleyttd created repository harleyttd.github.com Fri Dec 04 16:52:03 -0800 2009
New repository is at harleyttd/harleyttd.github.com
harleyttd started watching ayoy/qoauth Sun Nov 29 19:31:05 -0800 2009
qoauth's description:
A Qt-based C++ library for OAuth authorization scheme
harley pushed to master at harleyttd/keyboard-fretboard Sun Nov 29 14:37:28 -0800 2009
HEAD is 9c77d5c6b12135c2d8edf0ca4d7fc0b427d348f7
  • harley committed 9c77d5c6:
    upading README file. still not complete but better than before
harley pushed to master at harleyttd/acts-as-taggable-on Wed Nov 25 21:50:05 -0800 2009
HEAD is a2a560191792aa0b028f751dc55ddef0da30c696
  • harley committed a2a56019:
    Fixed SQL syntax to make it work for PostgreSQL (e.g. on Heroku). In fact this is more proper SQL syntax. Also added "count" column to "tags" table
harleyttd forked mbleigh/acts-as-taggable-on Wed Nov 25 04:46:04 -0800 2009
Forked repository is at harleyttd/acts-as-taggable-on
harleyttd forked mbleigh/github-unfuddle Wed Nov 25 02:04:07 -0800 2009
Forked repository is at harleyttd/github-unfuddle
harleyttd created branch master at harleyttd/keyboard-fretboard Tue Nov 24 14:47:23 -0800 2009
harleyttd created repository keyboard-fretboard Tue Nov 24 14:46:45 -0800 2009
New repository is at harleyttd/keyboard-fretboard
harleyttd commented on YaleSTC/shifts Sat Nov 14 21:41:21 -0800 2009
Comment on app/controllers/payform_item_sets_controller.rb L47 in 6fd5520:

If we get here, it's probably because @payform_item_set.save fails right? (again im not sure if << ever fails), so why don't you dump @payform_item_set.errors.full_messages out to flash[:error], because only admin can see this it maybe easier to see why it fails.

Also, does "<<" save anything? I thought not but this usage hints so. Shouldn't it be:
@payform_item_set.payform_items << @payform_items first, and then
@payform_item_set.save after that?

Hope you don't mind explain if some of the questions are stupid=)

harleyttd commented on YaleSTC/shifts Sat Nov 14 21:36:26 -0800 2009
Comment on app/controllers/payform_item_sets_controller.rb L37 in 6fd5520:

You can just use:
users = User.find params[:user_ids]
and then go through each user instead of each user_id

This will throw an exception if any of the id is invalid -- a desired behavior because your code is doing the same. However it's more efficient because you don't have to go create payforms for some users half way and roll back later if you see one invalid user.

harleyttd commented on YaleSTC/shifts Sat Nov 14 21:21:47 -0800 2009
Comment on app/models/report_item.rb L16 in 55d7015:

Good idea moving it to before_save.
Do you need a newline at the end of [IP Address changed ...] ? Just wondering
Also .last could be more readable than [-1] =)

harleyttd commented on YaleSTC/shifts Sat Nov 14 21:16:46 -0800 2009
Comment in 5b3c0e3:

In _user_options.html.erb: The "Return to your current shift report" link should only be shown when there exists such a report. In fact, "user_has_active_shift?" returns true, so shouldn't current_user.current_shift.report always NOT nil? Thus I don't think the check for that is needed. The link code should be simply:

<%=link_to "Return to your current shift report", current_user.current_shift.report %>

====== In shifts_controller.rb: Does "<<" operator ever fail? Even so, in this case we don't really handle the fail case anyway, consider moving the long 2nd part of if condition in to the if block itself =)

harleyttd started watching pauldix/feedzirra Sat Nov 14 05:03:12 -0800 2009
feedzirra's description:
A feed fetching and parsing library that treats the internet like Godzilla treats Japan: it dominates and eats all.
harleyttd started watching tenderlove/mechanize Sat Nov 14 04:13:38 -0800 2009
mechanize's description:
Mechanize is a ruby library that makes automated web interaction easy.
harleyttd commented on YaleSTC/shifts Sat Nov 07 12:32:47 -0800 2009
Comment in be491e3:

"break" in a while or for loop is OK if it's used properly: to short-circuit a loop and it looks clear what it does. alternatively, you can use a flag and check that flag in the while/for loop condition, which i thought not more attractive. yet we don't want to run the whole loop if we can end it early.

and oops it's not "people_count < 0", but rather "people_count < prioritized_location.min_staff"

changes look good

harleyttd commented on YaleSTC/shifts Sat Nov 07 12:28:31 -0800 2009

The comment has since been removed.