Skip to content

Commit

Permalink
Avoid unintended cursor motion caused by `url-retrieve'.
Browse files Browse the repository at this point in the history
* twittering-mode.el: Use a dummy buffer to prevent the cursor
from moving without intention after invoking `url-retrieve'.
(twittering-url-request-dummy-buffer-name): new constant for dummy
buffer.
(twittering-resolve-url-request): switch to the dummy buffer just
after killing the content buffer generated by `url-retrieve'. This
prevents multiple threads from having different cursor points for
the same buffer.
  • Loading branch information
cvmat committed May 5, 2010
1 parent 9939816 commit 337dcee
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
11 changes: 11 additions & 0 deletions ChangeLog
@@ -1,3 +1,14 @@
2010-05-05 Tadashi MATSUO <tad@mymail.twin.jp>

* twittering-mode.el: Use a dummy buffer to prevent the cursor
from moving without intention after invoking `url-retrieve'.
(twittering-url-request-dummy-buffer-name): new constant for dummy
buffer.
(twittering-resolve-url-request): switch to the dummy buffer just
after killing the content buffer generated by `url-retrieve'. This
prevents multiple threads from having different cursor points for
the same buffer.

2010-05-05 Takashi Masuda <masutaka@nifty.com>

* twittering-mode.el: twittering-jojo-mode の判定ミスを修正。
Expand Down
7 changes: 6 additions & 1 deletion twittering-mode.el
Expand Up @@ -2368,6 +2368,8 @@ been initialized yet."
(defvar twittering-internal-url-queue nil)
(defvar twittering-url-request-resolving-p nil)
(defvar twittering-url-request-retry-limit 3)
(defconst twittering-url-request-dummy-buffer-name
" *twittering-dummy-for-url-retrieve-async*")

(defun twittering-remove-redundant-queries (queue)
(remove nil
Expand Down Expand Up @@ -2429,7 +2431,10 @@ been initialized yet."
(puthash url (1+ current) twittering-url-data-hash))
(t
nil))))
(kill-buffer (current-buffer))
(let ((current (current-buffer)))
(set-buffer (get-buffer-create
twittering-url-request-dummy-buffer-name))
(kill-buffer current))
(setq twittering-url-request-resolving-p nil)
(twittering-resolve-url-request)))
`(,url))))))
Expand Down

0 comments on commit 337dcee

Please sign in to comment.