Issues - hayesdavis/grackle

hayesdavis / grackle

120

Description:

Lightweight Ruby library for the Twitter API that supports both Basic and OAuth authentication.

Sort by: Priority | Votes | Last Updated

Loading…

1.

1 vote

enhancement
x

Permit Sending a Query String on GETs
0 comments Created 7 months ago by hayesdavis

Title

Body
Both GET (?) and POST (!) method chains only support specifying URL parameters via a hash. This is normally the most useful way to do it but there are certain GET requests where a pre-built string of URL params would be helpful. This is specifically useful when using the "next_page" attribute available in the response to ".search?". There's no way to simply pass that string into the next request to ".search?" I think the best solution would be to check for a string argument instead of a hash on GET method chain terminators and pass that string to the transport for direct inclusion as URL parameters on the request. I don't see any reason this should work on POSTs.
or cancel

Both GET (?) and POST (!) method chains only support specifying URL parameters via a hash. This is normally the most useful way to do it but there are certain GET requests where a pre-built string of URL params would be helpful. This is specifically useful when using the "next_page" attribute available in the response to ".search?". There's no way to simply pass that string into the next request to ".search?"

I think the best solution would be to check for a string argument instead of a hash on GET method chain terminators and pass that string to the transport for direct inclusion as URL parameters on the request. I don't see any reason this should work on POSTs.

Comments

Parsed with GitHub Flavored Markdown
2.

0 votes

enhancement
x

Use Faster HTTP Library
0 comments Created 7 months ago by hayesdavis

Title

Body
It's been suggested that the Transport layer use a faster HTTP library like curb or httparty. Right now it uses Net::HTTP.
or cancel

It's been suggested that the Transport layer use a faster HTTP library like curb or httparty. Right now it uses Net::HTTP.

Comments

Parsed with GitHub Flavored Markdown
3.

0 votes

enhancement
x

Provide Better to_s on TwitterStruct That Includes id
0 comments Created 7 months ago by hayesdavis

Title

Body
Several people have noted that the id method that is often placed on TwitterStructs which represent Tweets, Users, etc is not printed in irb sessions. This has caused some confusion and made people think you can't access the id. It's not printed in irb because id is normally a method on Object and so OpenStruct (which TwitterStruct extends) doesn't include it in its to_s. Provide a custom to_s method on TwitterStruct that includes the id.
or cancel

Several people have noted that the id method that is often placed on TwitterStructs which represent Tweets, Users, etc is not printed in irb sessions. This has caused some confusion and made people think you can't access the id.

It's not printed in irb because id is normally a method on Object and so OpenStruct (which TwitterStruct extends) doesn't include it in its to_s.

Provide a custom to_s method on TwitterStruct that includes the id.

Comments

Parsed with GitHub Flavored Markdown
4.

0 votes

enhancement
x

Provide Hash Style Access To Attributes
0 comments Created 7 months ago by hayesdavis

Title

Body
TwitterStructs returned by requests have methods for each attribute returned. It would also be nice to be able to reference these attributes using strings in a hash-style syntax like res = client.users.show? :screen_name=>'hayesdavis' res['screen_name'] #returns hayesdavis This would be especially useful for the trend methods from the Search API since they include attributes names that are actually timestamps. The only way to get to those now is to use send to do a method invocation.
or cancel
TwitterStructs returned by requests have methods for each attribute returned. It would also be nice to be able to reference these attributes using strings in a hash-style syntax like
```
res = client.users.show? :screen_name=>'hayesdavis'
res['screen_name'] #returns hayesdavis
```
This would be especially useful for the trend methods from the Search API since they include attributes names that are actually timestamps. The only way to get to those now is to use send to do a method invocation.
Comments

Parsed with GitHub Flavored Markdown
5.

0 votes

enhancement
x

Provide Access to An Enumerable of Attributes
0 comments Created 7 months ago by hayesdavis

Title

Body
There's no way to iterate over all attributes in a TwitterStruct returned by a request. Provide a method like __attributes__ which returns an array of only those attributes defined by the parsed response.
or cancel

There's no way to iterate over all attributes in a TwitterStruct returned by a request. Provide a method like attributes which returns an array of only those attributes defined by the parsed response.

Comments

Parsed with GitHub Flavored Markdown
6.

-1 votes

enhancement
x

Add Streaming API Support
0 comments Created 7 months ago by hayesdavis

Title

Body
Include grackle-style support for the streaming api.
or cancel

Include grackle-style support for the streaming api.

Comments

Parsed with GitHub Flavored Markdown
7.

1 vote

Handle use of convenience methods for dates
0 comments Created 6 months ago by fblee

Title

Body
When I'm calling the search API with grackle (eg. from a rails app), I should be able to do this: results = client.search?(:from => 'Ben_Hall', :since => 1.day.ago, :rpp => 20) At the moment I am forced to do this: results = client.search?(:from => 'Ben_Hall', :since => 1.day.ago.to_s(:sane), :rpp => 20) having already added a "sane" date format to rails that uses "%Y-%m-%d" Lee.
or cancel
When I'm calling the search API with grackle (eg. from a rails app), I should be able to do this:
```
results = client.search?(:from => 'Ben_Hall', :since => 1.day.ago, :rpp => 20)
```
At the moment I am forced to do this:
```
results = client.search?(:from => 'Ben_Hall', :since => 1.day.ago.to_s(:sane), :rpp => 20)
```
having already added a "sane" date format to rails that uses "%Y-%m-%d"

Lee.
Comments

Parsed with GitHub Flavored Markdown
8.

0 votes

Small misprint
0 comments Created 6 months ago by cypok

Title

Body
client.users.show.xml :screen_name=>'some_user' #http://twitter.com/users/show.xml?scre(!!!)E(!!!)n_name=some_user
or cancel

client.users.show.xml :screen_name=>'some_user' #http://twitter.com/users/show.xml?scre(!!!)E(!!!)n_name=some_user

Comments

Parsed with GitHub Flavored Markdown
9.

1 vote

extra /users gets added if call attempt is made, but fails because variable wasn't set prior
2 comments Created 3 months ago by damon

Title

Body
pretty odd. >> u = client.users.show? :user_id => x NameError: undefined local variable or method `x' for #<Object:0x389a0 @controller=#<ApplicationController:0x2313e20>> from (irb):8 >> x = 12 => 12 >> u = client.users.show? :user_id => x Grackle::TwitterError: get http://twitter.com/users/users/show.json?user_id=12 => 404: {"request":"\/users\/users\/show.json?user_id=12","error":"Not found"} from /Users/damon/rails/tf/vendor/gems/hayesdavis-grackle-0.1.4/lib/grackle/client.rb:240:in `handle_error_response' from /Users/damon/rails/tf/vendor/gems/hayesdavis-grackle-0.1.4/lib/grackle/client.rb:218:in `process_response' from /Users/damon/rails/tf/vendor/gems/hayesdavis-grackle-0.1.4/lib/grackle/client.rb:198:in `call_with_format' from /Users/damon/rails/tf/vendor/gems/hayesdavis-grackle-0.1.4/lib/grackle/client.rb:142:in `method_missing' from (irb):10 >> u = client.users.show? :user_id => x => #<Grackle::TwitterStruct.... It seems that because x wasn't set the first time through, the /users part of the path gets added twice.
or cancel
pretty odd.
u = client.users.show? :user_id => x NameError: undefined local variable or method `x' for #<Object:0x389a0 @controller=#<ApplicationController:0x2313e20>>

from (irb):8

x = 12 => 12

u = client.users.show? :user_id => x Grackle::TwitterError: get http://twitter.com/users/users/show.json?user_id=12 => 404: {"request":"\/users\/users\/show.json?user_id=12","error":"Not found"}

from /Users/damon/rails/tf/vendor/gems/hayesdavis-grackle-0.1.4/lib/grackle/client.rb:240:in `handle_error_response' from /Users/damon/rails/tf/vendor/gems/hayesdavis-grackle-0.1.4/lib/grackle/client.rb:218:in `process_response' from /Users/damon/rails/tf/vendor/gems/hayesdavis-grackle-0.1.4/lib/grackle/client.rb:198:in `call_with_format' from /Users/damon/rails/tf/vendor/gems/hayesdavis-grackle-0.1.4/lib/grackle/client.rb:142:in `method_missing' from (irb):10

u = client.users.show? :user_id => x => #<Grackle::TwitterStruct....
It seems that because x wasn't set the first time through, the /users part of the path gets added twice.
Comments

hayesdavis Mon Aug 31 07:30:17 -0700 2009 | link

The reason this happens is that users gets called on client and added to the request path. The 2nd method, show?, is not actually called because the undefined variable error happens prior to sending show? to the Client. This leave the internal state of the request path as "/users".

You can fix this type of issue by calling client.clear which will clear the request path.

This is interesting though and makes me think that instead of using a single request path as an instance variable of the client and returning the client from the path component methods, I could create a proxy object that's returned by the path component methods that holds request state. That would prevent this confusing behavior from happening.

Comment
The reason this happens is that users gets called on client and added to the request path. The 2nd method, show?, is not actually called because the undefined variable error happens prior to sending show? to the Client. This leave the internal state of the request path as "/users". You can fix this type of issue by calling client.clear which will clear the request path. This is interesting though and makes me think that instead of using a single request path as an instance variable of the client and returning the client from the path component methods, I could create a proxy object that's returned by the path component methods that holds request state. That would prevent this confusing behavior from happening.
or cancel

damon Mon Aug 31 08:41:42 -0700 2009 | link

sounds like a good change because /users by itself in this context is useless. they only make sense taken together, I think.

at least it's understood! :)

Comment
sounds like a good change because /users by itself in this context is useless. they only make sense taken together, I think. at least it's understood! :)
or cancel

Parsed with GitHub Flavored Markdown
10.

0 votes

Grackle::TwitterError: Unable to decode response: 618: unexpected token at 'false'
0 comments Created 3 months ago by bitzesty

Title

Body
Sometimes the twitter api simply returns true/fase /opt/ruby-enterprise-1.8.6-20090520/lib/ruby/gems/1.8/gems/hayesdavis-grackle-0.1.2/lib/grackle/client.rb:224:in `process_response' /opt/ruby-enterprise-1.8.6-20090520/lib/ruby/gems/1.8/gems/hayesdavis-grackle-0.1.2/lib/grackle/client.rb:197:in `call_with_format' /opt/ruby-enterprise-1.8.6-20090520/lib/ruby/gems/1.8/gems/hayesdavis-grackle-0.1.2/lib/grackle/client.rb:130:in `method_missing'
or cancel

Sometimes the twitter api simply returns true/fase

/opt/ruby-enterprise-1.8.6-20090520/lib/ruby/gems/1.8/gems/hayesdavis-grackle-0.1.2/lib/grackle/client.rb:224:in `process_response'

/opt/ruby-enterprise-1.8.6-20090520/lib/ruby/gems/1.8/gems/hayesdavis-grackle-0.1.2/lib/grackle/client.rb:197:in `call_with_format'

/opt/ruby-enterprise-1.8.6-20090520/lib/ruby/gems/1.8/gems/hayesdavis-grackle-0.1.2/lib/grackle/client.rb:130:in `method_missing'

Comments

Parsed with GitHub Flavored Markdown
11.

0 votes

Lists named after a valid format can not be retrieved
0 comments Created about 1 month ago by dacort

Title

Body
A user that has named a list one of the valid formats (json, xml, atom, rss) improperly calls format_invocation. For example, @misstillytilly has an "rss" list. client.misstillytilly.rss.members? returns: Grackle::TwitterError: get http://twitter.com/misstillytilly.rss => 404: As Twitter now supports list_id as a parameter, valid workaround is just using _(list_id) instead of the list slug.
or cancel

A user that has named a list one of the valid formats (json, xml, atom, rss) improperly calls format_invocation.

For example, @misstillytilly has an "rss" list.
client.misstillytilly.rss.members? returns:
Grackle::TwitterError: get http://twitter.com/misstillytilly.rss => 404:

As Twitter now supports list_id as a parameter, valid workaround is just using _(list_id) instead of the list slug.

Comments

Parsed with GitHub Flavored Markdown
12.

0 votes

Incompatibility between yajl-ruby and grackle
0 comments Created 1 day ago by hayesdavis

Title

Body
See this issue for background: http://github.com/brianmario/yajl-ruby/issues/closed/#issue/13
or cancel

See this issue for background: http://github.com/brianmario/yajl-ruby/issues/closed/#issue/13

Comments

Parsed with GitHub Flavored Markdown