Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single job to ping all devices in the Broadlink integration #51466

Merged
merged 2 commits into from Jun 4, 2021

Conversation

felipediel
Copy link
Contributor

Proposed change

Use a single job to ping all devices to avoid bombing the executor with too many jobs.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@bdraco
Copy link
Member

bdraco commented Jun 4, 2021

Looks good. Will test later today

@bdraco
Copy link
Member

bdraco commented Jun 4, 2021

Do we need to catch socket errors in case one of the devices is offline to ensure that the rest of them get the ping?

Nevermind you already did that. Sorry I missed it (looking on my phone)

@bdraco bdraco added this to the 2021.6.3 milestone Jun 4, 2021
@bdraco
Copy link
Member

bdraco commented Jun 4, 2021

2021-06-04 20:59:51 DEBUG (MainThread) [homeassistant.util.executor] Calling executor with function: <function BroadlinkHeartbeat.heartbeat at 0x7f2affe13dc0>, args: ({'192.168.107.64', '192.168.107.49', '192.168.107.26', '192.168.107.110', '192.168.107.29', '192.168.107.55', '192.168.107.74', '192.168.107.63', '192.168.107.21', '192.168.107.27', '192.168.107.25', '192.168.107.22', '192.168.107.24', '192.168.107.52', '192.168.107.23', '192.168.107.28', '192.168.107.39', ....................

Looks good 馃憤

@bdraco bdraco merged commit 89d90bf into home-assistant:dev Jun 4, 2021
Dev automation moved this from Needs review to Done Jun 4, 2021
@felipediel
Copy link
Contributor Author

Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Broadlink monopolizes the executor with many devices during ping
5 participants