Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce ovo_energy polling rate to be less aggressive #51613

Merged
merged 2 commits into from Jun 8, 2021

Conversation

blastoise186
Copy link
Contributor

The current polling rate is too aggressive for the purpose, this commit reduces it to 12 hours to play nice with OVO.

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

The current polling rate is too aggressive for the purpose, this commit reduces it to 12 hours to play nice with OVO.
@homeassistant
Copy link
Contributor

Hi @blastoise186,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@project-bot project-bot bot added this to Needs review in Dev Jun 8, 2021
@blastoise186
Copy link
Contributor Author

It might be useful for someone in the future to see if a smarter schedule could be added and I might look into that at some point, but I'd definitely feel better if even reducing the polling to hourly rather than 12 hourly takes the pressure off. I'm not skilled enough to do smarter schedules, but hopefully this PR is good enough in the meantime.

Thanks for the feedback so far!

@frenck frenck added this to the 2021.6.4 milestone Jun 8, 2021
Dev automation moved this from Needs review to Reviewer approved Jun 8, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @blastoise186 馃憤

@frenck frenck merged commit fa42c67 into home-assistant:dev Jun 8, 2021
Dev automation moved this from Reviewer approved to Done Jun 8, 2021
@blastoise186
Copy link
Contributor Author

Yay! No worries. :)

I'd have been pretty shocked if any of those checks had gone red to be honest! XD

I've heard that OVO might bring out a Public API in the future, but hopefully in the meantime this should help to make life easier for everyone.

@blastoise186 blastoise186 deleted the ovopollfix branch June 8, 2021 12:21
@blastoise186 blastoise186 restored the ovopollfix branch June 8, 2021 12:39
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

OVO Energy polling is excessively aggressive
4 participants