Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyialarm to 1.9.0 #51804

Merged
merged 1 commit into from Jun 14, 2021
Merged

Conversation

RyuzakiKK
Copy link
Contributor

Breaking change

Proposed change

Bump the pyialarm dependency to the version 1.9.0.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

This change improves the connection reliability to the alarm system.

Changes in the library RyuzakiKK/pyialarm@v1.8.1...v1.9.0

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@RyuzakiKK
Copy link
Contributor Author

It would be great if this could be included in the 2021.6.5 milestone because there are a few users that experience connection errors in the current version and so far all of them have confirmed that the version 1.9.0 fixed them.

@thecode thecode added this to the 2021.6.5 milestone Jun 13, 2021
Dev automation moved this from Needs review to Reviewer approved Jun 13, 2021
Copy link
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@cgarwood cgarwood merged commit c260fca into home-assistant:dev Jun 14, 2021
Dev automation moved this from Reviewer approved to Done Jun 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

iAlarm connection error
5 participants