diff --git a/jonah/lib/Driver/Sql.php b/jonah/lib/Driver/Sql.php index 70b0ffe0e92..0d4f4fd8034 100644 --- a/jonah/lib/Driver/Sql.php +++ b/jonah/lib/Driver/Sql.php @@ -64,6 +64,19 @@ public function __construct($params = array()) */ public function saveChannel(&$info) { + $values = array( + Horde_String::convertCharset($info['channel_slug'], 'UTF-8', $this->_params['charset']), + Horde_String::convertCharset($info['channel_name'], 'UTF-8', $this->_params['charset']), + (int)$info['channel_type'], + isset($info['channel_desc']) ? $info['channel_desc'] : null, + isset($info['channel_interval']) ? (int)$info['channel_interval'] : null, + isset($info['channel_url']) ? $info['channel_url'] : null, + isset($info['channel_link']) ? $info['channel_link'] : null, + isset($info['channel_page_link']) ? $info['channel_page_link'] : null, + isset($info['channel_story_url']) ? $info['channel_story_url'] : null, + isset($info['channel_img']) ? $info['channel_img'] : null + ); + if (empty($info['channel_id'])) { $sql = 'INSERT INTO jonah_channels' . ' (channel_slug, channel_name, channel_type,' @@ -71,7 +84,6 @@ public function saveChannel(&$info) . ' channel_link, channel_page_link, channel_story_url,' . ' channel_img)' . ' VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)'; - $values = array(); } else { $sql = 'UPDATE jonah_channels ' . 'SET channel_slug = ?, channel_name = ?, channel_type = ?,' @@ -79,21 +91,8 @@ public function saveChannel(&$info) . 'channel_link = ?, channel_page_link = ?,' . 'channel_story_url = ?, channel_img = ? ' . 'WHERE channel_id = ?'; - $values = array((int)$info['channel_id']); + $values[] = (int)$info['channel_id']; } - array_unshift($values, - Horde_String::convertCharset($info['channel_slug'], 'UTF-8', $this->_params['charset']), - Horde_String::convertCharset($info['channel_name'], 'UTF-8', $this->_params['charset']), - (int)$info['channel_type'], - isset($info['channel_desc']) ? $info['channel_desc'] : null, - isset($info['channel_interval']) ? (int)$info['channel_interval'] : null, - isset($info['channel_url']) ? $info['channel_url'] : null, - isset($info['channel_link']) ? $info['channel_link'] : null, - isset($info['channel_page_link']) ? $info['channel_page_link'] : null, - isset($info['channel_story_url']) ? $info['channel_story_url'] : null, - isset($info['channel_img']) ? $info['channel_img'] : null - ); - Horde::log('SQL Query by Jonah_Driver_sql::saveChannel(): ' . $sql, 'DEBUG'); if (empty($info['channel_id'])) { try {