[mms] Fix performing more than one filter drag/drop action on a singl…

…e page (Bug #13434).
horde · Aug 15, 2014 · 48ab543 · 48ab543
1 parent 5f5f46e
commit 48ab543
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/ingo/docs/CHANGES b/ingo/docs/CHANGES
@@ -2,6 +2,8 @@
 v3.2.1-git
 ----------
 
+[mms] Fix performing more than one filter drag/drop action on a single page
+      (Bug #13434).
 [mms] Add support for a negative regex test to the Maildrop driver.
 [mms] Add support for a negative regex test to the Sieve driver (Request
       #12671; Pete Beardmore <pete.beardmore@msn.com>).

diff --git a/ingo/js/filters.js b/ingo/js/filters.js
@@ -26,7 +26,21 @@ var IngoFilters = {
                 onUpdate: function() {
                     HordeCore.doAction(
                         'reSortFilters',
-                        { sort: Object.toJSON(Sortable.sequence('filterslist')) }
+                        {
+                            sort: Object.toJSON(Sortable.sequence('filterslist'))
+                        },
+                        {
+                            callback: function() {
+                                /* Need to re-label the IDs to reflect new
+                                 * sort order. */
+                                var i = 0,
+                                    rows = $('filterslist').select('DIV.filtersRow');
+                                rows.invoke('writeAttribute', 'id', null);
+                                rows.each(function(r) {
+                                    r.writeAttribute('id', 'filtersrow_' + (i++));
+                                });
+                            }
+                        }
                     );
                 },
                 tag: 'div'

diff --git a/ingo/package.xml b/ingo/package.xml
@@ -33,6 +33,7 @@
  </stability>
  <license uri="http://www.horde.org/licenses/apache">ASL</license>
  <notes>
+* [mms] Fix performing more than one filter drag/drop action on a single page (Bug #13434).
 * [mms] Add support for a negative regex test to the Maildrop driver.
 * [mms] Add support for a negative regex test to the Sieve driver (Request #12671; Pete Beardmore &lt;pete.beardmore@msn.com&gt;).
 * [mms] Fix vacation in the maildrop driver (Bug #13415; balestrieri@mag-data.com).
@@ -1492,6 +1493,7 @@
    <date>2014-07-08</date>
    <license uri="http://www.horde.org/licenses/apache">ASL</license>
    <notes>
+* [mms] Fix performing more than one filter drag/drop action on a single page (Bug #13434).
 * [mms] Add support for a negative regex test to the Maildrop driver.
 * [mms] Add support for a negative regex test to the Sieve driver (Request #12671; Pete Beardmore &lt;pete.beardmore@msn.com&gt;).
 * [mms] Fix vacation in the maildrop driver (Bug #13415; balestrieri@mag-data.com).