New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NullPointerException on File indexing (IgnoreFilesIndex), infinite loop of failing re-indexes. #527
Comments
We had to disable .ignore plugin versions 2.4.0 and 2.5.0 in 2018.1.1 released due to the issue since it causes serious problems for many customers: https://youtrack.jetbrains.com/v2/issue/IDEA-189189 |
Btw, |
Affects PyCharm 2018.1 |
@hsz Previous IDE versions have the same NPE, number 1 in my previous post #491 (comment) |
@hsz Please take a look. |
@nicity Thanks for this summary. I've made a few changes - available in separated branch: 24d0b06 I'd also appreciate if someone would install following package and verify if issues are resolved. |
@hsz I installed the attached plugin in PhpStorm 2018.1.1. The exceptions no longer show up but every time I run some commands that update ignored files, e.g.
Is it related to this issue? Edit: nvm, I manually added it excluded directories and it's fine now. I don't think I've ever touched this setting before tho... |
@hsz Please release 2.6.0 once this issue is fixed, current 2.6.0 RC doesn't address serious problem discovered and the plugin will continue producing NPEs => will be disabled again |
IgnoreEntryOccurrence is now immutable:
Regarding NPE - I've removed |
@hsz Changes for Try / catch / IOException aren't enough for the originally reported problem: 'value' can be null inside indices. I commented on code because it masks other problems: e.g. readUTF throws exception for large strings. Mutable IgnoreEntryOccurrence (as it breaks index contract) leads to NPE problem because Value are keys inside Map and mutability breaks key's hashcode. Added several comments for your changes in 24d0b06 |
…equired regex into Patterns in runtime + caching
All right - everything is resolved, refactored and tesed. v2.6.0 is built and released. |
Prerequisites
mobi.hsz.idea.gitignore
package nameDescription
Infinite loops of index runs (every ~10 sec), each accompanied with the following log entries:
Steps to Reproduce
Expected behavior: Index runs once, then finishes, as nothing changed
Actual behavior: Infinite index reruns (every ~10 sec)
Reproduces how often: 100%
Versions
Plugin: 2.5
IDE: PHPStorm 2018.1 / 2017.3.6
OS: macOS 10.13.3 / 10.13.4
Additional Information
Removing .ignore Plugin and manual reinstall of version 2.4
fixed the index problem.does not fix the problem completely, but the NullPointerException with subsequent index rebuild occurs only occasionally.idea.log
The text was updated successfully, but these errors were encountered: