Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Midi input and cymbal choke #171

Merged
merged 16 commits into from Aug 4, 2014
Merged

Midi input and cymbal choke #171

merged 16 commits into from Aug 4, 2014

Conversation

blablack
Copy link
Contributor

This patch provides compatibility with edrums cymbal choke through midi aftertouch

  • makes alsa driver compatible with aftertouch
  • makes jack driver compatible with aftertouch
  • handles aftertouch message in midi input and send a note off when necessary
  • note off method can overwrite "ignoring note off" setting when note off sent from aftertouch

@blablack blablack mentioned this pull request Apr 30, 2014
Closed
mauser added a commit that referenced this pull request Aug 4, 2014
@mauser
Merge pull request #171 from blablack/cymbal_choke
15b5808 
Midi input and cymbal choke
@mauser mauser merged commit 15b5808 into hydrogen-music:master Aug 4, 2014
@mauser
Copy link
Member

mauser commented Aug 4, 2014

Hi!
Thanks again for the patch! I couldn't test the hihat settings yet, but i think i will ask especially for testing with the first alpha/beta release of 0.9.7.

@blablack blablack deleted the cymbal_choke branch September 13, 2015 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blablack @mauser