Issues - ianwhite/nested_has_many_through

ianwhite / nested_has_many_through

122

Description:

rails plugin that allows has_many :through to go through other has_many :throughs

Sort by: Priority | Votes | Last Updated

Loading…

1.

1 vote

breaks has_one :through
3 comments Created 3 months ago by mangoswiss

Title

Body
This is my first time posting an issue on any open source project so apologies if it's not done in the usual format. I have a model like this: class GradeGrade < ActiveRecord::Base belongs_to :grade_item, :foreign_key => :itemid has_one :moodle_course, :through => :grade_item ### This is broken by nested has many end In the console I could do the following: g = GradeGrade.find(26) g.moodle_course It works fine without this plugin installed and shows this: Mysql::Error: Unknown column 'mdl_course.grade_grade_id' in 'where clause': SELECT `mdl_course`.* FROM `mdl_course` WHERE (mdl_course.grade_grade_id = 26 ) when I install nested_has_many_through plugin. Would love to help fix this but dont feel I have the expertise. Hope one of you bright chaps can help sort it out. Regards, Kevin.
or cancel

This is my first time posting an issue on any open source project so apologies if it's not done in the usual format.

I have a model like this:

class GradeGrade < ActiveRecord::Base
belongs_to :grade_item, :foreign_key => :itemid has_one :moodle_course, :through => :grade_item ### This is broken by nested has many end

In the console I could do the following:
g = GradeGrade.find(26)
g.moodle_course

It works fine without this plugin installed and shows this:
Mysql::Error: Unknown column 'mdl_course.grade_grade_id' in 'where clause': SELECT mdl_course.* FROM mdl_course WHERE (mdl_course.grade_grade_id = 26 )
when I install nested_has_many_through plugin.

Would love to help fix this but dont feel I have the expertise. Hope one of you bright chaps can help sort it out.

Regards,

Kevin.

Comments

gordonbisnor Tue Sep 22 18:35:12 -0700 2009 | link

Broke my has one too....

class Artist < User
has_many :agents_artists, :dependent => :destroy has_many :agents, :through => :agents_artists has_one :primary_agent, :through => :agents_artists, :conditions => ["agents_artists.primary_agent = ?",true] , :source => :agent

Comment
Broke my has one too.... class Artist < User has_many :agents_artists, :dependent => :destroy has_many :agents, :through => :agents_artists has_one :primary_agent, :through => :agents_artists, :conditions => ["agents_artists.primary_agent = ?",true] , :source => :agent
or cancel

mangoswiss Wed Sep 23 02:28:23 -0700 2009 | link

I got it working by using one of the other forks. I think it may have been JackDanger or logophobia. I can't remember which one now. There's a reference to it in one of the commit messages.

Comment
I got it working by using one of the other forks. I think it may have been JackDanger or logophobia. I can't remember which one now. There's a reference to it in one of the commit messages.
or cancel

gordonbisnor Wed Sep 23 07:26:40 -0700 2009 | link

Thanks, yes, I checked out the lighthouse site for this plugin and someone mentioned that there was a fork that worked and it did.

Comment
Thanks, yes, I checked out the lighthouse site for this plugin and someone mentioned that there was a fork that worked and it did.
or cancel

Parsed with GitHub Flavored Markdown
2.

0 votes

Seems totally broken on Rails 2.3.2
0 comments Created 2 months ago by brookr

Title

Body
First off, THANK YOU for the time you have put into this plugin. This is functionality badly needed in core. I'm having trouble getting it to work. Not sure if what i'm seeing is version specific, but it is ugly. Installing the plugin breaks existing has_many :through and has_one :through associations. The SQL generated for has_many :through is using the wrong value for the join ID (appears to be using the local id, rather than the id of the intermediary model?). I monkey-patched this by changing line 20 lib/nested_has_many_through.rb to: "#{@nested_join_attributes[:remote_key]} = #{@owner.send(@nested_join_attributes[:local_key])} #{@nested_join_attributes[:conditions]}" However, this "fix" breaks has_one :through associations, trying to put the wrong id (the :remote_key, it seems?) on @owner model. As noted in Issue #1, has_one :through has it's own problems anyway. I forked, I combed through the code, I did some debug outs, traced what was happening, but could not identify the cause of these issues. Perhaps it is something with the way it is interacting with Rails? Especially Rails 2.3? There are no references to "has_one" in the plugin, so maybe that just isn't handled at all? Any insights you have would be appreciated. Again, thank you for taking on the burden of maintaining this essential tool.
or cancel
First off, THANK YOU for the time you have put into this plugin. This is functionality badly needed in core.

I'm having trouble getting it to work. Not sure if what i'm seeing is version specific, but it is ugly.

Installing the plugin breaks existing has_many :through and has_one :through associations.

The SQL generated for has_many :through is using the wrong value for the join ID (appears to be using the local id, rather than the id of the intermediary model?). I monkey-patched this by changing line 20 lib/nested_has_many_through.rb to:
```
      "#{@nested_join_attributes[:remote_key]} = #{@owner.send(@nested_join_attributes[:local_key])} #{@nested_join_attributes[:conditions]}"
```
However, this "fix" breaks has_one :through associations, trying to put the wrong id (the :remote_key, it seems?) on @owner model.

As noted in Issue #1, has_one :through has it's own problems anyway.

I forked, I combed through the code, I did some debug outs, traced what was happening, but could not identify the cause of these issues. Perhaps it is something with the way it is interacting with Rails? Especially Rails 2.3?

There are no references to "has_one" in the plugin, so maybe that just isn't handled at all? Any insights you have would be appreciated.

Again, thank you for taking on the burden of maintaining this essential tool.
Comments

Parsed with GitHub Flavored Markdown

Labels

breaks has_one :through

Comments

Seems totally broken on Rails 2.3.2

Comments