Skip to content

Commit

Permalink
Use string concat for performance (according to intellij)
Browse files Browse the repository at this point in the history
  • Loading branch information
@benfortuna
benfortuna committed Jun 30, 2016
1 parent 773a263 commit 0c96c69
Show file tree
Hide file tree
Showing 8 changed files with 80 additions and 88 deletions.
25 changes: 12 additions & 13 deletions src/main/java/net/fortuna/ical4j/model/Calendar.java
View file
Expand Up @@ -178,19 +178,18 @@ public Calendar(Calendar c) throws ParseException, IOException,
* {@inheritDoc}
*/
public final String toString() {
final StringBuilder buffer = new StringBuilder();
buffer.append(BEGIN);
buffer.append(':');
buffer.append(VCALENDAR);
buffer.append(Strings.LINE_SEPARATOR);
buffer.append(getProperties());
buffer.append(getComponents());
buffer.append(END);
buffer.append(':');
buffer.append(VCALENDAR);
buffer.append(Strings.LINE_SEPARATOR);

return buffer.toString();
String buffer = BEGIN +
':' +
VCALENDAR +
Strings.LINE_SEPARATOR +
getProperties() +
getComponents() +
END +
':' +
VCALENDAR +
Strings.LINE_SEPARATOR;

return buffer;
}

/**
Expand Down
23 changes: 11 additions & 12 deletions src/main/java/net/fortuna/ical4j/model/Component.java
View file
Expand Up @@ -143,18 +143,17 @@ protected Component(final String s, final PropertyList p) {
* {@inheritDoc}
*/
public String toString() {
final StringBuilder buffer = new StringBuilder();
buffer.append(BEGIN);
buffer.append(':');
buffer.append(getName());
buffer.append(Strings.LINE_SEPARATOR);
buffer.append(getProperties());
buffer.append(END);
buffer.append(':');
buffer.append(getName());
buffer.append(Strings.LINE_SEPARATOR);

return buffer.toString();
String buffer = BEGIN +
':' +
getName() +
Strings.LINE_SEPARATOR +
getProperties() +
END +
':' +
getName() +
Strings.LINE_SEPARATOR;

return buffer;
}

/**
Expand Down
7 changes: 3 additions & 4 deletions src/main/java/net/fortuna/ical4j/model/DateTime.java
View file
Expand Up @@ -494,10 +494,9 @@ public final TimeZone getTimeZone() {
* {@inheritDoc}
*/
public final String toString() {
final StringBuilder b = new StringBuilder(super.toString());
b.append('T');
b.append(time.toString());
return b.toString();
String b = super.toString() + 'T' +
time.toString();
return b;
}

/**
Expand Down
23 changes: 11 additions & 12 deletions src/main/java/net/fortuna/ical4j/model/component/VAvailability.java
View file
Expand Up @@ -143,18 +143,17 @@ public final ComponentList<Available> getAvailable() {
* {@inheritDoc}
*/
public final String toString() {
final StringBuilder b = new StringBuilder();
b.append(BEGIN);
b.append(':');
b.append(getName());
b.append(Strings.LINE_SEPARATOR);
b.append(getProperties());
b.append(getAvailable());
b.append(END);
b.append(':');
b.append(getName());
b.append(Strings.LINE_SEPARATOR);
return b.toString();
String b = BEGIN +
':' +
getName() +
Strings.LINE_SEPARATOR +
getProperties() +
getAvailable() +
END +
':' +
getName() +
Strings.LINE_SEPARATOR;
return b;
}

/**
Expand Down
23 changes: 11 additions & 12 deletions src/main/java/net/fortuna/ical4j/model/component/VEvent.java
View file
Expand Up @@ -285,18 +285,17 @@ public final ComponentList<VAlarm> getAlarms() {
* {@inheritDoc}
*/
public final String toString() {
final StringBuilder b = new StringBuilder();
b.append(BEGIN);
b.append(':');
b.append(getName());
b.append(Strings.LINE_SEPARATOR);
b.append(getProperties());
b.append(getAlarms());
b.append(END);
b.append(':');
b.append(getName());
b.append(Strings.LINE_SEPARATOR);
return b.toString();
String b = BEGIN +
':' +
getName() +
Strings.LINE_SEPARATOR +
getProperties() +
getAlarms() +
END +
':' +
getName() +
Strings.LINE_SEPARATOR;
return b;
}

/**
Expand Down
23 changes: 11 additions & 12 deletions src/main/java/net/fortuna/ical4j/model/component/VTimeZone.java
View file
Expand Up @@ -167,18 +167,17 @@ public VTimeZone(final PropertyList properties,
* {@inheritDoc}
*/
public final String toString() {
final StringBuilder b = new StringBuilder();
b.append(BEGIN);
b.append(':');
b.append(getName());
b.append(Strings.LINE_SEPARATOR);
b.append(getProperties());
b.append(observances);
b.append(END);
b.append(':');
b.append(getName());
b.append(Strings.LINE_SEPARATOR);
return b.toString();
String b = BEGIN +
':' +
getName() +
Strings.LINE_SEPARATOR +
getProperties() +
observances +
END +
':' +
getName() +
Strings.LINE_SEPARATOR;
return b;
}

/**
Expand Down
23 changes: 11 additions & 12 deletions src/main/java/net/fortuna/ical4j/model/component/VToDo.java
View file
Expand Up @@ -203,18 +203,17 @@ public final ComponentList<VAlarm> getAlarms() {
* {@inheritDoc}
*/
public final String toString() {
final StringBuilder buffer = new StringBuilder();
buffer.append(BEGIN);
buffer.append(':');
buffer.append(getName());
buffer.append(Strings.LINE_SEPARATOR);
buffer.append(getProperties());
buffer.append(getAlarms());
buffer.append(END);
buffer.append(':');
buffer.append(getName());
buffer.append(Strings.LINE_SEPARATOR);
return buffer.toString();
String buffer = BEGIN +
':' +
getName() +
Strings.LINE_SEPARATOR +
getProperties() +
getAlarms() +
END +
':' +
getName() +
Strings.LINE_SEPARATOR;
return buffer;
}

/**
Expand Down
21 changes: 10 additions & 11 deletions src/main/java/net/fortuna/ical4j/model/component/VVenue.java
View file
Expand Up @@ -109,17 +109,16 @@ public VVenue(final PropertyList properties) {
* {@inheritDoc}
*/
public final String toString() {
final StringBuilder b = new StringBuilder();
b.append(BEGIN);
b.append(':');
b.append(getName());
b.append(Strings.LINE_SEPARATOR);
b.append(getProperties());
b.append(END);
b.append(':');
b.append(getName());
b.append(Strings.LINE_SEPARATOR);
return b.toString();
String b = BEGIN +
':' +
getName() +
Strings.LINE_SEPARATOR +
getProperties() +
END +
':' +
getName() +
Strings.LINE_SEPARATOR;
return b;
}

/**
Expand Down

0 comments on commit 0c96c69

Please sign in to comment.