From 0c96c693009f14e4da29d736777515a20d7f0518 Mon Sep 17 00:00:00 2001 From: Ben Fortuna Date: Thu, 30 Jun 2016 11:17:36 +1000 Subject: [PATCH] Use string concat for performance (according to intellij) --- .../net/fortuna/ical4j/model/Calendar.java | 25 +++++++++---------- .../net/fortuna/ical4j/model/Component.java | 23 ++++++++--------- .../net/fortuna/ical4j/model/DateTime.java | 7 +++--- .../ical4j/model/component/VAvailability.java | 23 ++++++++--------- .../ical4j/model/component/VEvent.java | 23 ++++++++--------- .../ical4j/model/component/VTimeZone.java | 23 ++++++++--------- .../fortuna/ical4j/model/component/VToDo.java | 23 ++++++++--------- .../ical4j/model/component/VVenue.java | 21 ++++++++-------- 8 files changed, 80 insertions(+), 88 deletions(-) diff --git a/src/main/java/net/fortuna/ical4j/model/Calendar.java b/src/main/java/net/fortuna/ical4j/model/Calendar.java index af2bba6f4..556679611 100644 --- a/src/main/java/net/fortuna/ical4j/model/Calendar.java +++ b/src/main/java/net/fortuna/ical4j/model/Calendar.java @@ -178,19 +178,18 @@ public Calendar(Calendar c) throws ParseException, IOException, * {@inheritDoc} */ public final String toString() { - final StringBuilder buffer = new StringBuilder(); - buffer.append(BEGIN); - buffer.append(':'); - buffer.append(VCALENDAR); - buffer.append(Strings.LINE_SEPARATOR); - buffer.append(getProperties()); - buffer.append(getComponents()); - buffer.append(END); - buffer.append(':'); - buffer.append(VCALENDAR); - buffer.append(Strings.LINE_SEPARATOR); - - return buffer.toString(); + String buffer = BEGIN + + ':' + + VCALENDAR + + Strings.LINE_SEPARATOR + + getProperties() + + getComponents() + + END + + ':' + + VCALENDAR + + Strings.LINE_SEPARATOR; + + return buffer; } /** diff --git a/src/main/java/net/fortuna/ical4j/model/Component.java b/src/main/java/net/fortuna/ical4j/model/Component.java index b698420c0..dc1351cf5 100644 --- a/src/main/java/net/fortuna/ical4j/model/Component.java +++ b/src/main/java/net/fortuna/ical4j/model/Component.java @@ -143,18 +143,17 @@ protected Component(final String s, final PropertyList p) { * {@inheritDoc} */ public String toString() { - final StringBuilder buffer = new StringBuilder(); - buffer.append(BEGIN); - buffer.append(':'); - buffer.append(getName()); - buffer.append(Strings.LINE_SEPARATOR); - buffer.append(getProperties()); - buffer.append(END); - buffer.append(':'); - buffer.append(getName()); - buffer.append(Strings.LINE_SEPARATOR); - - return buffer.toString(); + String buffer = BEGIN + + ':' + + getName() + + Strings.LINE_SEPARATOR + + getProperties() + + END + + ':' + + getName() + + Strings.LINE_SEPARATOR; + + return buffer; } /** diff --git a/src/main/java/net/fortuna/ical4j/model/DateTime.java b/src/main/java/net/fortuna/ical4j/model/DateTime.java index e1410bdf1..15d8c591b 100644 --- a/src/main/java/net/fortuna/ical4j/model/DateTime.java +++ b/src/main/java/net/fortuna/ical4j/model/DateTime.java @@ -494,10 +494,9 @@ public final TimeZone getTimeZone() { * {@inheritDoc} */ public final String toString() { - final StringBuilder b = new StringBuilder(super.toString()); - b.append('T'); - b.append(time.toString()); - return b.toString(); + String b = super.toString() + 'T' + + time.toString(); + return b; } /** diff --git a/src/main/java/net/fortuna/ical4j/model/component/VAvailability.java b/src/main/java/net/fortuna/ical4j/model/component/VAvailability.java index 237af0962..5d854cc7a 100644 --- a/src/main/java/net/fortuna/ical4j/model/component/VAvailability.java +++ b/src/main/java/net/fortuna/ical4j/model/component/VAvailability.java @@ -143,18 +143,17 @@ public final ComponentList getAvailable() { * {@inheritDoc} */ public final String toString() { - final StringBuilder b = new StringBuilder(); - b.append(BEGIN); - b.append(':'); - b.append(getName()); - b.append(Strings.LINE_SEPARATOR); - b.append(getProperties()); - b.append(getAvailable()); - b.append(END); - b.append(':'); - b.append(getName()); - b.append(Strings.LINE_SEPARATOR); - return b.toString(); + String b = BEGIN + + ':' + + getName() + + Strings.LINE_SEPARATOR + + getProperties() + + getAvailable() + + END + + ':' + + getName() + + Strings.LINE_SEPARATOR; + return b; } /** diff --git a/src/main/java/net/fortuna/ical4j/model/component/VEvent.java b/src/main/java/net/fortuna/ical4j/model/component/VEvent.java index 6ecfc8937..25cf7e276 100644 --- a/src/main/java/net/fortuna/ical4j/model/component/VEvent.java +++ b/src/main/java/net/fortuna/ical4j/model/component/VEvent.java @@ -285,18 +285,17 @@ public final ComponentList getAlarms() { * {@inheritDoc} */ public final String toString() { - final StringBuilder b = new StringBuilder(); - b.append(BEGIN); - b.append(':'); - b.append(getName()); - b.append(Strings.LINE_SEPARATOR); - b.append(getProperties()); - b.append(getAlarms()); - b.append(END); - b.append(':'); - b.append(getName()); - b.append(Strings.LINE_SEPARATOR); - return b.toString(); + String b = BEGIN + + ':' + + getName() + + Strings.LINE_SEPARATOR + + getProperties() + + getAlarms() + + END + + ':' + + getName() + + Strings.LINE_SEPARATOR; + return b; } /** diff --git a/src/main/java/net/fortuna/ical4j/model/component/VTimeZone.java b/src/main/java/net/fortuna/ical4j/model/component/VTimeZone.java index 32923252a..2071a9ed8 100644 --- a/src/main/java/net/fortuna/ical4j/model/component/VTimeZone.java +++ b/src/main/java/net/fortuna/ical4j/model/component/VTimeZone.java @@ -167,18 +167,17 @@ public VTimeZone(final PropertyList properties, * {@inheritDoc} */ public final String toString() { - final StringBuilder b = new StringBuilder(); - b.append(BEGIN); - b.append(':'); - b.append(getName()); - b.append(Strings.LINE_SEPARATOR); - b.append(getProperties()); - b.append(observances); - b.append(END); - b.append(':'); - b.append(getName()); - b.append(Strings.LINE_SEPARATOR); - return b.toString(); + String b = BEGIN + + ':' + + getName() + + Strings.LINE_SEPARATOR + + getProperties() + + observances + + END + + ':' + + getName() + + Strings.LINE_SEPARATOR; + return b; } /** diff --git a/src/main/java/net/fortuna/ical4j/model/component/VToDo.java b/src/main/java/net/fortuna/ical4j/model/component/VToDo.java index eec1a7e53..e7d90d8ab 100644 --- a/src/main/java/net/fortuna/ical4j/model/component/VToDo.java +++ b/src/main/java/net/fortuna/ical4j/model/component/VToDo.java @@ -203,18 +203,17 @@ public final ComponentList getAlarms() { * {@inheritDoc} */ public final String toString() { - final StringBuilder buffer = new StringBuilder(); - buffer.append(BEGIN); - buffer.append(':'); - buffer.append(getName()); - buffer.append(Strings.LINE_SEPARATOR); - buffer.append(getProperties()); - buffer.append(getAlarms()); - buffer.append(END); - buffer.append(':'); - buffer.append(getName()); - buffer.append(Strings.LINE_SEPARATOR); - return buffer.toString(); + String buffer = BEGIN + + ':' + + getName() + + Strings.LINE_SEPARATOR + + getProperties() + + getAlarms() + + END + + ':' + + getName() + + Strings.LINE_SEPARATOR; + return buffer; } /** diff --git a/src/main/java/net/fortuna/ical4j/model/component/VVenue.java b/src/main/java/net/fortuna/ical4j/model/component/VVenue.java index 68907d5f9..47be8554e 100644 --- a/src/main/java/net/fortuna/ical4j/model/component/VVenue.java +++ b/src/main/java/net/fortuna/ical4j/model/component/VVenue.java @@ -109,17 +109,16 @@ public VVenue(final PropertyList properties) { * {@inheritDoc} */ public final String toString() { - final StringBuilder b = new StringBuilder(); - b.append(BEGIN); - b.append(':'); - b.append(getName()); - b.append(Strings.LINE_SEPARATOR); - b.append(getProperties()); - b.append(END); - b.append(':'); - b.append(getName()); - b.append(Strings.LINE_SEPARATOR); - return b.toString(); + String b = BEGIN + + ':' + + getName() + + Strings.LINE_SEPARATOR + + getProperties() + + END + + ':' + + getName() + + Strings.LINE_SEPARATOR; + return b; } /**