Refactor IronPython resolver.

icsharpcode · Sep 26, 2010 · 69e65ac · 69e65ac
1 parent 1123bf8
commit 69e65ac
Show file tree

Hide file tree

Showing 15 changed files with 117 additions and 88 deletions.
diff --git a/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/IPythonResolver.cs b/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/IPythonResolver.cs
@@ -8,6 +8,6 @@ namespace ICSharpCode.PythonBinding
 {
 	public interface IPythonResolver
 	{
-		ResolveResult Resolve(PythonResolverContext resolverContext, ExpressionResult expressionResult);
+		ResolveResult Resolve(PythonResolverContext resolverContext);
 	}
 }
diff --git a/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonClassResolver.cs b/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonClassResolver.cs
@@ -10,19 +10,21 @@ public class PythonClassResolver : IPythonResolver
 	{
 		PythonResolverContext resolverContext;
 
-		public PythonClassResolver()
+		public ResolveResult Resolve(PythonResolverContext resolverContext)
 		{
-		}
-
-		public ResolveResult Resolve(PythonResolverContext resolverContext, ExpressionResult expressionResult)
-		{
-			IClass matchingClass = GetClass(resolverContext, expressionResult.Expression);
+			IClass matchingClass = GetClass(resolverContext);
 			if (matchingClass != null) {
 				return CreateTypeResolveResult(matchingClass);
 			}
 			return null;
 		}
 
+		public IClass GetClass(PythonResolverContext resolverContext)
+		{
+			string name = resolverContext.Expression;
+			return GetClass(resolverContext, name);
+		}
+
 		public IClass GetClass(PythonResolverContext resolverContext, string name)
 		{
 			this.resolverContext = resolverContext;

diff --git a/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonDotNetMethodResolver.cs b/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonDotNetMethodResolver.cs
@@ -15,9 +15,9 @@ public PythonDotNetMethodResolver(PythonClassResolver classResolver)
 			this.classResolver = classResolver;
 		}
 
-		public ResolveResult Resolve(PythonResolverContext resolverContext, ExpressionResult expressionResult)
+		public ResolveResult Resolve(PythonResolverContext resolverContext)
 		{
-			MemberName memberName = new MemberName(expressionResult.Expression);
+			MemberName memberName = resolverContext.CreateExpressionMemberName();
 			IClass matchingClass = classResolver.GetClass(resolverContext, memberName.Type);
 			if (matchingClass != null) {
 				return new PythonMethodGroupResolveResult(matchingClass, memberName.Name);

diff --git a/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonImportResolver.cs b/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonImportResolver.cs
@@ -8,15 +8,11 @@ namespace ICSharpCode.PythonBinding
 {
 	public class PythonImportResolver : IPythonResolver
 	{
-		public PythonImportResolver()
+		public ResolveResult Resolve(PythonResolverContext resolverContext)
 		{
-		}
-
-		public ResolveResult Resolve(PythonResolverContext resolverContext, ExpressionResult expressionResult)
-		{
-			if (IsNamespace(expressionResult)) {
-				PythonImportExpression importExpression = new PythonImportExpression(expressionResult.Expression);
-				PythonImportExpressionContext context = expressionResult.Context as PythonImportExpressionContext;
+			if (IsNamespace(resolverContext.ExpressionResult)) {
+				PythonImportExpression importExpression = new PythonImportExpression(resolverContext.Expression);
+				PythonImportExpressionContext context = resolverContext.ExpressionContext as PythonImportExpressionContext;
 				context.HasFromAndImport = importExpression.HasFromAndImport;
 
 				return new PythonImportModuleResolveResult(importExpression);

diff --git a/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonLocalVariableResolver.cs b/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonLocalVariableResolver.cs
@@ -123,34 +123,36 @@ public static string GetTypeName(Expression node)
 			return PythonControlFieldExpression.GetMemberName(node as MemberExpression);
 		}
 
-		public ResolveResult Resolve(PythonResolverContext resolverContext, ExpressionResult expressionResult)
+		public ResolveResult Resolve(PythonResolverContext resolverContext)
 		{
-			return GetLocalVariable(resolverContext, expressionResult);
+			return GetLocalVariable(resolverContext);
 		}
 
 		/// <summary>
 		/// Tries to find the type that matches the local variable name.
 		/// </summary>
-		LocalResolveResult GetLocalVariable(PythonResolverContext resolverContext, ExpressionResult expressionResult)
+		LocalResolveResult GetLocalVariable(PythonResolverContext resolverContext)
 		{
-			string code = GetLocalMethodCode(resolverContext.FileContent, expressionResult);
-			string typeName = Resolve(expressionResult.Expression, code);
+			string code = GetLocalMethodCode(resolverContext);
+			string typeName = Resolve(resolverContext.Expression, code);
 			if (typeName != null) {
-				return CreateLocalResolveResult(typeName, expressionResult.Expression, resolverContext);
+				return CreateLocalResolveResult(typeName, resolverContext);
 			}
 			return null;
 		}
 
-		string GetLocalMethodCode(string fullCode, ExpressionResult expressionResult)
+		string GetLocalMethodCode(PythonResolverContext resolverContext)
 		{
-			ScriptingLocalMethod localMethod = new ScriptingLocalMethod(fullCode);
-			return localMethod.GetCode(expressionResult.Region.BeginLine);
+			ScriptingLocalMethod localMethod = new ScriptingLocalMethod(resolverContext.FileContent);
+			int beginLine = resolverContext.ExpressionRegion.BeginLine;
+			return localMethod.GetCode(beginLine);
 		}
 
-		LocalResolveResult CreateLocalResolveResult(string typeName, string identifier, PythonResolverContext resolverContext)
+		LocalResolveResult CreateLocalResolveResult(string typeName, PythonResolverContext resolverContext)
 		{
 			IClass resolvedClass = classResolver.GetClass(resolverContext, typeName);
 			if (resolvedClass != null) {
+				string identifier = resolverContext.Expression;
 				return CreateLocalResolveResult(identifier, resolvedClass);
 			}
 			return null;

diff --git a/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonMemberResolver.cs b/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonMemberResolver.cs
@@ -19,15 +19,20 @@ public PythonMemberResolver(PythonClassResolver classResolver)
 			this.classResolver = classResolver;
 		}
 
-		public ResolveResult Resolve(PythonResolverContext resolverContext, ExpressionResult expressionResult)
+		public ResolveResult Resolve(PythonResolverContext resolverContext)
 		{
-			IMember member = FindMember(resolverContext, expressionResult.Expression);
+			IMember member = FindMember(resolverContext);
 			if (member != null) {
 				return CreateMemberResolveResult(member);
 			}
 			return null;
 		}
 
+		IMember FindMember(PythonResolverContext resolverContext)
+		{
+			return FindMember(resolverContext, resolverContext.Expression);
+		}
+
 		IMember FindMember(PythonResolverContext resolverContext, string expression)
 		{
 			MemberName memberName = new MemberName(expression);

diff --git a/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonMethodResolver.cs b/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonMethodResolver.cs
@@ -17,13 +17,13 @@ public PythonMethodResolver(PythonClassResolver classResolver, PythonStandardMod
 			standardModuleMethodResolver = new PythonStandardModuleMethodResolver(standardModuleResolver);
 		}
 
-		public ResolveResult Resolve(PythonResolverContext resolverContext, ExpressionResult expressionResult)
+		public ResolveResult Resolve(PythonResolverContext resolverContext)
 		{
-			ResolveResult resolveResult = dotNetMethodResolver.Resolve(resolverContext, expressionResult);
+			ResolveResult resolveResult = dotNetMethodResolver.Resolve(resolverContext);
 			if (resolveResult != null) {
 				return resolveResult;
 			}
-			return standardModuleMethodResolver.Resolve(resolverContext, expressionResult);
+			return standardModuleMethodResolver.Resolve(resolverContext);
 		}
 	}
 }
diff --git a/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonNamespaceResolver.cs b/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonNamespaceResolver.cs
@@ -11,8 +11,9 @@ public class PythonNamespaceResolver : IPythonResolver
 		PythonResolverContext resolverContext;
 		ExpressionResult expressionResult;
 
-		public PythonNamespaceResolver()
+		public ResolveResult Resolve(PythonResolverContext resolverContext)
 		{
+			return Resolve(resolverContext, resolverContext.ExpressionResult);
 		}
 
 		public ResolveResult Resolve(PythonResolverContext resolverContext, ExpressionResult expressionResult)

diff --git a/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonResolver.cs b/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonResolver.cs
@@ -46,18 +46,18 @@ public ResolveResult Resolve(ExpressionResult expressionResult, ParseInformation
 				return null;
 			}
 
-			resolverContext = new PythonResolverContext(parseInfo, fileContent);
-			if (!resolverContext.GetCallingMember(expressionResult.Region)) {
+			resolverContext = new PythonResolverContext(parseInfo, expressionResult, fileContent);
+			if (!resolverContext.HasProjectContent) {
 				return null;
 			}
 
-			return Resolve(resolverContext, expressionResult);
+			return Resolve(resolverContext);
 		}
 
-		public ResolveResult Resolve(PythonResolverContext resolverContext, ExpressionResult expressionResult)
+		public ResolveResult Resolve(PythonResolverContext resolverContext)
 		{
 			foreach (IPythonResolver resolver in resolvers) {
-				ResolveResult resolveResult = resolver.Resolve(resolverContext, expressionResult);
+				ResolveResult resolveResult = resolver.Resolve(resolverContext);
 				if (resolveResult != null) {
 					return resolveResult;
 				}

diff --git a/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonResolverContext.cs b/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonResolverContext.cs
@@ -14,17 +14,25 @@ public class PythonResolverContext
 		IProjectContent projectContent;
 		IClass callingClass;
 		string fileContent;
+		ExpressionResult expressionResult;
 
 		public PythonResolverContext(ParseInformation parseInfo)
 			: this(parseInfo, String.Empty)
 		{
 		}
 
 		public PythonResolverContext(ParseInformation parseInfo, string fileContent)
+			: this(parseInfo, new ExpressionResult(), fileContent)
+		{
+		}
+
+		public PythonResolverContext(ParseInformation parseInfo, ExpressionResult expressionResult, string fileContent)
 		{
 			this.fileContent = fileContent;
+			this.expressionResult = expressionResult;
 			GetCompilationUnit(parseInfo);
 			GetProjectContent();
+			GetCallingMember();
 		}
 
 		void GetCompilationUnit(ParseInformation parseInfo)
@@ -41,6 +49,27 @@ void GetProjectContent()
 			}
 		}
 
+		/// <summary>
+		/// Determines the class and member at the specified
+		/// line and column in the specified file.
+		/// </summary>
+		void GetCallingMember()
+		{
+			if (projectContent != null) {
+				GetCallingClass();
+			}
+		}
+
+		/// <summary>
+		/// Gets the calling class at the specified line and column.
+		/// </summary>
+		void GetCallingClass()
+		{
+			if (compilationUnit.Classes.Count > 0) {
+				callingClass = compilationUnit.Classes[0];
+			}
+		}
+
 		public string FileContent {
 			get { return fileContent; }
 		}
@@ -49,6 +78,27 @@ void GetProjectContent()
 			get { return projectContent; }
 		}
 
+		public ExpressionResult ExpressionResult {
+			get { return expressionResult; }
+		}
+
+		public MemberName CreateExpressionMemberName()
+		{
+			return new MemberName(Expression);
+		}
+
+		public string Expression {
+			get { return expressionResult.Expression; }
+		}
+
+		public ExpressionContext ExpressionContext {
+			get { return expressionResult.Context; }
+		}
+
+		public DomRegion ExpressionRegion {
+			get { return expressionResult.Region; }
+		}
+
 		public bool HasProjectContent {
 			get { return projectContent != null; }
 		}
@@ -86,34 +136,6 @@ bool PartialNamespaceExists(IProjectContent projectContent, string name)
 			return false;
 		}
 
-		/// <summary>
-		/// Determines the class and member at the specified
-		/// line and column in the specified file.
-		/// </summary>
-		public bool GetCallingMember(DomRegion region)
-		{
-			if (compilationUnit == null) {
-				return false;
-			}
-
-			if (projectContent != null) {
-				callingClass = GetCallingClass(region);
-				return true;
-			}
-			return false;
-		}
-
-		/// <summary>
-		/// Gets the calling class at the specified line and column.
-		/// </summary>
-		IClass GetCallingClass(DomRegion region)
-		{
-			if (compilationUnit.Classes.Count > 0) {
-				return compilationUnit.Classes[0];
-			}
-			return null;
-		}
-
 		public IClass GetClass(string fullyQualifiedName)
 		{
 			return projectContent.GetClass(fullyQualifiedName, 0);

diff --git a/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonSelfResolver.cs b/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonSelfResolver.cs
@@ -8,22 +8,22 @@ namespace ICSharpCode.PythonBinding
 {
 	public class PythonSelfResolver : IPythonResolver
 	{
-		public ResolveResult Resolve(PythonResolverContext resolverContext, ExpressionResult expressionResult)
+		public ResolveResult Resolve(PythonResolverContext resolverContext)
 		{
 			if (resolverContext.HasCallingClass) {
-				if (IsSelfExpression(expressionResult)) {
+				if (IsSelfExpression(resolverContext)) {
 					return CreateResolveResult(resolverContext);
-				} else if (IsSelfExpressionAtStart(expressionResult)) {
-					MemberName memberName = new MemberName(expressionResult.Expression);
+				} else if (IsSelfExpressionAtStart(resolverContext)) {
+					MemberName memberName = resolverContext.CreateExpressionMemberName();
 					return new PythonMethodGroupResolveResult(resolverContext.CallingClass, memberName.Name);
 				}
 			}
 			return null;
 		}
 
-		bool IsSelfExpression(ExpressionResult expressionResult)
+		bool IsSelfExpression(PythonResolverContext resolverContext)
 		{
-			return expressionResult.Expression == "self";
+			return resolverContext.Expression == "self";
 		}
 
 		ResolveResult CreateResolveResult(PythonResolverContext resolverContext)
@@ -33,9 +33,9 @@ ResolveResult CreateResolveResult(PythonResolverContext resolverContext)
 			return new ResolveResult(callingClass, null, returnType);
 		}
 
-		bool IsSelfExpressionAtStart(ExpressionResult expressionResult)
+		bool IsSelfExpressionAtStart(PythonResolverContext resolverContext)
 		{
-			return expressionResult.Expression.StartsWith("self.");
+			return resolverContext.Expression.StartsWith("self.");
 		}
 	}
 }
diff --git a/...ns/BackendBindings/Python/PythonBinding/Project/Src/PythonStandardModuleMethodResolver.cs b/...ns/BackendBindings/Python/PythonBinding/Project/Src/PythonStandardModuleMethodResolver.cs
@@ -15,9 +15,9 @@ public PythonStandardModuleMethodResolver(PythonStandardModuleResolver standardM
 			this.standardModuleResolver = standardModuleResolver;
 		}
 
-		public ResolveResult Resolve(PythonResolverContext resolverContext, ExpressionResult expressionResult)
+		public ResolveResult Resolve(PythonResolverContext resolverContext)
 		{
-			MemberName memberName = new MemberName(expressionResult.Expression);
+			MemberName memberName = resolverContext.CreateExpressionMemberName();
 			MethodGroupResolveResult result = ResolveMethodFromImportedNames(resolverContext, memberName);
 			if (result != null) {
 				return result;

diff --git a/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonStandardModuleResolver.cs b/src/AddIns/BackendBindings/Python/PythonBinding/Project/Src/PythonStandardModuleResolver.cs
@@ -10,19 +10,21 @@ public class PythonStandardModuleResolver : IPythonResolver
 	{
 		PythonStandardModules standardPythonModules = new PythonStandardModules();
 
-		public PythonStandardModuleResolver()
+		public ResolveResult Resolve(PythonResolverContext resolverContext)
 		{
-		}
-
-		public ResolveResult Resolve(PythonResolverContext resolverContext, ExpressionResult expressionResult)
-		{
-			PythonStandardModuleType type = GetStandardModuleTypeIfImported(resolverContext, expressionResult.Expression);
+			PythonStandardModuleType type = GetStandardModuleTypeIfImported(resolverContext);
 			if (type != null) {
 				return new PythonStandardModuleResolveResult(type);
 			}
 			return null;
 		}
 
+		PythonStandardModuleType GetStandardModuleTypeIfImported(PythonResolverContext resolverContext)
+		{
+			string moduleName = resolverContext.Expression;
+			return GetStandardModuleTypeIfImported(resolverContext, moduleName);
+		}
+
 		public PythonStandardModuleType GetStandardModuleTypeIfImported(PythonResolverContext resolverContext, string moduleName)
 		{
 			if (resolverContext.HasImport(moduleName) || PythonBuiltInModuleMemberName.IsBuiltInModule(moduleName)) {