Support 'clear_cache' #5266
Support 'clear_cache' #5266
Conversation
|
Deploy preview for chef-inspec canceled. Built with commit cbe105b https://app.netlify.com/sites/chef-inspec/deploys/60510a14fb9d070008f0cbd3 |
|
Checking CI builds here. Still need to implement tests for cache buster and ensuring our case is covered with the caching. |
|
Big 👍 from me on making this change; but I think we should run it past @kekaichinose - some existing customers who are currently happy to run with a cached profile every time might perceive this change as a reduction in performance and increase in traffic. We'd just need to be ready to explain the improvement here. |
Schwad
force-pushed
the
ns/cust_issue
branch
2 times, most recently
from
7fc5caa
to
ce41fe2
Compare
|
This is currently blocked from the product side due to changing the caching experience for current users whilst solving the problem. I am currently looking into alternative ways to implement the fix without changing the experience. If I fail, then we'll have to simply ship the |
Schwad
force-pushed
the
ns/cust_issue
branch
from
1dafa1a
to
6157dd6
Compare
|
Updated the description to match commit description. It appears there's not a quick and easy way to back door the caching, and the first solution has not been accepted. Therefore I have let those that raised the issue know about the situation and have updated this PR just to implement |
Schwad
force-pushed
the
ns/cust_issue
branch
from
6157dd6
to
8b911cc
Compare
Schwad
changed the title
| parallelize_me! | ||
|
|
||
| describe "inspec clear_cache" do | ||
| it "clears any existing cache" do | ||
| dirname = File.expand_path("~/.inspec/cache") |
There was a problem hiding this comment.
Parallelizing and using a global filesystem location during testing seems like asking for trouble. Any other test that caches may be writing to the cache at the same time, and may have it cleared during its testing.
Since the implementation supports using a --vendor-cache option for a custom cache location, it might be safer to use a temporary directory in a block and pass that as the cache location.
There was a problem hiding this comment.
Sorry I only just responded here - thanks for this point and I've updated the PR to hopefully catch this via the vendor-cache path. :)
|
Ahoy! 👋 just dropping in to say I've had a look at this and it seems it's red because of two failures in the tests (likely something syntax-y). I'm hopeful I'll get a change to pull this up on my machine and get things green on this PR! 👍 I can't see artifact and hab-build (rightfully so as they're blacklisted from community viewing) but I'm assuming those reds might be something a bit flaky or unrelated to the PR. 🤔 |
Helps with Customer Bug 236 (see there for repro) Currently, when we run `inspec compliance upload my_profile` it is cached locally in inspec when run. If we update the version in the core code and run another upload, `inspec compliance upload my_profile` again it will run the old cached version instead of running a new copy from automate. The current workaround is to specify the desired version with `inspec exec compliance://my_profile/admin#0.1.1`. The caching happens before we have forward sight into the profile's contents and only the target name. So the text used to generate the cache would be `compliance://my_profile/admin` which does not change version to version. A fix here could simply identify when we are doing a local `inspec exec compliance://` (hitting local profiles does not generate a cache) and skips the cache if there's no version specified. That would eliminate the unexpected behavior. However, it is a breaking change for customers as some current caching taking place would no longer take place. Instead, we have included a `clear_cache` cli method for InSpec, which should assist the core team and other developers in the future when debugging edge case issues in InSpec. Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
clintoncwolfe
force-pushed
the
ns/cust_issue
branch
from
874d9d2
to
cbe105b
Compare
clintoncwolfe
added
Expeditor: Bump Minor Version
Type: New Feature
Helps with Customer Bug 236 (see there for repro)
Currently, when we run
inspec compliance upload my_profileit iscached locally in inspec when run. If we update the version in the core
code and run another upload,
inspec compliance upload my_profileagainit will run the old cached version instead of running a new copy
from automate.
The current workaround is to specify the desired version with
inspec exec compliance://my_profile/admin#0.1.1.The caching happens before we have forward sight into the profile's
contents and only the target name. So the text used to generate the
cache would be
compliance://my_profile/adminwhich does not changeversion to version.
A fix here could simply identify when we are doing a local
inspec exec compliance://(hitting local profiles does not generate a cache) andskips the cache if there's no version specified. That would eliminate
the unexpected behavior. However, it is a breaking change for customers
as some current caching taking place would no longer take place.
Instead, we have included a
clear_cachecli method for InSpec,which should assist the core team and other developers in the future
when debugging edge case issues in InSpec.
Signed-off-by: Nick Schwaderer nschwaderer@chef.io
< edited 2020-11-24 >