refactor(searchbar): set inputmode default to undefined (#20080)

fixes #20074 BREAKING CHANGE: The `inputmode` property for `ion-searchbar` now defaults to `undefined`. To get the old behavior, set the `inputmode` property to `"search"`.
ionic-team · Dec 16, 2019 · 6612604 · 6612604
1 parent 1cabb53
commit 6612604
Show file tree

Hide file tree

Showing 8 changed files with 35 additions and 26 deletions.
diff --git a/core/api.txt b/core/api.txt
@@ -955,7 +955,7 @@ ion-searchbar,prop,clearIcon,string | undefined,undefined,false,false
 ion-searchbar,prop,color,string | undefined,undefined,false,false
 ion-searchbar,prop,debounce,number,250,false,false
 ion-searchbar,prop,disabled,boolean,false,false,false
-ion-searchbar,prop,inputmode,"decimal" | "email" | "none" | "numeric" | "search" | "tel" | "text" | "url",'search',false,false
+ion-searchbar,prop,inputmode,"decimal" | "email" | "none" | "numeric" | "search" | "tel" | "text" | "url" | undefined,undefined,false,false
 ion-searchbar,prop,mode,"ios" | "md",undefined,false,false
 ion-searchbar,prop,placeholder,string,'Search',false,false
 ion-searchbar,prop,searchIcon,string | undefined,undefined,false,false

diff --git a/core/src/components.d.ts b/core/src/components.d.ts
@@ -2179,7 +2179,7 @@ export namespace Components {
     /**
     * A hint to the browser for which keyboard to display. Possible values: `"none"`, `"text"`, `"tel"`, `"url"`, `"email"`, `"numeric"`, `"decimal"`, and `"search"`.
     */
-    'inputmode': 'none' | 'text' | 'tel' | 'url' | 'email' | 'numeric' | 'decimal' | 'search';
+    'inputmode'?: 'none' | 'text' | 'tel' | 'url' | 'email' | 'numeric' | 'decimal' | 'search';
     /**
     * The mode determines which platform styles to use.
     */

diff --git a/core/src/components/searchbar/readme.md b/core/src/components/searchbar/readme.md
diff --git a/core/src/components/searchbar/searchbar.tsx b/core/src/components/searchbar/searchbar.tsx
@@ -87,7 +87,7 @@ export class Searchbar implements ComponentInterface {
    * Possible values: `"none"`, `"text"`, `"tel"`, `"url"`,
    * `"email"`, `"numeric"`, `"decimal"`, and `"search"`.
    */
-  @Prop() inputmode: 'none' | 'text' | 'tel' | 'url' | 'email' | 'numeric' | 'decimal' | 'search' = 'search';
+  @Prop() inputmode?: 'none' | 'text' | 'tel' | 'url' | 'email' | 'numeric' | 'decimal' | 'search';
 
   /**
    * Set the input's placeholder.

diff --git a/core/src/components/searchbar/usage/angular.md b/core/src/components/searchbar/usage/angular.md
@@ -42,4 +42,4 @@
 <ion-toolbar>
   <ion-searchbar></ion-searchbar>
 </ion-toolbar>
-```
+```
diff --git a/core/src/components/searchbar/usage/javascript.md b/core/src/components/searchbar/usage/javascript.md
@@ -42,4 +42,4 @@
 <ion-toolbar>
   <ion-searchbar></ion-searchbar>
 </ion-toolbar>
-```
+```
diff --git a/core/src/components/searchbar/usage/react.md b/core/src/components/searchbar/usage/react.md
@@ -49,4 +49,4 @@ export const SearchbarExample: React.FC = () => (
     </IonToolbar>
   </IonContent>
 );
-```
+```
diff --git a/core/src/components/searchbar/usage/vue.md b/core/src/components/searchbar/usage/vue.md
@@ -44,4 +44,4 @@
     <ion-searchbar></ion-searchbar>
   </ion-toolbar>
 </template>
-```
+```