fix(react): Don't render overlay children if isOpen is false, fixes #…

…20225 (#20226)
ionic-team · Jan 17, 2020 · aff9612 · aff9612
1 parent 22f9229
commit aff9612
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/react/src/components/createOverlayComponent.tsx b/packages/react/src/components/createOverlayComponent.tsx
@@ -40,7 +40,7 @@ export const createOverlayComponent = <OverlayComponent extends object, OverlayT
     }
 
     componentDidMount() {
-      if (this.props.isOpen as boolean) {
+      if (this.props.isOpen) {
         this.present();
       }
     }
@@ -92,7 +92,7 @@ export const createOverlayComponent = <OverlayComponent extends object, OverlayT
 
     render() {
       return ReactDOM.createPortal(
-        this.props.children,
+        this.props.isOpen ? this.props.children : null,
         this.el
       );
     }