Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(title): add support for small title #19215

Merged
merged 19 commits into from Sep 5, 2019
Merged

feat(title): add support for small title #19215

merged 19 commits into from Sep 5, 2019
+668 −325

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Aug 28, 2019 •
edited

✅ Ready to Merge ✅

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: closes #18898

What is the new behavior?

  • Adds support for small size in title
  • Updates styles on the toolbar / searchbar for iOS 13

Screen Shot 2019-08-28 at 4 01 10 PM

master branch
ios master sizes ios branch sizes
md master sizes md branch sizes

Does this introduce a breaking change?

  • Yes
  • No

Other information

Usage information:

<ion-header>
  <ion-toolbar>
    <ion-title size="small">Choose a contact to add to Favorites</ion-title>
  </ion-toolbar>
  <ion-toolbar>
    <ion-title>Contacts</ion-title>
    <ion-buttons slot="end">
      <ion-button>Cancel</ion-button>
    </ion-buttons>
  </ion-toolbar>
  <ion-toolbar>
    <ion-searchbar></ion-searchbar>
  </ion-toolbar>
</ion-header>

manucorporat
manucorporat reviewed Aug 30, 2019
View reviewed changes
core/src/components/searchbar/searchbar.tsx Outdated Show resolved Hide resolved
core/src/components/segment/segment.tsx Show resolved Hide resolved
core/src/components/title/test/sizes/e2e.ts Outdated Show resolved Hide resolved
core/src/components/title/test/sizes/e2e.ts Outdated Show resolved Hide resolved
core/src/components/title/title.tsx Outdated Show resolved Hide resolved
@brandyscarney brandyscarney changed the base branch from next to master August 30, 2019 17:54
liamdebeasi and others added 11 commits August 30, 2019 14:12
@liamdebeasi @brandyscarney
refactor(toast): remove showCloseButton and closeButtonText (#18957)
35fd2fa 
* Remove close button

* update tests

* update tests

* add build
@manucorporat @brandyscarney
refactor(): deprecate web component controllers (#19109)
6f2f7fc
@brandyscarney
feat(title): add support for small title
52c41f3 
closes #18898
@brandyscarney
style(toolbar): disable stylelint
412b0bd
@brandyscarney
test(title): update sizes test
aea6d13
@brandyscarney
chore(toolbar): build usage docs
e2cfd8f 
removes ionStyle from the public API / documentation it should not have been in as it should be used internally only
@brandyscarney @manucorporat
Update core/src/components/searchbar/searchbar.tsx
b548faf 
Co-Authored-By: Manu MA <manu.mtza@gmail.com>
@brandyscarney
test(title): remove waits
2fb13c4
@brandyscarney
fix(title): remove default size, emit style for size on connected
4e07cf7
@brandyscarney
chore: build and lint fixes
5823ce2
@brandyscarney
fix(title): add styling for MD small title
7d0e90c
@brandyscarney brandyscarney mentioned this pull request Sep 5, 2019
Closed
@brandyscarney brandyscarney merged commit e27962d into master Sep 5, 2019
@brandyscarney brandyscarney deleted the feat-header-note branch September 5, 2019 21:32
brandyscarney added a commit that referenced this pull request Sep 16, 2019
@brandyscarney
feat(title): add support for small title (#19215)
5d669cf 
Updates title to include `small` size and updates searchbar and UI to match native.

closes #18898
brandyscarney added a commit that referenced this pull request Oct 2, 2019
@brandyscarney
feat(title): add support for small title (#19215)
739a97a 
Updates title to include `small` size and updates searchbar and UI to match native.

closes #18898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manucorporat manucorporat manucorporat approved these changes

@liamdebeasi liamdebeasi liamdebeasi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: iOS toolbar small title
3 participants
@brandyscarney @manucorporat @liamdebeasi