Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix angular double initialize #19393

Merged
merged 3 commits into from Sep 20, 2019
Merged

Conversation

manucorporat
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: angular @ionic/angular package label Sep 19, 2019
@manucorporat manucorporat merged commit e98769e into master Sep 20, 2019
@manucorporat manucorporat deleted the fix-angular-double-initialize branch September 20, 2019 12:29
@arnauddrain
Copy link

Hello, this warning is great, but it adds a lot of WARN during unit testing.
The warning appears between each of my unit tests in my Ionic 4 / Angular 8 application.
Should I open an issue for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants