Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list): add bottom border for first item in inset list #19525

Merged
merged 1 commit into from Oct 2, 2019
Merged

fix(list): add bottom border for first item in inset list #19525

merged 1 commit into from Oct 2, 2019

Conversation

liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Oct 2, 2019 •
edited

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #19507

What is the new behavior?

  • Revised the CSS logic so that the first item has a bottom border but not a top border

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Oct 2, 2019
brandyscarney
brandyscarney approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liamdebeasi liamdebeasi merged commit 71b8853 into master Oct 2, 2019
@liamdebeasi liamdebeasi deleted the item-underline branch October 2, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liamdebeasi @brandyscarney