Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(picker): pick closest option at low velocity #19660

Merged
merged 1 commit into from Jan 9, 2020
Merged

fix(picker): pick closest option at low velocity #19660

merged 1 commit into from Jan 9, 2020

Conversation

greimela
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #19659

What is the new behavior?

Select the closest picker option when releasing the picker column at rest.

This makes it easier to pick a specific option since it is closer to the behavior of the native iOS picker.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@greimela
fix(picker): pick closest option at low velocity
a12a0fd 
Select the closest picker option when releasing the picker at low velocity.
This makes it easier to pick a specific option since it is closer to the behavior of the native iOS picker.
@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Oct 14, 2019
yatinmob
yatinmob approved these changes Oct 17, 2019
View reviewed changes
Copy link

@yatinmob yatinmob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekly-digest weekly-digest bot mentioned this pull request Oct 18, 2019
Closed
@Maikell84
Copy link

Thank you, Looks very good.
Can you please Merge this asap? We strongly need this fix.

@robingenz
Copy link
Contributor

That's exactly what I need.
Can you merge this asap?

@havok1983
Copy link

go for it

@Maikell84
Copy link

Any news? Why is this not merged yet?
Any comments from the ionic team?

@greimela
Copy link
Contributor Author

Hi @liamdebeasi, is there anything missing that prevents this change from getting merged?
Seems like some people are waiting for this fix.

liamdebeasi
liamdebeasi approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🎉

@liamdebeasi liamdebeasi merged commit 39d1262 into ionic-team:master Jan 9, 2020
@liamdebeasi
Copy link
Member

Merged. Thank you!

@liamdebeasi liamdebeasi mentioned this pull request Jan 9, 2020
Closed
@greimela greimela deleted the fix-datetime-low-velocity branch January 10, 2020 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamdebeasi liamdebeasi liamdebeasi approved these changes

@yatinmob yatinmob yatinmob approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@greimela @Maikell84 @robingenz @havok1983 @liamdebeasi @yatinmob