fix(header): avoid flicker on collapsible header load #19682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created a dev build for this |
|
I tried, and this work well🎉 |
elylucas
pushed a commit
that referenced
this pull request
Oct 30, 2019
* fix flicker on collapse load * remove old test
mhartington
pushed a commit
that referenced
this pull request
Oct 31, 2019
* fix flicker on collapse load * remove old test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The main header had a transition always applied (even if not using collapsible header). For collapsible headers, this caused the main title/buttons to appear briefly before fading out which was a bit jarring.
What is the new behavior?
I made it so that the transition is only applied a) for the collapsible header and b) after the buttons/title have already been hidden
Does this introduce a breaking change?
Other information