Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): only animate large title if back button is in start slot #19846

Merged
merged 1 commit into from Nov 6, 2019

Conversation

liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Nov 6, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #19840

What is the new behavior?

  • Make sure back button is in start slot before determining whether or not to animate

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Nov 6, 2019
@liamdebeasi liamdebeasi marked this pull request as ready for review November 6, 2019 14:19
@liamdebeasi liamdebeasi merged commit cace1b3 into master Nov 6, 2019
@liamdebeasi liamdebeasi deleted the collapsible-back branch November 6, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant