Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gesture): release gesture when disabling #19855

Merged
merged 2 commits into from Nov 12, 2019
Merged

Conversation

liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Nov 7, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #19848

Disabling a gesture while in the middle of said gesture leave it at an inconsistent state as the gesture system things a gesture is already in progress and as a result does not let you start a new one.

This is commonly found when disabling gesture based Ionic components via a third party gesture (such as HammerJS).

What is the new behavior?

  • Reset the state of the gesture when disabling the gesture

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Nov 7, 2019
@liamdebeasi liamdebeasi marked this pull request as ready for review November 7, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant