Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Ionic React Icon Type Regression #20229

Closed
elylucas opened this issue Jan 17, 2020 · 1 comment
Closed

bug: Ionic React Icon Type Regression #20229

elylucas opened this issue Jan 17, 2020 · 1 comment
Labels
package: react @ionic/react package

Comments

@elylucas
Copy link
Contributor

Bug Report

There was a recent change to strongly type icons to {ios: string, md: string}, however, not all icons are of this type. Some are strings as well.

Ionic version:

[x] 4.11.8

Current behavior:
Icons that are just strings error when trying to assign them to the icon prop on IonIcon

Expected behavior:
Icons that are strings should work.

Steps to reproduce:

Related code:

insert short code snippets here

Other information:

Ionic info:

insert the output from ionic info here
@ionitron-bot
Copy link

ionitron-bot bot commented Feb 17, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: react @ionic/react package
Projects
None yet
Development

No branches or pull requests

1 participant