Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): fix issues with button states #20278

Merged
merged 8 commits into from Jan 27, 2020
Merged

fix(components): fix issues with button states #20278

merged 8 commits into from Jan 27, 2020

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jan 23, 2020 •
edited

  • Update action sheet colors to match spec (md)
  • Remove activated background on buttons (md - uses ripple)
  • Update Segment Button to use proper indicator color when inside of a toolbar
  • Add back input highlight on focus

fixes #20276

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Jan 23, 2020
@brandyscarney brandyscarney mentioned this pull request Jan 24, 2020
Closed
@brandyscarney
Copy link
Member Author

Ready for review

@brandyscarney
Copy link
Member Author

These changes break custom, without having background steps:

Screen Shot 2020-01-24 at 5 15 24 PM

@brandyscarney brandyscarney merged commit 628db18 into master Jan 27, 2020
@brandyscarney brandyscarney deleted the fix-state-issues branch January 27, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamdebeasi liamdebeasi liamdebeasi approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Ionic 5 button state issues
2 participants
@brandyscarney @liamdebeasi