fix(segment): add activated class directly to segment button #20400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
This gets around a bug with Safari where the ::slotted css selector was not working properly
To reproduce, on master:
src/components/segment/test/basic?ionic:mode=ios
test in ChromeIt may help to visualize it better, the
--indicator-transform
property can be changed on the segment buttons like--indicator-transform: scale(0.5)
Repeat on this branch, see the scale working properly.
What is the new behavior?
Indicator scales properly on Safari.
Does this introduce a breaking change?
Other information