Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header): collapsable header should default to using content background #20736

Merged
merged 4 commits into from Mar 11, 2020

Conversation

liamdebeasi
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #20691

What is the new behavior?

  • Default to using --ion-background-color

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added package: angular @ionic/angular package package: core @ionic/core package labels Mar 10, 2020
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you drop a dev build for me 😇

core/src/components/header/header.ios.scss Show resolved Hide resolved
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
@liamdebeasi
Copy link
Member Author

Dev build: 5.1.0-dev.202003101540.0f5b4d1

@liamdebeasi liamdebeasi merged commit f6c3ba7 into master Mar 11, 2020
@liamdebeasi liamdebeasi deleted the large-title-toolbar-bg branch March 11, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants