Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): respect card-style modal spec for iPadOS #20750

Merged
merged 14 commits into from Mar 25, 2020
Merged

Conversation

liamdebeasi
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #20700

What is the new behavior?

  • updated animation to account for iPadOS card modal spec

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Mar 11, 2020
@liamdebeasi liamdebeasi marked this pull request as ready for review March 17, 2020 17:10
@DwieDima
Copy link
Contributor

DwieDima commented Apr 3, 2020

@liamdebeasi

since Ionic Version 5.0.7 it's no longer possible to override --width and --height of card-style-modal.
In dev build 5.1.0-dev.202003171608.9d9a02f, it was.

@liamdebeasi
Copy link
Member Author

@DwieDima Please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants