Fixed time zone issue in tests #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of datetime's fromtimestamp method in test_cache_request_unfresh_max_ageis a problem since it honors local time zone.
Then the http Date header forged is not UTC/GMT.
It makes this particular test fail for positive UTC offset time zone
such as mine (France UTC+0100 winter time).
I also switched to time only and drop all datetime method as it
is sometime confusing because of its naive/aware timezone property.
Also add GMT tag in TIME_FMT :
http://tools.ietf.org/html/rfc2616#section-3.3
|
Please try to reproduce the issue before merging in order to validate my understanding of the problem. Setting your time zone to something positive (ie. east of UTC such as France/Paris) should trigger it if I'm right. |
| now = datetime.datetime.fromtimestamp(earlier).strftime(TIME_FMT) | ||
|
|
||
| earlier = time.time() - 3700 # epoch - 1h01m40s | ||
| now = time.strftime(TIME_FMT, time.gmtime(earlier)) |
There was a problem hiding this comment.
The useful part is here, I decided then to remove all datetime references but this is not necessary, only a matter of taste because I believe its naive/aware approach of TZ is confusing.
ionrock
added a commit
that referenced
this pull request
Feb 26, 2014
Fixed time zone issue in tests
|
@mxjeff Great work! You make an excellent point regarding timezones. That is another good question to discuss in the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of datetime's fromtimestamp method in test_cache_request_unfresh_max_age is a problem since it honors local time zone. Then the http Date header forged is not UTC/GMT.
It makes this particular test fail for positive UTC offset time zone such as mine (France UTC+0100 winter time).
I also switched to time only and drop all datetime method as it is sometime confusing because of its naive/aware timezone property.
Also add GMT tag in TIME_FMT :
http://tools.ietf.org/html/rfc2616#section-3.3