Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.2 release notes #4555

Closed
wants to merge 4 commits into from
Closed

1.2.2 release notes #4555

wants to merge 4 commits into from

Conversation

fpesce
Copy link
Contributor

@fpesce fpesce commented Jun 25, 2019

Please provide a description for what this PR is for.

And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[X] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[X] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

content/boilerplates/notes/1.2.1.md Outdated Show resolved Hide resolved
content/boilerplates/notes/1.2.1.md Outdated Show resolved Hide resolved
content/boilerplates/notes/1.2.1.md Outdated Show resolved Hide resolved
## Bug fixes and minor enhancements

- Fix duplicate CRD being generated in the install ([Issue 14976](https://github.com/istio/istio/issues/14976))
- Allow users to disable istio default retries by setting retries to 0 ([Issue 14900](https://github.com/istio/istio/issues/14900))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be great if we can indicate what the default is (think it is 2 or 3), and how to reset it to 0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Configure Redis latency in microseconds ([Pull Request 15119](https://github.com/istio/istio/pull/15119))
- Do not overwrite Citadel storage namespace with env var ([Pull Request 15082](https://github.com/istio/istio/pull/15082))
- Add toleration for Istio components ([Pull Request 15081](https://github.com/istio/istio/pull/15081))
- set nodeagent updateStrategy to RollingUpdate ([Pull Request 15129](https://github.com/istio/istio/pull/15129)) ([Issue 15020](https://github.com/istio/istio/issues/15020))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix cause of 'TLS error: Secret is not supplied by SDS' errors during upgrade (Issue 15020).
  • Fix crash in Istio's JWT Envoy filter caused by malformed JWT (Issue 15084).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duderino You are commenting the 1.2.1 release note, I was going to open another PR for 1.2.2 which included these ones. I can continue with this and rename everything to 1.2.2

@linsun
Copy link
Member

linsun commented Jun 28, 2019

overall comennt: looking at the release note 1.2.1, seems some changes aren't super critical but we still allow them in... it could be release note didn't explain the user impact.

@fpesce
Copy link
Contributor Author

fpesce commented Jun 28, 2019

@duderino / @linsun : Thanks for the comments. Regarding this kind of PR (document heavy), I'd highly recommend to submit your suggestion as such (through the github suggestion button that appears on the top right-center of the comment zone)

@fpesce fpesce changed the title 1.2.1 release notes 1.2.2 release notes Jun 28, 2019
content/about/notes/1.2.1/index.md Outdated Show resolved Hide resolved
content/about/notes/1.2.1/index.md Outdated Show resolved Hide resolved
content/about/notes/1.2.1/index.md Outdated Show resolved Hide resolved
content/blog/2019/announcing-1.2.1/index.md Outdated Show resolved Hide resolved
content/blog/2019/announcing-1.2.1/index.md Outdated Show resolved Hide resolved
content/boilerplates/notes/1.2.1.md Outdated Show resolved Hide resolved
content/boilerplates/notes/1.2.1.md Outdated Show resolved Hide resolved
content/boilerplates/notes/1.2.1.md Outdated Show resolved Hide resolved
content/boilerplates/notes/1.2.1.md Outdated Show resolved Hide resolved
content/boilerplates/notes/1.2.1.md Outdated Show resolved Hide resolved
Francois Pesce added 2 commits June 27, 2019 23:46
- Remove references to Pull Requests
- Clarification of fixes
- Removal of cosmetic/debugging changes
- Removal of details regarding redis feature
@fpesce
Copy link
Contributor Author

fpesce commented Jun 28, 2019

This is just kept for comment/PR purpose, I have to re-open a PR with correct file naming (this was supposed to be 1.2.1 release note, but we are skipping to 1.2.2)

@@ -0,0 +1,10 @@
---
title: Istio 1.2.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to 1.2.1?

- Allow users to disable istio default retries by setting retries to 0 ([Issue 14900](https://github.com/istio/istio/issues/14900))
- Fix Mixer unable to start when Galley is disabled ([Issue 14841](https://github.com/istio/istio/issues/14841))
- Add HTTP/1.0 support to gateway configuration generation ([Issue 13085](https://github.com/istio/istio/issues/13085))
- Redis filter (this feature is guarded with the environment feature flag PILOT_ENABLE_REDIS_FILTER, disabled by default):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to actually say something beyond "Redis filter", and sentence ends with a colon.

- Add HTTP/1.0 support to gateway configuration generation ([Issue 13085](https://github.com/istio/istio/issues/13085))
- Redis filter (this feature is guarded with the environment feature flag PILOT_ENABLE_REDIS_FILTER, disabled by default):
- Fix: Environment variable shadowing (NAMESPACE is used for listened namespaces and overwrites Citadel storage namespace (istio-system))
- Add [toleration](https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/) for Istio components ([Pull Request 15081](https://github.com/istio/istio/pull/15081))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't link to PRs in release notes.

This should be linking to an updated doc page instead if needed.

@@ -0,0 +1,12 @@
## Bug fixes and minor enhancements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we completely separate bug fixes from enhancements? Then you don't need to say "Fix:" everywhere.

@fpesce
Copy link
Contributor Author

fpesce commented Jun 28, 2019

@geeknoid : just saw your comments, I'll address them.

@fpesce fpesce closed this Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants