@@ -94,22 +94,28 @@ DomPredictionHelper.prototype.tokenizeCss = function(css_string) {
var skip = false;
var word = '';
var tokens = [];
-// if (css_string.substring(0,1) != ' ') css_string = " " + css_string;
- jQuery.each(css_string.replace(/,/, ' , ').replace(/\s+/g, ' ').split(''), function() {
+
+ var css_string = css_string.replace(/,/, ' , ').replace(/\s+/g, ' ');
+ var length = css_string.length;
+ var c = '';
+
+ for (var i = 0; i < length; i++){
+ c = css_string[i];
+
if (skip) {
skip = false;
- } else if (this == '\\') {
+ } else if (c == '\\') {
skip = true;
- } else if (this == '.' || this == ' ' || this == '#' || this == '>' || this == ':' || this == ',') {
+ } else if (c == '.' || c == ' ' || c == '#' || c == '>' || c == ':' || c == ',') {
if (word.length > 0) tokens.push(word);
word = '';
}
- word += this;
- if (this == ' ' || this == ',') {
+ word += c;
+ if (c == ' ' || c == ',') {
tokens.push(word);
word = '';
}
- });
+ }
if (word.length > 0) tokens.push(word);
return tokens;
};
lib/dom.js
@@ -53,8 +53,6 @@
<h2>Results</h2>
<p>Milliseconds for 100 calls</p>
- <dl id='results'>
-
- </dl>
+ <dl id='results'></dl>
</body>
</html>
sites/test/testCSSTokenizing.html
908786de23debbfaf4670adc91e8bef6730fbb3c
Adam Sanderson
netghost@gmail.com
http://github.com/iterationlabs/selectorgadget/commit/ace04798cac57957ca1e5b7ed1e4c9182828f312
ace04798cac57957ca1e5b7ed1e4c9182828f312
2009-04-11T19:45:51-07:00
2009-04-11T19:10:09-07:00
Speed up tokenizeCss.
Use a for loop instead of jQuery.each, on longer strings you get around a 5x improvement.
(cherry picked from commit 773a33b38035cdae720b5dca7c1705b6f190560f)
095e76ff6306a1fd2b849b6c3fab72e17708377b
Adam Sanderson
netghost@gmail.com