From ab93c165c89b467b2a53d46f0b292e484dd56cca Mon Sep 17 00:00:00 2001 From: Alexis Jacomy Date: Wed, 27 Mar 2024 19:48:43 +0100 Subject: [PATCH] [lint] Adds no-console rule --- .eslintrc | 2 +- packages/storybook/stories/large-graphs/stories.ts | 5 +---- packages/test/app/index.ts | 1 - packages/test/unit/utils.ts | 2 -- 4 files changed, 2 insertions(+), 8 deletions(-) diff --git a/.eslintrc b/.eslintrc index 7fa3bcc4e..599f9e7e9 100644 --- a/.eslintrc +++ b/.eslintrc @@ -15,8 +15,8 @@ "plugin:storybook/recommended" ], "rules": { - "no-unused-vars": "off", "no-prototype-builtins": "off", + "no-console": "warn", "import/extensions": [ "warn", "never", diff --git a/packages/storybook/stories/large-graphs/stories.ts b/packages/storybook/stories/large-graphs/stories.ts index e7dc9321a..ed511f305 100644 --- a/packages/storybook/stories/large-graphs/stories.ts +++ b/packages/storybook/stories/large-graphs/stories.ts @@ -46,10 +46,7 @@ type Story = StoryObj; export const story: Story = { name: "Performances showcase", - render: (args) => { - console.log("template", args); - return template; - }, + render: () => template, play, args: { order: 5000, diff --git a/packages/test/app/index.ts b/packages/test/app/index.ts index 8b8afa351..d5a2f6840 100644 --- a/packages/test/app/index.ts +++ b/packages/test/app/index.ts @@ -73,7 +73,6 @@ const dependencies: BrowserTestDependencies = { rafNTimes, }; -console.log("GLOBALIZE DEPENDENCIES"); globalize({ dependencies, }); diff --git a/packages/test/unit/utils.ts b/packages/test/unit/utils.ts index 473bd9fb2..84df4c6d3 100644 --- a/packages/test/unit/utils.ts +++ b/packages/test/unit/utils.ts @@ -7,8 +7,6 @@ import { describe, expect, test } from "vitest"; describe("validateGraph utils", () => { test("it should work on a valid graph", () => { - console.log("window", typeof window.document.getElementById); - // Create a valid random graph const graph = erdosRenyi(UndirectedGraph, { order: 100, probability: 0.2 }); randomLayout.assign(graph);