@@ -36,7 +36,7 @@ class TagsController < ApplicationController private def tags_in_project - @tag_name = params[:id] + @tag_name = CGI.unescape(params[:id]) @active_project = Project.find(params[:project_id]) rescue nil return if !verify_project app/controllers/tags_controller.rb @@ -71,7 +71,7 @@ module ApplicationHelper return '--' if tags.empty? tags.collect do |tag| - link_to h(tag), project_tag_path(object.project_id, tag) + link_to h(tag), project_tag_path(object.project_id, CGI.escape(tag)) end.join(', ') end app/helpers/application_helper.rb @@ -6,7 +6,7 @@ <ul class="listWithDetails"> <% is_public = @logged_user.member_of_owner? %> <% @tag_names.each do |tag| -%> - <li><%= link_to h(tag.tag), project_tag_path(@active_project, tag.tag) %> <span class="desc"> - <%= :tag_object_count.l_with_args(:count => Tag.count_by(tag.tag, @active_project, !@logged_user.member_of_owner?)) %></span></li> + <li><%= link_to h(tag.tag), project_tag_path(@active_project, CGI.escape(tag.tag)) %> <span class="desc"> - <%= :tag_object_count.l_with_args(:count => Tag.count_by(tag.tag, @active_project, !@logged_user.member_of_owner?)) %></span></li> <% end %> </ul> </div> app/views/projects/_search_sidebar.html.erb e2e4aecde308780fff7b1e4912d4d469ae7af81f jamesu jamesu@gmail.com http://github.com/jamesu/railscollab/commit/00f71b6299e7340f79f0a994f050af7703f33f45 00f71b6299e7340f79f0a994f050af7703f33f45 2009-11-08T04:54:06-08:00 2009-11-08T04:54:06-08:00 Fix browsing tags with URL characters. Closes #gh-24 c5122322f3a1218a8bebe54990791c8ee28b5678 jamesu jamesu@gmail.com