Issues - janv/rest_in_place

janv / rest_in_place

Description:

A RESTful Inplace-Editor

Sort by: Priority | Votes | Last Updated

Loading…

2.

0 votes

acknowledged
x

Bills Safari Issues
1 comment Created 5 months ago by janv

Title

Body
Bill Siggelkow [writes](http://jan.varwig.org/projects/rest-in-place#comment-941): > Very nice plugin. The only problem I am having is with Safari. When I click on a field in a the generated form does not show the oldValue from the table cell in the input field. However, when I inspect the input element it does have the oldValue set in the field. I tried getting around this with some jQuery calls to no avail. > > I basically made two changes to jquery.rest-in-place.js … > First, I stripped leading/trailing whitespace from the oldValue … this helped alot with my tabular data. > > `var oldValue = e.html().replace(/^s|s$/g,”);` > > Then, I added a call after the form is injected to set focus to the input field … this give me good behavior in Safari 3/4. > > `e.find(”input”)[0].focus();`
or cancel

Bill Siggelkow writes:

Very nice plugin. The only problem I am having is with Safari. When I click on a field in a the generated form does not show the oldValue from the table cell in the input field. However, when I inspect the input element it does have the oldValue set in the field. I tried getting around this with some jQuery calls to no avail.

I basically made two changes to jquery.rest-in-place.js …
First, I stripped leading/trailing whitespace from the oldValue … this helped alot with my tabular data.

var oldValue = e.html().replace(/^s|s$/g,”);

Then, I added a call after the form is injected to set focus to the input field … this give me good behavior in Safari 3/4.

e.find(”input”)[0].focus();

Comments

janv Sun Jun 14 04:04:37 -0700 2009 | link

Not sure I understand the problem, sample code would be helpful

Comment
Not sure I understand the problem, sample code would be helpful
or cancel

Parsed with GitHub Flavored Markdown
3.

0 votes

accepted
x

Implement Sam Rubys suggestions
0 comments Created 5 months ago by janv

Title

Body
http://www.intertwingly.net/blog/2009/06/14/Rest-In-Place
or cancel

http://www.intertwingly.net/blog/2009/06/14/Rest-In-Place

Comments

Parsed with GitHub Flavored Markdown
4.

0 votes

accepted
x

Make gemspec
0 comments Created 4 months ago by janv

Title

Body
Gem plugins are teh shit right now !?
or cancel

Gem plugins are teh shit right now !?

Comments

Parsed with GitHub Flavored Markdown
5.

0 votes

accepted
x

acknowledged
x

When trying to deploy this, the symlink to the js file from testapp/public/javascripts causes failure
3 comments Created 17 days ago by contentfree

Title

Body
If the testapp dir is copied before the javascripts dir, then the symlink points no where and causes FileUtils.cp_r to blow up with an Errno::ENOENT. I suggest removing the symlink and replacing with a rake task that copies the latest into the appropriate place in the test app before running the tests.
or cancel

If the testapp dir is copied before the javascripts dir, then the symlink points no where and causes FileUtils.cp_r to blow up with an Errno::ENOENT.

I suggest removing the symlink and replacing with a rake task that copies the latest into the appropriate place in the test app before running the tests.

Comments

janv Thu Nov 12 01:29:49 -0800 2009 | link

Which platform are you on? windows?

Comment
Which platform are you on? windows?
or cancel

contentfree Thu Nov 12 01:37:55 -0800 2009 | link

Ubuntu 8.10 (on EC2)

Comment
Ubuntu 8.10 (on EC2)
or cancel

janv Thu Nov 12 01:48:53 -0800 2009 | link

Could you post a stacktrace so I can see where exactly the cp_r call happens?

Comment
Could you post a stacktrace so I can see where exactly the cp_r call happens?
or cancel

Parsed with GitHub Flavored Markdown
6.

0 votes

use correct accept header type
2 comments Created 14 days ago by dgm

Title

Body
If the respnase back to the client is rendered as json, the request query should specify "aaplication/json" instead of "application/javascript". This would free up the javascript response: respond_to do |format| format.html # show.html.erb format.xml { render :xml => @person } format.json { render :json => @person} format.js # show.js.erb end
or cancel
If the respnase back to the client is rendered as json, the request query should specify "aaplication/json" instead of "application/javascript". This would free up the javascript response:
```
respond_to do |format|
    format.html # show.html.erb
    format.xml  { render :xml => @person }
    format.json { render :json => @person}
    format.js  # show.js.erb
end
```
Comments

dgm Sat Nov 14 19:40:01 -0800 2009 | link

I discovered that jrails plugin interferes with normal jquery behaviour - Once I removed it, I was able to change rest in place by changing the Accept header to application/json

Comment
I discovered that jrails plugin interferes with normal jquery behaviour - Once I removed it, I was able to change rest in place by changing the Accept header to application/json
or cancel

dgm Sat Nov 21 21:21:29 -0800 2009 | link

fixed in d73c55f

Comment
fixed in d73c55f82ba97cf7462fab087927e8a68bc103ca
or cancel

Parsed with GitHub Flavored Markdown
7.

0 votes

Saving is non-intuitive
2 comments Created 12 days ago by contentfree

Title

Body
An improvement would be to add a "Save" link that submits the form.
or cancel

An improvement would be to add a "Save" link that submits the form.

Comments

dgm Mon Nov 16 15:00:39 -0800 2009 | link

While you're at it, why not make text boxes for all your items and submit the form all at once with a submit button? ;)

Actually, it shouldn't be all that hard. :)

Comment
While you're at it, why not make text boxes for all your items and submit the form all at once with a submit button? ;) Actually, it shouldn't be all that hard. :)
or cancel

contentfree Mon Nov 16 15:18:37 -0800 2009 | link

Don't be silly, dgm.

My suggestion is just to make the saving process of inline editing intuitive. If there's no save button and clicking on the text starts editing it, then it's not a big step for a person to think that clicking out of the text will save it which of course fails. We've already received feedback to that end on an app we're building. Maybe another option would be to add a styleable (or hideable) span tag with some text: "Press Enter to save".

Comment
Don't be silly, dgm. My suggestion is just to make the saving process of inline editing intuitive. If there's no save button and clicking on the text starts editing it, then it's not a big step for a person to think that clicking out of the text will save it which of course fails. We've already received feedback to that end on an app we're building. Maybe another option would be to add a styleable (or hideable) span tag with some text: "Press Enter to save".
or cancel

Parsed with GitHub Flavored Markdown