<?xml version="1.0" encoding="UTF-8"?>
<commit>
  <added type="array">
    <added>
      <filename>examples/large_file_test.rb</filename>
    </added>
  </added>
  <modified type="array">
    <modified>
      <diff>@@ -1,7 +1,13 @@
 These are things todo:
 
-+ Clean up licensing everywhere
+* refactor find_itemsets to be find_association_rules
+
 * Clean up documentation
+  * README.txt
+  * apriori.rb
+  * create an example file
 * make a ruby gem
+
++ Clean up licensing everywhere
 + get the typical install to work
-* clean up the rakefile
++ clean up the rakefile</diff>
      <filename>TODO.txt</filename>
    </modified>
    <modified>
      <diff>@@ -12,7 +12,8 @@ void Init_mytest();
 // Prototype for our method 'test1' - methods are prefixed by 'method_' here
 VALUE method_do_test_apriori(VALUE self);
 //VALUE method_test_hash_ap(VALUE self, VALUE filein, VALUE fileout, VALUE opts);
-VALUE method_find_association_rules(VALUE self, VALUE filein, VALUE fileout, VALUE opts);
+//VALUE method_find_association_rules(VALUE self, VALUE filein, VALUE fileout, VALUE opts);
+
 VALUE method_ap_do_apriori(VALUE self, VALUE rargv); 
 
 // The initialization method for this module</diff>
      <filename>ext/Apriori.c</filename>
    </modified>
    <modified>
      <diff>@@ -39,7 +39,7 @@ module Apriori
   #
   # this will probably become refactored out and then use a block b/c most
   # of the setup is always the same
-  def self.find_itemsets(input, opts={})
+  def self.find_association_rules(input, opts={})
     args = []
     
     # create the input file</diff>
      <filename>lib/apriori.rb</filename>
    </modified>
    <modified>
      <diff>@@ -9,12 +9,12 @@ class TestApriori &lt; Test::Unit::TestCase
   
   def test_truth
     input = File.join(FIXTURES_DIR + &quot;/market_basket_string_test.txt&quot;)
-    assert rules = Apriori.find_itemsets(input)
+    assert rules = Apriori.find_association_rules(input)
   end
 
   def test_calling_all_the_options
     input = File.join(FIXTURES_DIR + &quot;/market_basket_string_test.txt&quot;)
-    assert rules = Apriori.find_itemsets(input, 
+    assert rules = Apriori.find_association_rules(input, 
                               :min_items =&gt; 2,
                               :max_items =&gt; 5,
                               :min_support =&gt; 1, 
@@ -30,7 +30,7 @@ class TestApriori &lt; Test::Unit::TestCase
                       %w{apple cheese}, 
                       %w{apple doritos} ]
 
-    rules = Apriori.find_itemsets(transactions,
+    rules = Apriori.find_association_rules(transactions,
                               :min_items =&gt; 2,
                               :max_items =&gt; 5,
                               :min_support =&gt; 1, 
@@ -43,4 +43,26 @@ class TestApriori &lt; Test::Unit::TestCase
     # puts rules.join(&quot;\n&quot;)
   end
 
+  def test_returning_no_results
+    # currently the application exits. thats no good! just give a message
+    transactions = [  %w{beer doritos},
+                      %w{apple cheese}, 
+                      %w{beer doritos}, 
+                      %w{apple cheese}, 
+                      %w{apple cheese}, 
+                      %w{apple doritos} ]
+
+    # crazy numbers that will never return any rules
+    rules = Apriori.find_association_rules(transactions,
+                              :min_items =&gt; 5,
+                              :max_items =&gt; 5,
+                              :min_support =&gt; 100, 
+                              :max_support =&gt; 100, 
+                              :min_confidence =&gt; 20)
+
+    assert_equal 0, rules.size
+
+    # also, make notes that if you get more rules, a common thing to do is to reduce the min_support to a very small float
+  end
+
 end</diff>
      <filename>test/unit/test_apriori.rb</filename>
    </modified>
  </modified>
  <removed type="array"/>
  <parents type="array">
    <parent>
      <id>d33fd5e94e18c4c5b0f4cbad2592fdef37914dea</id>
    </parent>
  </parents>
  <author>
    <name>Nate Murray</name>
    <email>nate@natemurray.com</email>
  </author>
  <url>http://github.com/jashmenn/apriori/commit/486072f744ee982911daf9ff0b526ba82fc0ab5a</url>
  <id>486072f744ee982911daf9ff0b526ba82fc0ab5a</id>
  <committed-date>2008-09-02T18:41:14-07:00</committed-date>
  <authored-date>2008-09-02T18:41:14-07:00</authored-date>
  <message>changed find_itemsets -&gt; find_association_rules

added a test for large files</message>
  <tree>9fb00a7d12ecbf26fd01f91fdd76a28e5947dbd6</tree>
  <committer>
    <name>Nate Murray</name>
    <email>nate@natemurray.com</email>
  </committer>
</commit>
