Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is not possible to place .appex files beforehand in a particular folder so that they can be placed automatically in Plugins folder of app during the build process(OSX) #235

Closed
yuktikapahwa opened this issue Sep 19, 2016 · 145 comments

Comments

@yuktikapahwa
Copy link

yuktikapahwa commented Sep 19, 2016

There should be a common folder in JavaFX maven plugin for placing the .appex file initially so that it picks it up from there and places it automatically into the Plugins folder during the build process.

Currently , I have to write a script to copy the .appex file inside the Plugins folder after the application is built by the JAVAFX Maven Plugin.
This needs to be resolved.

@FibreFoX
Copy link
Member

Some reference: http://stackoverflow.com/q/39539031/1961102

Can you describe this a bit more? Where do you want that .appex-files being in what folder, and when? Maybe a small demo-project would be nice to have a more appropriate support from me.

@FibreFoX
Copy link
Member

Have you looked into the additionalAppResources-configuration?

@yuktikapahwa
Copy link
Author

Hi ,
I am already using the additionalAppResources tag in the plugin . But using that doesnt solve my problem . The .app which is built using the plugin has a Contents folder which further contains folders like Java ,Plugins,Resources,CodeSingature and MacOS. While the application is built using the javafx maven plugin , it asks to specify the additionalAppResources source and target. The target folder is the target/jfx/app from where the app bundle automatically picks it up and places in the main Java Folder of my app. But I need to place the source (.appex) not inside my Java folder rather inside the Plugins folder of my app (during the app building process not after that) . I am attaching a .png(screenshot) for the Contents folder of my main app bundle (after it gets built from the javafx maven plugin) I am also attaching the sample of my pom where I have specified the java fx maven plugin I am using . Please have a look at it and let me know if there is something wrong in the way i am specifying it.
screen shot 2016-09-20 at 11 44 18 am

Samplepom.docx

`

@FibreFoX
Copy link
Member

Hi, i may have an idea what this is about, but just to be sure: please post the pom-file nox as docx-file-format, the xml-file as is should be okay, or just inline this content. Makes it more secure for me (opening foreign files can be dangerous) and makes it searchable for others having similar questions/problems.

So to sum up, you need to have these appex-files not being inside the application-folder, but as part of you "whole-bundle", right? What Bundler are you using? Do you want to generate some DMG-file or PKG-file (aka "installer")?

@yuktikapahwa
Copy link
Author

Hi ,
Yes, I cant place this in the application folder because anything which is inside the application folder would straightaway be placed in the Java folder of my main application bundle . But I want it to go it in the Plugins folder of my application . So you need to specify a common location (folder) where I can place all the stuff which can be picked up from there during the build process and straightaway placed in the Plugins folder of my app.
I want to generate .app ,.dmg as well as .pkg . I need all three.
Just to clarify again , I will explain you what is happening . When the JavaFX maven plugin builds my app as abc.app , I right click on the app to see its Contents (on MAC OSX) . What I see in contents is the following folders -Java ,Plugins,Resources,CodeSingature and MacOS .I have also attached the snapshot for this above. When I go and check in the Plugins folder that is empty . Because the JavaFX Maven Plugin didnt have the workaround to place things in the Plugins folder during the build process. hence it is creating problem for me. I hope I am clear now. I am also attaching the inline xml code for the same.Thanks
SamplePom.xml.zip

@FibreFoX
Copy link
Member

I will take a deep look into placing files outside the "Application" itself on MacOSX-bundlers. If I find something, I will report back. (I think this time I fully understood your idea/feature-request)

@FibreFoX FibreFoX self-assigned this Sep 20, 2016
@yuktikapahwa
Copy link
Author

Thankyou so much . I will be waiting to hear back from you soon

@FibreFoX
Copy link
Member

FibreFoX commented Sep 20, 2016

I might have found a way, bit it gets tricky, and needs proper implementation for being compatible down to 1.8.0_20, don't expect this to be done within the next two days, it is more likely that this will be implemented next week. Or not even be implemented, this is currently just an idea which I have to try first, it even is possible that this will result in some new JDK-bug entry. This feature is not possible out-of-the-box, but might be another point for using this maven-plugin ;)

EDIT: another reason why opening an issue rather than opening an stackoverflow-thing ;)

@yuktikapahwa
Copy link
Author

Hi ,

Did you get a chance to look into this ?

@FibreFoX
Copy link
Member

Yes, the solution I was thinking of seems to work, but this week was really hard for me, and I'm implementing some new stuff I'm going to release in the next time.

On the upcoming weekend I hope to find the time to implement this. Sorry for having no feedback for such a long time.

@FibreFoX
Copy link
Member

FibreFoX commented Oct 5, 2016

If everything works out as planned, this will get available as some snapshot-version tomorrow

@FibreFoX
Copy link
Member

FibreFoX commented Oct 5, 2016

Hi @yuktikapahwa ,

can you try the current snapshopt-version 8.7.1-SNAPSHOT ? Please adjust your pom.xml accordingly to the sonatype-repo and further adjustments:

  • put your .appex files into the folder src/main/deploy/bundlers/pkg/Contents/PlugIns
  • add to your plugin-configuration <additionalBundlerResources>src/main/deploy/bundlers</additionalBundlerResources>
  • run mvn clean package (when having package-lifecycle-binding)
    or run mvn clean jfx:native (when having no lifecycle-binding)

The same goes for the additional .icns-files, they should go into src/main/deploy/bundlers/pkg/Contents/Resources (or appropiate, not tested ... due to no mac-system available)

@FibreFoX
Copy link
Member

FibreFoX commented Oct 5, 2016

If this does not work, I might need some other tweaks, just report any problem back here :)

@FibreFoX
Copy link
Member

FibreFoX commented Oct 5, 2016

Oh, you might need to duplicate some of your files, because every bundler has its own folder (I just re-read this thread to not miss anything)!

@yuktikapahwa
Copy link
Author

Hi ,

Thankyou for your reply.
I followed exactly the same steps that you mentioned . But it doesnt solve my purpose. Using your snapshot version , what it does is :
It uses the .appex file placed in deploy/bundlers/pkg/Contents/PlugIns from the build directory and places it to the mac temp folder inside a folder called pkg. (in the temp directory ) and doesnt use that at all. The .app file generated by the maven plugin during the build process still doesnt contain the .appex inside it in the PlugIns folder.
The logs during the build process print the following

Found additional bundler resources, trying to copy all files into build root.
[INFO] Copying additional bundler resources into: /var/folders/y3/jv117_75505fnk8htdrs0qm40000gr/T/fxbundler5691789455562613876/images

But this is not resolving the problem because we want these Plugins and Resources files to be placed inside the app not in any temp location.

@yuktikapahwa
Copy link
Author

screen shot 2016-10-05 at 2 12 53 pm

Please find the screenshot for the folder hierarchy that is created inside the temp location of my mac machine . But the builder doesnt use these files from the temp location to place it inside the .app during the build process.
Kindly let me know what should be done .

@FibreFoX
Copy link
Member

FibreFoX commented Oct 5, 2016

Thanks for testing this.

What bundler did you use for this? The "pkg"-bundler? There should have been some output like "Found additional bundler resources for bundler pkg. What happens when you set <bundler>pkg</bundler> inside plugin-configuration?

@yuktikapahwa
Copy link
Author

I am attaching some more screenshots

  1. First is the screenshot of the main application that is built using the javafx maven plugin.
    2)Second is the snapshot when we right click on the application bundle and cick on Show Package Contents
  2. Third is the Contents folder inside the app
  3. Fourth is when we select Contents and check what all it contains .
    The PlugIns folder inside the Contents should contain that .appex file and the Resources folder should contain the .icns file .
    But still it is not there.
    screen shot 2016-10-05 at 2 19 52 pm
    screen shot 2016-10-05 at 2 20 42 pm
    screen shot 2016-10-05 at 2 20 57 pm
    screen shot 2016-10-05 at 2 21 07 pm

@FibreFoX
Copy link
Member

FibreFoX commented Oct 5, 2016

Your screenshots are really worth it 👍 I didn't realized that mac-applications like this (using the "mac.app"-bundler) behave like "installers". (I really need to find some cheap one ...)

It is not possible to have this working with the "mac.app"-bundler, because it is deleting the target-folder. You are required to use "mac.appStore", "dmg" or "pkg" (these are the internal IDs of the bundlers, so you need to create folders with these names below src/main/deploy/bundler).

The ".app"-folder is expected to not work ... sry, but the JDK does not give this feature to us ... I'm glad I found some way for the installers tho.

@yuktikapahwa
Copy link
Author

yuktikapahwa commented Oct 5, 2016

So you mean to say , if i add a tag in my plugin configuration as pkg
or
dmg inside plugin-configuration

It should work?

@FibreFoX
Copy link
Member

FibreFoX commented Oct 5, 2016

It only works with installers :/ yes, but you still won't find that files inside that ".app"-folder ...

@FibreFoX
Copy link
Member

Oh, I suspected some setup there, my fault of wrong thinking ;)

This is no magic of the javafx-maven-plugin, but from the javapackager itself. It tries to "find" some cerfificate matching via security fund-certificate -c Developer ID Application: , maybe it finds the wrong ones.

Please try to add <mac.signing-key-developer-id-app>YOUR-ID-HERE</mac.signing-key-developer-id-app> to the <bundleArguments>-block to fixate it.
If you want to play with it a bit, you may want to fill <mac.signing-key-user-name> and <mac.signing-keychain> too, for detailed information, please take a look at the Bundler-internals: https://github.com/teamfx/openjfx-8u-dev-rt/blob/83f339527558ad8a9a5180d37ecf73e1d601e42c/modules/fxpackager/src/main/java/com/oracle/tools/packager/mac/MacBaseInstallerBundler.java#L295

@yuktikapahwa
Copy link
Author

I have got some time assigned for my self to resolve this task. Will continue on this tomorrow and try what you told me to try. Will get back to you in 15 houtrs :)

@yuktikapahwa
Copy link
Author

yuktikapahwa commented Jan 19, 2017

Hi @FibreFoX ,
So , here it is . The javapackager tries to find some certificate and as I can trace it in the logs , it finds the correct certificate . When i run it in verbose mode i can see all the logs . The take the exact code sign command where it breaks signing the .appex file and instead of getting it signed from the maven plugin , I use the same command from the CLI . It works perfectly fine from there. Whereas when you build it through maven plugin , it breaks. I don't understand why it happens.

I am attaching the first three lines of the logs . May be it is of any help
Running [codesign, -s, Developer ID Application: A LTD. (YYYYYYYYYY), --prefix, com.a.application., -vvvv, /Users/A/Documents/workspace_Feb1/osxInstaller/target/jfx/native/A.app/Contents/PlugIns/A.appex] /Users/A/Documents/workspace_Feb1/osxInstaller/target/jfx/native/A.app/Contents/PlugIns/A.appex: is already signed java.io.IOException: Exec failed with code 1 command [[codesign, -s, Developer ID Application: A LTD. (YYYYYYYYYY), --prefix, com.a.application., -vvvv, /Users/A/Documents/workspace_Feb1/osxInstaller/target/jfx/native/A.app/Contents/PlugIns/A.appex] in unspecified directory java.io.IOException: Exec failed with code 1 command [[codesign, -s, Developer ID Application: A LTD. (YYYYYYYYYY), --prefix, com.a.application., -vvvv, /Users/A/Documents/workspace_Feb1/osxInstaller/target/jfx/native/A.app/Contents/PlugIns/A.appex] in unspecified directory at com.oracle.tools.packager.IOUtils.exec(IOUtils.java:165)

@yuktikapahwa
Copy link
Author

Can you see in the above logs , it says that it is already signed and then it breaks after that.The most weird part is , when it is trying to code sign the .appex file , it prints that it is already code signed whereas it is not and then it breaks after that.

@FibreFoX
Copy link
Member

Hm... so you did made that "A.app" with the bundler and (after it failing) you were running codesign with the same parameters, correct?

@yuktikapahwa
Copy link
Author

yes...from the CLI , it worked . The same codesign command to codesign the appex file works from the CLI but not from the plugin.

@FibreFoX
Copy link
Member

That's something I can work with :) and will report back when I found the problem. But one last thing: can you try to skip signing, by setting <signBundle> to false inside the <bundleArguments>-block? Does it work/bundle without failing? (This might be some last step before I found the error)

@yuktikapahwa
Copy link
Author

I am sorry , where is this <bundleArguments> tab ? Is it inside the pom.xml ? I dont have anything like that in my pom.
Could you please let me know the exact syntax and the position where i should palce it in my pom.So that I can go ahead and try it for you.

@FibreFoX
Copy link
Member

<plugin>
    <groupId>com.zenjava</groupId>
    <artifactId>javafx-maven-plugin</artifactId>
    <version>8.8.0-SNAPSHOT</version>
    <configuration>
        <mainClass>com.a.application.A</mainClass>
        <deployDir>${project.basedir}/deploy</deployDir>
        <!-- ... -->
        <!-- other stuff -->
        <!-- ... -->

        <bundleArguments>
            <signBundle>false</signBundle>
        </bundleArguments>
    </configuration>
</plugin>

@yuktikapahwa
Copy link
Author

Correct.
Now , as expected it built the A.app ,A.dmg and A.pkg inside the target/jfx/native folder and didnt fail .
But there is not _CodeSignature file present inside my app becuase we explicitly ignored the code signing . Last time it was not created because the code sign was failing but this time the code sign is not even there. It also printed the following in the logs

[INFO] Skipping 'Mac App Store Ready Bundler' because of configuration error 'Mac App Store apps must be signed, and signing has been disabled by bundler configuration.' Advice to fix: Either unset 'signBundle' or set 'signBundle' to true. [INFO] Skipping 'WebStart JNLP Bundler' because of configuration error 'No OutFile Specificed' Advice to fix: Please specify the name of the JNLP Outut file in 'jnlp.outfile'

@FibreFoX
Copy link
Member

This sounds wonderful, even when we are not finished yet! Just to confirm: after bundling the non-signed app, did you try to manually sign that app-bundle using the CLI-commands? And if so, did it work? (Just making sure I get it right, so sorry if I'm asking some questions again and again)

If so, this means I "only" have to track down the problem with signing, and it means that everything else now is working.

@yuktikapahwa
Copy link
Author

Hi @FibreFoX,
I have come up with two solutions now

  1. This problem would be solved completely if you can somehow try to ignore signing the .appex insilde the PlugIns folder . That way , the bundler will sign everything and ignore this file and perfectly build the app , dmg and pkg. Then we can get rid of this problem . I am saying thAT because there is a way with which I can sign that appex file before hand .
  2. If not , then I would like to let you know that I tried what you told me to try. Meaning ,I tried to codesign the app manually and then launch it . It was giving me issues launching that appex inside the app because it was treated as a misconfigured plugin because it was not sandboxed . i dont know if you understand the meaning of sanxboxed or not .Any application which is built on mac or to be run on MAC needs to be sandboxed for security purposes .
    The command which you were using to sign the appex bundle is as below
    codesign -s “Developer ID Application: A LTD. (YYYYYYYYY)” --prefix com.a.application. -vvvv <path to source>

Whereas in order to perfectly codesign the appex bundle the command should be as below
codesign --entitlements <Path to entitlemnts file> -s “Developer ID Application: A LTD. (YYYYYYYYY)” --prefix com.a.application. <Path to source>

@FibreFoX
Copy link
Member

The thing is, I am not responsible for these codesign-statements, thats what happens inside MacBaseInstallerBundler, which contains a method called signAppBundle, but the one with that --entitlements-part only gets called with the MacAppStoreBundler.

You are right, I dont know that mac-contept of "sandboxing", all I understood is, that it requires these application-bundles to be signed in a special way, so that gatekeeper (or whatever security-system is in place) gives that application access to the system.

Just a guess: if you do not add that plugin-file, creating that bundle without signing, does it work if you manually sign that thing afterwards?

@yuktikapahwa
Copy link
Author

What I am going to try for you is - I have removed the plugins folder from the deploy/bundlers/mac.app .Now I am letting the app build with the code signing set to true . Let us now see if the code signing succeeds and the app builds perfectly . I will not do any manual business here.

@FibreFoX
Copy link
Member

No need to get picky, I'm not using Mac nor am I planing to do on a daily basis. All this here is done in my spare-time. I understand that it might sound like I'm letting you do the hard work, but trust me, I easily could just say "then dont sign that app". The flaw/bug is inside the JDK, I'm doing magic and monkeyworking here to get this thing to work.

If you can share a way to me, how I can create a signing certificate without the need to pay that developer account fee, I am willing to take more work on my shoulders.

I never did mac-development, nor am I planing to do so ... so please don't make our frustration about this issue (which has a comment-count over 100 ... and a high life-count) increasing more.

(sorry, but I felt to release some steam about it .... I'm still willing to nail that bug down!!!)

@yuktikapahwa
Copy link
Author

Oh my god , I am taken aback now.
As i told you I removed the PlugIns folder and now tried to build the app just to see if everything except that is fine and I found out that the app which is built, when I double click it and try to launch it , it doesnt launch at all .
When I try to see the system logs just to find out why it is not launching , it prints the following in the system logs of MAC -

2017-01-19 3:42:51.782 PM A.app[14678]: Failed to find library.: 2017-01-19 3:42:51.782 PM A.app[14678]: A:Failed to locate JNI_CreateJavaVM 2017-01-19 3:42:51.782 PM A.app[14678]: A:Failed to launch JVM 2017-01-19 3:42:51.784 PM com.apple.xpc.launchd[1]: (com.a.app.48032[14678]) Service exited with abnormal code: 1

This means there is some other issue as well.

@yuktikapahwa
Copy link
Author

When I try to launch the jar present inside my application a.app from the CLI using java -jar command , it launches perfectly fine . But double clicking and running the app is not doing anything.

@FibreFoX
Copy link
Member

hm ... the log you provided looks like there is a problem with the JRE ?! I will compare some stuff inside the MacApp-bundler and the MacAppStore-bundler, I'm suspecting some clue in there. The "problem" is the requirement on mac, not the java-part so it is expected to work when you java -jar your app inside :)

@yuktikapahwa
Copy link
Author

hmm..right.
But did u understand why this happened? I am not quite able to understand why it is not launching the app on double click :(
Please share if you got any idea or if you want me to test some other thing out .

@FibreFoX
Copy link
Member

I now have created some apple account and registered to be part of the developer-programm. After downloading XCode, I started XCode, went to Settings > Accounts, added my fresh Apple ID and created some "Mac Development"-signing identity ... just to have some signing-key inside my local keystore. Then I added this to my pom.xml

<bundleArguments>
    <mac.signing-key-developer-id-app>Mac Development:</mac.signing-key-developer-id-app>
</bundleArguments>

to make sure it gets picked up for codesigning.

Everything went okay while signing, but the application crashed on execution ... I really don't know why, but calling java -jar exploded for me. Don't know why it exploded, maybe because I'm running some emulated stuff.

The thing is, signing seems to work for me, but I haven't yet added some appex-file (which I even don't know how to create). I checked that I used codesign correctly by creating a small CLI-app inside XCode.

And I'm running out of ideas currently ... do you have any?

@JustGregory-zz
Copy link

@yuktikapahwa
I don't do any Mac development myself; but I wonder if the Mac system requires some specific Java JRE or JDK settings/properties/whatever. Which Java are you using? Can you check your Java classpath? Sorry if any of this has been asked before, but I know from personal experience, it's sometimes easy to overlook the simple(st) solutions...

@yuktikapahwa
Copy link
Author

yuktikapahwa commented Jan 19, 2017

Hello
All I could do and try is one comparison

  1. While I am not using the snapshot version of the maven plugin and setting the signing properties to false , I am able to get the app and dmg built successfully and even launch it on double click . There is no dmg issue in that . Please find the configurations of the pom below
<!-- Use the javafx maven plugin to produce jar/native output -->
   <plugin>
    <groupId>com.zenjava</groupId>
    <artifactId>javafx-maven-plugin</artifactId>
    <version>8.5.0</version>
    <configuration>
     <mainClass>com.a.application.A</mainClass>
     <deployDir>${project.basedir}/deploy</deployDir>
     <needShortcut>true</needShortcut>
     <appName>${target.name}</appName>
     <jfxMainAppJarName>a-jfx.jar</jfxMainAppJarName>

     <!-- Verbose logs while building the application -->
     <verbose>true</verbose>
     <vendor>${target.publisher}</vendor>

     <!-- The 'app' output directory. This is where the base executable JavaFX 
      jar is built into, along with any dependent libraries (place in the 'lib' 
      sub-directory). The resulting JAR in this directory will be ready for distribution, 
      including Pre-Loaders, signing, etc. -->
     <jfxAppOutputDir>${project.build.directory}/jfx/app</jfxAppOutputDir>

     <!-- Files and directories in this directory will be copied to the jfxAppOutputDir. -->
     <additionalAppResources>${project.build.directory}/resources/macosx/</additionalAppResources>

     <jvmArgs>
      <argument>-Xmx512m</argument>
     </jvmArgs>

    </configuration>

    <!-- For the javafx maven plugin execute the following phases -->
    <executions>

     <!-- Package Phase : The app build a jar -->

     <execution>
      <id>create-jfxjar</id>
      <phase>package</phase>
      <goals>
       <goal>build-jar</goal>
      </goals>
     </execution>

     <!-- Package Phase : Post creating the jar create the native package -->
     <execution>
      <id>create-native</id>
      <phase>package</phase>
      <goals>
       <goal>build-native</goal>
      </goals>
     </execution>
    </executions>
   </plugin>
  1. Whereas when I use the new SNAPSHOT VERSION of the maven plugin with the deploy/bundlers/ support aqdded in it for Mac , I get the app built but that app is not launching and is printing "Failed to locate JNI_CreateJavaVM" in the system logs.
    Please find the configurations of the pom below
<pluginRepositories>
    	<pluginRepository>
        	<id>oss-sonatype-snapshots</id>
        	<url>https://oss.sonatype.org/content/groups/public/</url>
        	<snapshots>
            	<enabled>true</enabled>
        	</snapshots>
    	</pluginRepository>
</pluginRepositories>
<!-- Use the javafx maven plugin to produce jar/native output -->
   <plugin>
    <groupId>com.zenjava</groupId>
    <artifactId>javafx-maven-plugin</artifactId>
    <version>8.8.0-SNAPSHOT</version>
    <configuration>
     <mainClass>com.a.application.A</mainClass>
     <deployDir>${project.basedir}/deploy</deployDir>
     <needShortcut>true</needShortcut>
     <appName>${target.name}</appName>
     <jfxMainAppJarName>a-jfx.jar</jfxMainAppJarName>

     <!-- Verbose logs while building the application -->
     <verbose>true</verbose>
     <vendor>${target.publisher}</vendor>

     <!-- The 'app' output directory. This is where the base executable JavaFX 
      jar is built into, along with any dependent libraries (place in the 'lib' 
      sub-directory). The resulting JAR in this directory will be ready for distribution, 
      including Pre-Loaders, signing, etc. -->
     <jfxAppOutputDir>${project.build.directory}/jfx/app</jfxAppOutputDir>

     <!-- Files and directories in this directory will be copied to the jfxAppOutputDir. -->
     <additionalAppResources>${project.build.directory}/resources/macosx/</additionalAppResources>
     <additionalBundlerResources>${project.basedir}/deploy/bundlers</additionalBundlerResources>
      <bundleArguments>
            <signBundle>false</signBundle>
        </bundleArguments>
     <jvmArgs>
      <argument>-Xmx512m</argument>
     </jvmArgs>

    </configuration>

    <!-- For the javafx maven plugin execute the following phases -->
    <executions>

     <!-- Package Phase : The app build a jar -->

     <execution>
      <id>create-jfxjar</id>
      <phase>package</phase>
      <goals>
       <goal>build-jar</goal>
      </goals>
     </execution>

     <!-- Package Phase : Post creating the jar create the native package -->
     <execution>
      <id>create-native</id>
      <phase>package</phase>
      <goals>
       <goal>build-native</goal>
      </goals>
     </execution>
    </executions>
   </plugin>
   <plugin>

What I feel is , something changed between the 8.5.0. and 8.8.0- SNAPSHOT version which is causing these issues. Is there a way you can do a compare and find out what changed.

@FibreFoX
Copy link
Member

I have checked the difference, but their are not even near the JRE-creation: javafx-maven-plugin-8.5.0...master
But you can try that by using that older plugin ... which bugs me is, that it does not run on my VM with mac ... even without signing I can't get it working, but maybe my test-project is a bit flawed ... I will try to get some executable application first, then adding some files. Will report back after I found something.

@yuktikapahwa
Copy link
Author

Sure .
Not a problem .
If nothing turns out then we wont be able to release our app to the app store with java fx maven plugin . Thats alright. Will look for some other alternative after that.
Lets first get sure if something can turn out good or not :)

@FibreFoX
Copy link
Member

FibreFoX commented Jan 24, 2017

@yuktikapahwa just a quick question: I would like to CLOSE this issue, because it is now possible to place .appex-files into the app-bundle, remaining the problems with signing. But this might be a different problem, do you feel okay about me closing this issue and opening a follow-issue? (Haven't forgotten about this issue, just distracted with some other stuff currently)

@yuktikapahwa
Copy link
Author

Hi @FibreFoX , Sorry for getting back to you late.
I don't mind you closing this issue , but my only concern is that if one issue leads to another issue then there is a problem with the fix of the first issue because if the fix is correct another issue should not even be there.
So with this snapshot build of the plugin , although we get to see the internal plugins and folders at the respective positions but still the app which is built , crashes of no reason . I am not even able to launch the application .
So , I am not sure what we should do ? Whether we should close this issue and open another one or keep this opened. Whatever is your call .
Please note - If we mark this issue resolved , I still won't be able to use this version of the plugin because it crashes my app.

@FibreFoX
Copy link
Member

FibreFoX commented Feb 5, 2017

@yuktikapahwa the changes got released with 8.8.0, will investigate about the remaining problem with signing in a different issue-ticket,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants