jbarnette / johnson
watch download tarball
public
Forks21Right
Watchers302Right
Description: Johnson wraps JavaScript in a loving Ruby embrace.
Homepage: http://github.com/jbarnette/johnson/wikis
Clone URL: git://github.com/jbarnette/johnson.git

Comments for jbarnette's johnson   feed

tmm1 commented on jbarnette/johnson Fri Jan 23 10:58:29 -0800 2009
Comment in 93b8304:

Worked for me.. under what cases does it fail?

ashgti commented on jbarnette/johnson Fri Jan 23 08:34:30 -0800 2009
Comment in 93b8304:

Um… you know that doesn’t work right? At least from my testing, it isn’t very universal. I’d suggest: 

unless RUBY_VERSION =~ /1.8/

jbarnette commented on jbarnette/johnson Sat May 24 16:48:01 -0700 2008
Comment in 83553e3:

Yeah, this was horrible exploratory code. Thanks for covering for me.

jbarnette commented on jbarnette/johnson Mon Apr 21 21:34:27 -0700 2008
Comment on ext/spidermonkey/conversions.c L80 in 97b8244:

..or changing everything else to convert_jsval_whatever…

jbarnette commented on jbarnette/johnson Mon Apr 21 21:33:47 -0700 2008
Comment on ext/spidermonkey/conversions.c L80 in 97b8244:

I see what you mean, but I don’t think it’s catastrophic if all the convert_to methods don’t have identical signatures. Another option is convert_js_string_pointer_to_ruby(), of course. :)

matthewd commented on jbarnette/johnson Mon Apr 21 21:24:14 -0700 2008
Comment on ext/spidermonkey/conversions.c L80 in 97b8244:

It’s currently a sucky name, agreed. Is convert_*_to_ruby likely to be confusing, though, given that it takes a JSString*, and not a jsval?

jbarnette commented on jbarnette/johnson Mon Apr 21 21:13:40 -0700 2008
Comment on ext/spidermonkey/conversions.c L173 in 97b8244:

convert_js_string_to_ruby()

jbarnette commented on jbarnette/johnson Mon Apr 21 21:12:07 -0700 2008
Comment on ext/spidermonkey/conversions.c L144 in 97b8244:

Johnson_Error_raise()

jbarnette commented on jbarnette/johnson Mon Apr 21 21:11:53 -0700 2008
Comment on ext/spidermonkey/conversions.c L133 in 97b8244:

Johnson_Error_raise()

jbarnette commented on jbarnette/johnson Mon Apr 21 21:11:32 -0700 2008
Comment on ext/spidermonkey/conversions.c L124 in 97b8244:

Johnson_error_raise()

jbarnette commented on jbarnette/johnson Mon Apr 21 21:10:06 -0700 2008
Comment on ext/spidermonkey/conversions.c L80 in 97b8244:

Rename to convert_js_string_to_ruby

jbarnette commented on jbarnette/johnson Mon Apr 21 21:07:33 -0700 2008
Comment on ext/spidermonkey/context.c L100 in 97b8244:

Man, I dunno. It’s a tough problem. This might actually be the most readable way to do it

jbarnette commented on jbarnette/johnson Mon Apr 21 21:06:39 -0700 2008
Comment on ext/spidermonkey/context.c L131 in 97b8244:

We have Johnson_Error_raise() for this

tenderlove commented on jbarnette/johnson Mon Apr 14 22:45:04 -0700 2008
Comment in e18f74d:

Woot. You are awesome john.