jdalton (John-David Dalton)

Name
John-David Dalton
Email
Website/Blog
http://www.twitter.com/jdalton
Member Since
Apr 02, 2008 (about 1 year)

Following 25 githubbers and watching 54 repositories view all →

Public Repositories (3)

  • nwmatcher

    Fast Javascript CSS Selector Engine and Matcher (modified with different takes on performance and...

    legend

    Forked from dperini/nwmatcher Sun Nov 01 12:49:10 -0800 2009

    Last updated Tue Nov 24 10:11:48 -0800 2009

  • LABjs

    Loading And Blocking JavaScript: On-demand parallel loader for JavaScript with execution order de...

    legend

    Forked from getify/LABjs Thu Nov 12 16:24:37 -0800 2009

    Last updated Fri Nov 13 07:52:08 -0800 2009

  • jquery

    jQuery JavaScript Library

    legend

    Forked from jquery/jquery Tue Nov 03 11:54:59 -0800 2009

    Last updated Mon Nov 02 18:01:07 -0800 2009

Public Activity feed

jdalton pushed to master at jdalton/nwmatcher Tue Nov 24 10:11:48 -0800 2009
HEAD is 80eb08bad2eec6bd93fdf9cb5ec2c2d543124d68

4 commits »

jdalton pushed to master at jdalton/nwmatcher Mon Nov 23 23:01:06 -0800 2009
HEAD is cb188640b0ca5b57a857b76836d16324a98b3724

2 commits »

jdalton commented on dperini/nwmatcher Mon Nov 23 22:55:30 -0800 2009
Comment on src/nwmatcher.js L230 in d21abfa:

You mixed the order of those, it should be div.querySelectorAll('[class~=xxx]').length before div.querySelectorAll('.xXx').length as the code comment explains must test the attribute selector '[class~=xxx]' before '.xXx' or the bug may not present itself

jdalton commented on jdalton/nwmatcher Mon Nov 23 19:27:16 -0800 2009
Comment in 2b1e535:

it is defined once, so it is like a static prop name.

jdalton pushed to master at jdalton/nwmatcher Mon Nov 23 16:19:50 -0800 2009
HEAD is 25e38cbdadb959f959b49db7391b13b0d1c6bd08
  • jdalton committed 25e38cbd:
    unittests: Minor update to slick browser.html test html. [jddalton]
jdalton pushed to master at jdalton/nwmatcher Mon Nov 23 16:13:59 -0800 2009
HEAD is 2b1e535a09a879a20ce96c7f294343268637da43
  • jdalton committed 2b1e535a:
    nwmatcher: Make `UID`'s property name harder to conflict with. [Diego Perini, jddalton]
jdalton pushed to master at jdalton/nwmatcher Mon Nov 23 16:00:38 -0800 2009
HEAD is dff142e20a5710471ac212d5ad0c416f6b8cdbda

2 commits »

jdalton pushed to master at jdalton/nwmatcher Mon Nov 23 15:28:05 -0800 2009
HEAD is 458b7ea917d7a880dc87505408e7895216322044

3 commits »

jdalton commented on dperini/nwmatcher Mon Nov 23 07:52:57 -0800 2009
Comment in bb9a765:

Also INSENSITIVE_TABLE = docType && docType.systemId... the doctype sniff should be swappedfor the FT of my fork as pages may have an XHTML doctype but be with a HTML mime type.

jdalton commented on dperini/nwmatcher Mon Nov 23 07:46:44 -0800 2009
Comment in fc6ef4b:

does this work for SVG ?

jdalton commented on jdalton/nwmatcher Mon Nov 23 07:41:06 -0800 2009
Comment in 7adf35c:

Ya that commit was a bit older, I was following your lead on that one, newer commits have removed that infavor of calling e.nodeType and e.nodeName.charCodeAt(0) less

jdalton pushed to master at jdalton/nwmatcher Sun Nov 22 23:43:23 -0800 2009
HEAD is 1fd54f564475ee56908e48e9abd8c12a1d07d250
  • jdalton committed 1fd54f56:
    unittest: Change Slick directory structure and fix bug in specs-engine_bugs.js IE unit tests. [jddalton]
jdalton pushed to master at jdalton/nwmatcher Sun Nov 22 18:22:32 -0800 2009
HEAD is a233cafdb167a2bd5bffa92b8018c09595700da5
  • jdalton committed a233cafd:
    unittest: Add Dojo tests to the Slick specs. [jddalton]
jdalton pushed to master at jdalton/nwmatcher Sun Nov 22 17:56:06 -0800 2009
HEAD is 030f4342042dd9cf53d6b93e477626acfedd1984

3 commits »

jdalton pushed to master at jdalton/nwmatcher Sun Nov 22 12:19:58 -0800 2009
HEAD is dd465503e886c39d362f1abdcd85a7849fba1207

3 commits »

jdalton commented on dperini/nwmatcher Sun Nov 22 08:27:10 -0800 2009
Comment in 37d55c9:

SVG objects have a .className property that is an Animation object.

jdalton commented on dperini/nwmatcher Sun Nov 22 08:26:06 -0800 2009
Comment in 2b4d45b:

I do dig changing base to doc

jdalton commented on dperini/nwmatcher Sun Nov 22 08:09:17 -0800 2009
Comment in 2b4d45b:

:root is defined by spec http://www.w3.org/TR/css3-selectors/#structural-pseudos, is probably why that has its name.

jdalton created gist: 240333 Sat Nov 21 15:16:32 -0800 2009
// Update Prototype NWMatcher adapter Prototype._original_property = window.NW;
jdalton created gist: 240332 Sat Nov 21 15:14:51 -0800 2009
// OR Prototype._original_property = window.NW;
jdalton pushed to master at jdalton/nwmatcher Sat Nov 21 13:52:18 -0800 2009
HEAD is 6b695f5248106f9e307ef345307646d8eb03925d

2 commits »

jdalton pushed to master at jdalton/nwmatcher Sat Nov 21 00:54:42 -0800 2009
jdalton pushed to master at jdalton/nwmatcher Sat Nov 21 00:10:23 -0800 2009
HEAD is 9cfd0dcd676bc478d980528d2dabedeee53d0bdf

2 commits »

jdalton commented on dperini/nwmatcher Fri Nov 20 23:54:14 -0800 2009
Comment in 589685b:

e.form may be needed as script elements and others have a type

jdalton commented on jdalton/nwmatcher Fri Nov 20 12:52:59 -0800 2009
Comment in 694bebf:

Confirmed its an issue in how I detect and break multiple selectors. Thanks, will fix ASAP.

jdalton commented on jdalton/nwmatcher Fri Nov 20 12:49:38 -0800 2009
Comment in 694bebf:

hmm try again after my next round of updates.

jdalton pushed to master at jdalton/nwmatcher Fri Nov 20 00:14:26 -0800 2009
HEAD is 694bebf967a29db7137d78c030d4120643348282

9 commits »

jdalton commented on dperini/nwmatcher Thu Nov 19 21:49:34 -0800 2009
Comment in 065ab73:

Turns out the "|radio|checkbox|".indexOf(...) is slower/equiv in IE8 while this /^(?:radio|checkbox)$/i.test(e.type) is a bit faster than both.

jdalton commented on dperini/nwmatcher Thu Nov 19 13:07:45 -0800 2009
Comment in 065ab73:

he could replace it with an object lookup but and a .toLowerCase() but it would be harder in the compiled code and benchmarking would be needed.

jdalton commented on dperini/nwmatcher Thu Nov 19 13:04:10 -0800 2009
Comment in 065ab73:

The type attribute in both html and xhtml is case-insensitive

jdalton pushed to master at jdalton/nwmatcher Thu Nov 19 12:19:18 -0800 2009
HEAD is b90ceef542d4c21faed0030c0221212a56ec631a
  • jdalton committed b90ceef5:
    nwmatcher: Switch to `element.nodeName.charCodeAt(0)` instead of `element.nodeName.charAt(0)`. [jddalton]
jdalton pushed to master at jdalton/nwmatcher Thu Nov 19 10:59:28 -0800 2009
HEAD is aa9fac6ae3c7a8320d01bc58a1e649db6294b597
  • jdalton committed aa9fac6a:
    nwmatcher: Remove `in` operator checks on control elements and test hasFocus() method exists before using it. [Diego Perini, jddalton]
jdalton pushed to master at jdalton/nwmatcher Thu Nov 19 10:46:40 -0800 2009
HEAD is 893fa8851ff80cd358e04b6128edf0ee632195c5

3 commits »

jdalton pushed to master at jdalton/nwmatcher Thu Nov 19 01:06:16 -0800 2009
HEAD is 6d55991f0305a1b8e2cd2ba5134072f8633324b6

2 commits »

jdalton pushed to master at jdalton/nwmatcher Wed Nov 18 23:41:04 -0800 2009
HEAD is b39903803612525d2925dc318df0c83b0a1ccdad
  • jdalton committed b3990380:
    nwmatcher: Move Prototype unit test adapter into its own file. [jddalton]