@@ -54,7 +54,7 @@ module Spec :argv ) attr_reader :colour, :differ_class, :files, :example_groups - + def initialize(error_stream, output_stream) @error_stream = error_stream @output_stream = output_stream @@ -89,9 +89,6 @@ module Spec return true unless examples_should_be_run? success = true begin - before_suite_parts.each do |part| - part.call - end runner = custom_runner || ExampleGroupRunner.new(self) unless @files_loaded @@ -99,6 +96,15 @@ module Spec @files_loaded = true end + # TODO - this has to happen after the files get loaded, + # otherwise the before_suite_parts are not populated + # from the configuration. There is no spec for this + # directly, but stories/configuration/before_blocks.story + # will fail if this happens before the files are loaded. + before_suite_parts.each do |part| + part.call + end + if example_groups.empty? true else lib/spec/runner/options.rb @@ -13,8 +13,6 @@ Story: before suite Scenario: running with spec - Given this scenario fails because before(:suite) doesn't get run with the spec command - Given the file ../resources/spec/before_blocks_example.rb When I run it with the spec script stories/configuration/before_blocks.story c516321f3e90f87d0a839745060e0580aa60073d David Chelimsky dchelimsky@gmail.com http://github.com/jdelStrother/rspec/commit/74fd2a7e6893e95a6d4706b1dcf209e436cf7d1e 74fd2a7e6893e95a6d4706b1dcf209e436cf7d1e 2008-07-12T15:04:40-07:00 2008-07-12T15:04:40-07:00 Apply before_suite_parts *after* loading files! [#459 state:resolved milestone:"1.1.5"] 831d9170de2de3121f99a8c303fd48eb1beb44e9 David Chelimsky dchelimsky@gmail.com