From 8807f0af5f47397e4b2ae0065cfceb882feee942 Mon Sep 17 00:00:00 2001 From: James Nord Date: Tue, 26 Nov 2019 11:32:54 +0000 Subject: [PATCH] Add a configurable delay to avoid race condition in initializer (#1204) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * add a configurable delay to avoid race condition in initializer the initializer needs to wait until Jenkins has loaded. Until Jenkins has more milestones add a configurable delay before configuring from code * Add some documentation * Update README.md Co-Authored-By: Tim Jacomb * Apply suggestions from code review Address typos and doc fixes from review Co-Authored-By: Evaristo Gutiérrez --- README.md | 19 +++++++++++++++++++ .../plugins/casc/ConfigurationAsCode.java | 8 ++++++++ 2 files changed, 27 insertions(+) diff --git a/README.md b/README.md index 130a638519..53d2e2614f 100644 --- a/README.md +++ b/README.md @@ -159,6 +159,25 @@ Kubernetes users:\ Most plugins should be supported out-of-the-box, or maybe require some minimal changes. See this [dashboard](https://issues.jenkins.io/secure/Dashboard.jspa?selectPageId=18341) for known compatibility issues. +## Compatibility with Jenkins > 2.199 + +Jenkins 2.199 introduced [a check to prevent saving global configuration before loading the configuration has occurred](https://github.com/jenkinsci/jenkins/pull/4171). Configurations As Code needs to apply global configuration before Jenkins loads jobs (so they can load and correctly reference any global state) and as such until [JENKINS-51856](https://issues.jenkins-ci.org/browse/JENKINS-51856) is implemented there exists a race condition where by Jenkins may fail to start when used with this plugin. + +If you encounter the race condition Jenkins will fail to start with an exception message similar to the following: + +```text +SEVERE jenkins.InitReactorRunner$1#onTaskFailed: Failed ConfigurationAsCode.init +java.lang.IllegalStateException: An attempt to save the global configuration was made before it was loaded +``` + +If you encounter this you can tell the plugin to delay configuration for an amount of time to give Jenkins time to load the global configuration before the configuration is applied by the plugin. + +To enable this set the `io.jenkins.plugins.casc.ConfigurationAsCode.initialDelay` system property to a number of milliseconds to delay the initialisation by. +The required value will be dependant on aspects of your system (cpu/disk) and configuration, and how it can be found is mostly a trial and error. +A suggestion would be to start with 5000 (5 Seconds) and then increment by 2000 (2 seconds) until you no longer exhibit the issue and finally add 1000 (1 second) for some extra safety. +For example, to delay the configuration by 9 seconds you would use something like the following command `java -Dio.jenkins.plugins.casc.ConfigurationAsCode.initialDelay=9000 -jar jenkins.war`. +Exactly how and where you specify this option depends on the installation method used to install Jenkins. + ## Configuration-as-Code extension plugins diff --git a/plugin/src/main/java/io/jenkins/plugins/casc/ConfigurationAsCode.java b/plugin/src/main/java/io/jenkins/plugins/casc/ConfigurationAsCode.java index 5ef8d94479..f159e5a83f 100644 --- a/plugin/src/main/java/io/jenkins/plugins/casc/ConfigurationAsCode.java +++ b/plugin/src/main/java/io/jenkins/plugins/casc/ConfigurationAsCode.java @@ -272,6 +272,14 @@ private List getConfigFromSources(List newSources) throws Co @Restricted(NoExternalUse.class) @Initializer(after = InitMilestone.EXTENSIONS_AUGMENTED, before = InitMilestone.JOB_LOADED) public static void init() throws Exception { + Long duration = Long.getLong(ConfigurationAsCode.class.getName() + ".initialDelay"); + if (duration != null) { + try { + Thread.sleep(duration); + } catch (InterruptedException e) { + LOGGER.log(Level.WARNING, "Interrupted whilst delaying CasC startup", e); + } + } detectVaultPluginMissing(); get().configure(); }