1a8a1192e05570e7437896532dcfcca8f907fba4 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/1f4aeb925ccb2661b1516bcfa70fee5200deb97b 1f4aeb925ccb2661b1516bcfa70fee5200deb97b

2009-03-02T10:33:00-08:00

Bump version to 2.11.0, add 2.11.0 release notes 2f71b401698c840cb02545d03c2334f0d20d45cf Jeremy Evans code@jeremyevans.net 27082cf2a1e86cb1e511ad7e0e4b58ec3624b4b6 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/1a8a1192e05570e7437896532dcfcca8f907fba4 1a8a1192e05570e7437896532dcfcca8f907fba4

2009-02-26T11:25:37-08:00

Update CHANGELOG for merged perf branch 47936f2ccd645eb6d586ffbb14dc025c12d6544d Jeremy Evans code@jeremyevans.net da4e4f9a0b211ad3fe63b7554d45c2ddeb16693d e7ad7656c668bcf0ad78fbeed82329aedd1ac053 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/27082cf2a1e86cb1e511ad7e0e4b58ec3624b4b6 27082cf2a1e86cb1e511ad7e0e4b58ec3624b4b6

2009-02-26T10:53:13-08:00

Merge branch 'perf' Conflicts: lib/sequel_core/adapters/shared/mysql.rb 0be7387c956a250a6ab2cb14002b24362dd192d2 Jeremy Evans code@jeremyevans.net 5fdeb88bac3a6b544f9073e686e171fc15bacd3d Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/da4e4f9a0b211ad3fe63b7554d45c2ddeb16693d da4e4f9a0b211ad3fe63b7554d45c2ddeb16693d

2009-02-26T10:52:07-08:00

Remove SQL::IrregularFunction, no longer used internally The only user of this class left was from ComplexExpressionMethods#extract, which was changed to use a regular Function plus a PlaceholderLiteralString. SQL::IrregularFunction was always a bad hack, and the function plus placeholder string method is much neater and better all around. This also fixes another String#lit call in the shared SQLite adapter. c9651db17d19951572183cf1ef81f98b323d29fa Jeremy Evans code@jeremyevans.net 54fc41894ed6c5a910e29928906a13fb40b2084c Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/5fdeb88bac3a6b544f9073e686e171fc15bacd3d 5fdeb88bac3a6b544f9073e686e171fc15bacd3d

2009-02-26T10:26:34-08:00

Allow String.lit to take arguments and return a SQL::PlaceholderLiteralString This useful when you want an SQL fragment to be literalized, but also want it to contain other values. Before, this was hard to do without calling Dataset#literal. Now, it's much easier to deal with: column = :user pattern = params[:pattern] dataset.select{|o| o.substring('? from ?'.lit(column, pattern))} This commit also changes the internals so that String#lit is never called, so Sequel itself won't break if another library defines it. 57f677aeaa26a40c4c5b5deb5c22245536f290ae Jeremy Evans code@jeremyevans.net 6f72682a264b01c794e0ae18bae1ebc48d7f8065 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/54fc41894ed6c5a910e29928906a13fb40b2084c 54fc41894ed6c5a910e29928906a13fb40b2084c

2009-02-25T12:19:46-08:00

Make Dataset#order and Dataset#order_more yield a VirtualRow to a block This is mostly useful if you want to call an SQL function in an order clause on Ruby 1.9. d08042a58dd39f34ff0299be7d52be56f1561bd6 Jeremy Evans code@jeremyevans.net be8e2a6ac1bd6d1bcc33c592b4505d1f552abb42 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/6f72682a264b01c794e0ae18bae1ebc48d7f8065 6f72682a264b01c794e0ae18bae1ebc48d7f8065

2009-02-25T11:38:06-08:00

Fix RDoc for Dataset#first_source 65a715fa458ce1560dfb2de4a9f855af09a4afc2 Jeremy Evans code@jeremyevans.net 455d5a60fcfabd8c00cedd41966d02a80208b36b Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/be8e2a6ac1bd6d1bcc33c592b4505d1f552abb42 be8e2a6ac1bd6d1bcc33c592b4505d1f552abb42

2009-02-25T09:15:12-08:00

Add Model#set_associated_object, used by the many_to_one setter method, for easier overriding This is for consistency with the one_to_many and many_to_many association methods (e.g. add_associated_object). It allows you to override behavior for all many_to_one setters by overriding a single method. 5d37b434675879154b27b4eec97e0dd940be231a Jeremy Evans code@jeremyevans.net 5f5f5f816893d6a296a91716a3bdf28e3cff47bb Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/e7ad7656c668bcf0ad78fbeed82329aedd1ac053 e7ad7656c668bcf0ad78fbeed82329aedd1ac053

2009-02-24T19:14:31-08:00

Remove Database#find_by_table_column_value, add Dataset#with_sql, for optimization in Model.[] I shouldn't have added a database method for this, so back it out. The dataset method makes more sense, and I've been wanting to add it for a while. Dataset#static_sql was already taken, so I chose Dataset#with_sql. Add the usual dataset mutation method and model dataset methods, and switch Model.[] to use with_sql. This new code allows the optimized version to work with models with serialized columns, plus models that use datasets with nonstandard row_procs. While here, fix Model.set_dataset so that it removes the simple_table if a dataset is given. aa4fa962d117bc13cc21d6f271fca47e670892ac Jeremy Evans code@jeremyevans.net 02f5b9b7b1fb591afb4728355d5d9c2b33939340 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/455d5a60fcfabd8c00cedd41966d02a80208b36b 455d5a60fcfabd8c00cedd41966d02a80208b36b

2009-02-24T15:46:39-08:00

2009-02-24T15:21:36-08:00

Allow use of database independent types when casting Previously, types were used as-is when casting. Now, casting uses the same type casting code as the schema methods, so you can specify ruby classes and have them changed to database specific types. This changes the object used for casts from SQL::IrregularFunction SQL::Cast. SQL::IrregularFunction is now just used for handling the SQL EXTRACT function (though it may be used for other similar functions in the future). This adds an integration test for the feature (in addition to the usual specs). It fails on SQLite because of the way SQLite handles casting (returning strings even when you are casting to integer). 8e9419d2de0ebe4dc22a73872049694040d6a196 Jeremy Evans code@jeremyevans.net 0a5ad72790e3f2759508d75b352786a7f58aaef0 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/02f5b9b7b1fb591afb4728355d5d9c2b33939340 02f5b9b7b1fb591afb4728355d5d9c2b33939340

2009-02-24T14:13:19-08:00

Give association datasets knowledge of the model object that created them and the related association reflection This should make association extensions much more powerful. Before, the :extend association option was near worthless, since association datasets were treated just like any other dataset, and didn't have the context needed to make decisions based on the values of the object that created the association. Now, you can use association extensions such as: module FindOrCreate def find_or_create(vals) first(vals) || association_reflection.associated_class. \ create(vals.merge(association_reflection[:key]=>model_object.id)) end end The above should be a generic find_or_create association dataset method that works for any standard one_to_many association: Artist.one_to_many :albums, :extend=>FindOrCreate Artist.first.albums_dataset.find_or_create(:name=>'Foo') You could previously do something similar using an association block that added methods to the dataset by using a closure, but that would have to be modified per association, doing so generically was not possible. 1b36732986b15bec7911390f4653da3f236fc851 Jeremy Evans code@jeremyevans.net c39e8e014f9eb4bf0c118f1255c08cebb1953139 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/0a5ad72790e3f2759508d75b352786a7f58aaef0 0a5ad72790e3f2759508d75b352786a7f58aaef0

2009-02-24T08:03:00-08:00

Fix RDoc for validates_length_of, the option is :within, not :with e12366b99b79609af2a6e957ae50613a44d338b8 Jeremy Evans code@jeremyevans.net 4f1330884e5fdbaebf025d44a603d41c7df37732 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/c39e8e014f9eb4bf0c118f1255c08cebb1953139 c39e8e014f9eb4bf0c118f1255c08cebb1953139

2009-02-24T07:57:05-08:00

Add links to specific RDoc pages and the release notes to the website documentation page 987743a425e4ab36bfe950c5b9ec79c3810849d6 Jeremy Evans code@jeremyevans.net bdac112f63e965ba951f18482615c0b1456c0523 John W Higgins wishdev@gmail.com http://github.com/jeremyevans/sequel/commit/4f1330884e5fdbaebf025d44a603d41c7df37732 4f1330884e5fdbaebf025d44a603d41c7df37732

2009-02-23T23:11:42-08:00

Update firebird spec to match upstream changes 4c64c9dd2b9c8860156b0400d01cc4fa1fefb756 John W Higgins wishdev@gmail.com c4ab71ea18190c45900819d70e35aad6153eb8a0 John W Higgins wishdev@gmail.com http://github.com/jeremyevans/sequel/commit/bdac112f63e965ba951f18482615c0b1456c0523 bdac112f63e965ba951f18482615c0b1456c0523

2009-02-23T22:59:21-08:00

2009-02-23T22:58:04-08:00

Added spec for getting primary key 268542cf98d2d3f4e3068dc0c48ee07cc51515fc John W Higgins wishdev@gmail.com df2093900fcf3848dd42c9d28ee11a699940f350 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/5f5f5f816893d6a296a91716a3bdf28e3cff47bb 5f5f5f816893d6a296a91716a3bdf28e3cff47bb

2009-02-23T14:11:39-08:00

Fix typo in integration tests 4ee045b95a461518f3403f0eaaabe50613b739d9 Jeremy Evans code@jeremyevans.net 5578d9e3fe13d1399b6a5d054b57ff6a590c5a88 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/df2093900fcf3848dd42c9d28ee11a699940f350 df2093900fcf3848dd42c9d28ee11a699940f350

2009-02-23T14:08:45-08:00

Fix MySQL adapter after optimization commits 3a2b831ebf874bbbc506efb59d227c1024d599d2 Jeremy Evans code@jeremyevans.net 23fee122fe24adbf3d736d963549745a621d91c7 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/5578d9e3fe13d1399b6a5d054b57ff6a590c5a88 5578d9e3fe13d1399b6a5d054b57ff6a590c5a88

2009-02-21T20:05:15-08:00

Add an optimization to Model.[] for simple models, with a 30-40% performance increase After some profiling I discovered that Model.[] can spend almost half of it's time in producing the SQL to send to the database. This is because it goes through the entire SQL creation process, which is very flexible, but not optimized for performance. If it's possible to use static SQL instead of going through the usual SQL generation process, there would be a dramatic performance increase. This adds a Database#find_by_table_column_value method that uses a given literal table and column, and a value argument, and returns the first matching row (with all columns) for that table. The value argument is literalized, but the table and column are used as is, so you cannot use untrusted input for those arguments. If a model is a optimizable (single primary key, single table), find_by_table_column_value is used instead of the usual lookup using primary_key_hash. Unfortunately, it wasn't easy to determine which models are optimizable. Checking all of the dataset options for the model dataset is too likely to break in future versions, even if I did get it correct in this version. I took the conservative approach and made it so that the model is optimizable if a symbol is passed to set_dataset. So the following models will use the optimization: class Foo < Sequel::Model # Using the implicit table is optimized end class Foo < Sequel::Model(:foos) # Since you provide a Symbol to Model(), it is optimized end class Foo < Sequel::Model set_dataset :foos # Symbol provided to set_dataset is optimized end But the following otherwise equivalent models are not optimized: class Foo < Sequel::Model(Model.db[:foos]) end class Foo < Sequel::Model set_dataset db[:foos] end To make this as fast as possible, two class instance variables are added to model: @simple_pk and @simple_table. They store the already literalized table and primary key column names, which are passed to find_by_table_column_value. This commit also adds some specs for the previous optimization commit, to bring code coverage back to 100%. cf816d75bc4a120e56f6613c9a986b691de8783c Jeremy Evans code@jeremyevans.net c4ab71ea18190c45900819d70e35aad6153eb8a0 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/23fee122fe24adbf3d736d963549745a621d91c7 23fee122fe24adbf3d736d963549745a621d91c7

2009-02-21T17:18:51-08:00

Make Dataset#literal call methods like #literal_string, override less in adapters, for a 20-25% performance increase Profiling shows Dataset#literal can take around 10% total time, so this is probably only a 2% performance increase in general. Basically, this changes how the adapters override the default literalization. Instead of overriding literal and using a case statement and super in the else clause, they override literal_* methods, so the default Dataset#literal is always called. In addition to being faster the code is noticeably cleaner as well. During this change I finally decided to change the Sequel default date and timestamp formats from the SQL standard (e.g. "TIMESTAMP 'YYYY-MM-DD HH:MM:SS'") to the defacto ISO8601 standard used by most of the adatpers. I'm pretty sure this won't break existing code, but testing on most adapters would be nice, especially on the Firebird and ODBC adapters. This commit also moves the unsupported.rb and stored_procedures.rb from lib/sequel_core/dataset to lib/sequel_core/adapters/utils, since they are only used by certain adapters. One of the results of this is that Sequel::Dataset::UnsupportedExceptIntersect(All)? is not guaranteed to be defined. From my profiling, it appears that another 10% increase to Dataset#literal could be achieved by adding a #to_sequel_literal method to all objects, and calling that instead of using a case statement. At this point, that's not a road I want to go down. 05880738835a6e7c64291858989618072ea492b3 Jeremy Evans code@jeremyevans.net 01a68873f313bb030bbc38f92f25095d885a0226 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/c4ab71ea18190c45900819d70e35aad6153eb8a0 c4ab71ea18190c45900819d70e35aad6153eb8a0

2009-02-20T15:35:52-08:00

Another minor README fix e1fe060ecc609d8f227b19b2f86c16e07244d917 Jeremy Evans code@jeremyevans.net 5df2e4046e5ed55187db18d7874c20de4012aa69 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/01a68873f313bb030bbc38f92f25095d885a0226 01a68873f313bb030bbc38f92f25095d885a0226

2009-02-19T20:27:38-08:00

Fix typo in README, thanks mwlang 5537688c9dac8782311b6f0e8828a1113cc7d767 Jeremy Evans code@jeremyevans.net f5d799ed50cebddb7647b9e3746deee69053de57 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/5df2e4046e5ed55187db18d7874c20de4012aa69 5df2e4046e5ed55187db18d7874c20de4012aa69

2009-02-19T15:37:06-08:00

Bring code coverage back to 100% b7d938bf2c75be3992740ea1f11b547399849a8f Jeremy Evans code@jeremyevans.net 4749f020d2acb4c8f91320f06f0569abf218db4b Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/f5d799ed50cebddb7647b9e3746deee69053de57 f5d799ed50cebddb7647b9e3746deee69053de57

2009-02-19T15:36:24-08:00

Make PostgreSQL and Firebird adapters send inserts to the master server instead of the slave server by default The PostgreSQL (if it is connecting to a 8.2 or greater database) and Firebird adapters use INSERT RETURNING to return data directly from the INSERT query. Because of that, the INSERT query is treated as a SELECT by Sequel. Since it is treated as a select, the request went to the slave servers instead of the master. Fix this by setting the server to use to the master (:default) server unless it is already set to use a different server. To easily implement this, add Dataset#default_server_opts private method. This comment also removes pointless execute_insert definitions some adapters, since they just duplicated the now default definition. b8661c100fc50c9ca30b3e371de6af492f594636 Jeremy Evans code@jeremyevans.net eaeb7ea243a08b3309f1d12bc13a2e9b84dc7415 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/4749f020d2acb4c8f91320f06f0569abf218db4b 4749f020d2acb4c8f91320f06f0569abf218db4b

2009-02-19T10:39:19-08:00

Add release notes to repository, include in RDoc 370e7289450dee666bd4f11a3bf3579fcc59b1c4 Jeremy Evans code@jeremyevans.net 5b60d0aeabd2d87451aefce8a3ce0a1e7e42e70e Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/eaeb7ea243a08b3309f1d12bc13a2e9b84dc7415 eaeb7ea243a08b3309f1d12bc13a2e9b84dc7415

2009-02-19T10:01:37-08:00

Avoid the internal use of Symbol#*, refactor Database#locks in the PostgreSQL shared adapter c875d601628de3a5df76541dfe442fd310128f70 Jeremy Evans code@jeremyevans.net e87ef59431372ccf5bed0e0c22dc1c940f86aa67 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/5b60d0aeabd2d87451aefce8a3ce0a1e7e42e70e 5b60d0aeabd2d87451aefce8a3ce0a1e7e42e70e

2009-02-19T09:48:55-08:00

Use before_update instead of before_save when caching and remove cache_delete_unless_new This breaks backward compatibility slightly, but it's unlikely anyone else was using cache_delete_unless_new. 7503de594f4b0fe4ba31047c678b05c98b365f96 Jeremy Evans code@jeremyevans.net 0dcdf7395827558baaed987fb3f6498ca0bf054b Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/e87ef59431372ccf5bed0e0c22dc1c940f86aa67 e87ef59431372ccf5bed0e0c22dc1c940f86aa67

2009-02-19T09:46:29-08:00

Make Dataset#select, #select_more, and #get take a block that yields a SQL::VirtualRow, similar to #filter This is useful for select just like it is useful for filter, in that it allows a nicer API in the case where you can't use the Symbol shortcuts for methods (either because you are running on Ruby 1.9 or because another library defines them). So instead of: dataset.select(:prettify.sql_function(:name)) you can do: dataset.select{|o| o.prettify(:name)} This commit also changes some of the dataset convenience methods to use this new feature. 5cef735f211504ad5bab9c63c273e2c7ebe9ffc3 Jeremy Evans code@jeremyevans.net 7300d2027133f125fc80fb349c85be234f84edf9 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/0dcdf7395827558baaed987fb3f6498ca0bf054b 0dcdf7395827558baaed987fb3f6498ca0bf054b

2009-02-17T13:15:35-08:00

Update CHANGELOG and fix minor style issue for MySQL stored procedure fix 06bd2529a9a183c93fda7b31d52ac35a171b50d5 Jeremy Evans code@jeremyevans.net c2560b5cb068cbf85ead26f3aaf3cc2c04d25e7d Clive Crous clive@crous.co.za http://github.com/jeremyevans/sequel/commit/7300d2027133f125fc80fb349c85be234f84edf9 7300d2027133f125fc80fb349c85be234f84edf9

2009-02-16T05:50:14-08:00

Correct mysql argument formatting for stored procedures 97606101438ec00f3c84906d063d1add86471e5f Clive Crous clive@crous.co.za aaccfeb2d9179c5a7c0c20de10e9665e76e745ee Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/c2560b5cb068cbf85ead26f3aaf3cc2c04d25e7d c2560b5cb068cbf85ead26f3aaf3cc2c04d25e7d

2009-02-11T13:52:56-08:00

Add :conditions association option, for easier filtering of associated objects This commit like the previous one doesn't allow anything that wasn't possible before, but should make the API nicer. Before, if you wanted to filter associated records and cover all cases, you had to specify a block and the :graph_conditions option. Now, assuming that your condition is expressible as a hash or array of two pairs, you can just change :graph_conditions to :conditions and eliminate the block. You can change this: one_to_many :japanese_verses, :class=>:Verse, :graph_conditions=>{:languageid=>3} do |ds| ds.filter(:languageid=>3) end to: one_to_many :japanese_verses, :class=>:Verse,\ :conditions=>{:languageid=>3} 5957100262a447bc7bfdaa98299f49b45633904a Jeremy Evans code@jeremyevans.net