febdedf3906ac74245cc50d0f87f0f6d57ab13ea Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/2afd7d856ff2ed63fa74ba595dec0fe1f67027b4 2afd7d856ff2ed63fa74ba595dec0fe1f67027b4

2008-12-05T16:52:07-08:00

Bump version to 2.8.0 d0a448dc2f292b5b927daf5d889254e59efd800b Jeremy Evans code@jeremyevans.net 722ce5b18aee64de2a7e0f09480702b414ff8e27 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/febdedf3906ac74245cc50d0f87f0f6d57ab13ea febdedf3906ac74245cc50d0f87f0f6d57ab13ea

2008-12-04T10:30:18-08:00

Back to 100% code coverage 66531f68313f47288cc9621cc28a43ee428b5a35 Jeremy Evans code@jeremyevans.net 9c52f6218e88533756c4aea2da1b057e0dfba70d Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/722ce5b18aee64de2a7e0f09480702b414ff8e27 722ce5b18aee64de2a7e0f09480702b414ff8e27

2008-12-04T10:23:18-08:00

Fix the SingleThreadedPool's handling of disconnected connections This shows that while 100% code coverage may not fix all bugs, it certainly helps find some. 53b994d613b71df927764a405780a3808859b615 Jeremy Evans code@jeremyevans.net 2e8753b66849c8519771814c19e25514d91233d3 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/9c52f6218e88533756c4aea2da1b057e0dfba70d 9c52f6218e88533756c4aea2da1b057e0dfba70d

2008-12-04T09:50:37-08:00

Fix Database#upcase_identifiers? if Sequel.upcase_identifiers = true Note to self that using ||= with a boolean variable is a recipe for problems. 4f6e0c70e10efaca6de77d3f4740c7534d720130 Jeremy Evans code@jeremyevans.net 35bd9acd9087c6b7791e576e20836e941710405b Jacob Dunphy jacob.dunphy@gmail.com http://github.com/jeremyevans/sequel/commit/2e8753b66849c8519771814c19e25514d91233d3 2e8753b66849c8519771814c19e25514d91233d3

2008-12-03T16:05:20-08:00

2008-12-03T15:46:27-08:00

Oracle adapter change to catch connection errors and reraise a Sequel::DatabaseDisconnectError. ac2479dc31a94346a2dac159f22918aad61408d1 Jeremy Evans code@jeremyevans.net 2d4084ebee3293fe799ed125cb5f46fa4ddf94d4 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/35bd9acd9087c6b7791e576e20836e941710405b 35bd9acd9087c6b7791e576e20836e941710405b

2008-12-03T14:15:44-08:00

Have prepared statements work correctly with datasets with static sql and placeholders 0e09a4db3fc04fe136ae8347201cfac2d8fd04d3 Jeremy Evans code@jeremyevans.net 92394164d5fa473d9753cdc60f4ca52bc5288e63 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/2d4084ebee3293fe799ed125cb5f46fa4ddf94d4 2d4084ebee3293fe799ed125cb5f46fa4ddf94d4

2008-12-03T13:30:50-08:00

Support drop column operations inside a transaction on sqlite f4a3f2defd6193a37671f9702536a535a2c3faf6 Jeremy Evans code@jeremyevans.net 7c0583f2a5d7b11adceb8eb129e1301404141ee8 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/92394164d5fa473d9753cdc60f4ca52bc5288e63 92394164d5fa473d9753cdc60f4ca52bc5288e63

2008-12-03T13:19:53-08:00

2008-12-03T11:51:13-08:00

Support literal strings with placeholders and subselects in prepared statements Before, the following two types of prepared statements did not work: DB[:items].filter("id = ?", :$i).call(:select, :i=>1) DB[:items].filter(:id=>DB[:items].select(:id).filter(:id=>:$i)).call(:select, :i=>1) The first issue is because a placeholder string was literalized immediately, before the dataset was extended with the prepared statement code. The second issue is because the arguments given in the main prepared statements weren't passed into any subselects. This commit fixes both of those issues. It also makes the name argument to Dataset#prepare optional. Fixing the first issue is done by adding an SQL::PlaceholderLiteralString class that holds the string with placeholders as well as the arguments, and not literalizing them until the SQL string is needed. Fixing the second issue was a lot more work, It is done by adding a Dataset#subselect_sql private method that literal calls, and overriding it in the PreparedStatement module that extends the dataset, which takes the subselect dataset, turns it into a prepared statement, and does the magic necessary pass the args in (if the default emulated support is used). It required changes to the argument mappers so they didn't rely on instance variables. Instead of using a hash, they now use an array that is shared with any subselects. The mapping code is simpler and the code in general is more generic. This does away with prepared_args_hash, as it is no longer necessary. 92399d009c9a2b830d33234e85c853c0a87dff46 Jeremy Evans code@jeremyevans.net f29cfffde1efc5a9a1bace7e6f274dce10d52fa7 Jack Dempsey jack.dempsey@gmail.com http://github.com/jeremyevans/sequel/commit/7c0583f2a5d7b11adceb8eb129e1301404141ee8 7c0583f2a5d7b11adceb8eb129e1301404141ee8

2008-12-02T14:42:16-08:00

2008-12-02T14:39:04-08:00

add in demonstration of primary_key method 3ac930e6ac9f0401db651966255833149b0d8c6b Jeremy Evans code@jeremyevans.net 2a58c45193ced0c2cf0f6a8da322db0a6b3ae98d Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/f29cfffde1efc5a9a1bace7e6f274dce10d52fa7 f29cfffde1efc5a9a1bace7e6f274dce10d52fa7

2008-12-02T14:06:53-08:00

Fix using postgres adapter with postgres-pr after last commit 1fed126081420c61ed879552e5acce579565ea94 Jeremy Evans code@jeremyevans.net c075608be547ae60d0e70a3f76768ac9d7984164 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/2a58c45193ced0c2cf0f6a8da322db0a6b3ae98d 2a58c45193ced0c2cf0f6a8da322db0a6b3ae98d

2008-12-02T13:52:26-08:00

2008-12-02T13:51:20-08:00

Have the connection pool remove disconnected connections when the adapter supports it This adds a Sequel::DatabaseDisconnectError (subclass of Sequel::DatabaseError), for signaling to the connection pool that the connection was lost. It changes the connection pool code to rescue that exception and remove the offending connection from the connection pool. In order to implement this, a disconnection_proc had to be added to the connection pool. Sequel uses a generic one that calls Database#disconnect_connection. disconnection_proc is called both when connections are removed because the connection was lost and when Database#disconnect is called. Database#disconnect now calls @pool.disconnect, which now uses the disconnection_proc if no block is provided. All adapters have been modified to remove Database#disconnect and define Database#disconnect_connection, which was fairly easy since all defined #disconnect methods just called @pool.disconnect with a block that disconnected each connection. The only adapter that currently supports this is PostgreSQL. The PostgreSQL adapter used to silently attempt to reconnect, which might have caused the same SQL to be used twice. I'm not sure it could have happened, but I'm not sure it couldn't have happened either. Now, if the database connection is lost, it raises DatabaseDisconnectError, the connection pool removes the connection from the pool, and raises the error to the application. If the application wants to continue, it can always retry. While mucking in the connection pool, I found a bug where the wrong key could be used when new connections were created. This wasn't a huge issue in most cases, but it could have caused as many as twice the number of max_connections connections to be created. 7704a1ae635ec8c13411792b0d0d453ca9b0f855 Jeremy Evans code@jeremyevans.net ca1161686df3c4fbd3c802b03cf592cd73e98a6f Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/c075608be547ae60d0e70a3f76768ac9d7984164 c075608be547ae60d0e70a3f76768ac9d7984164

2008-12-02T11:03:16-08:00

Make Dataset#exists return a LiteralString b5585a9e1c24ab775bbef9e693f4a89c3981881a Jeremy Evans code@jeremyevans.net fc6e8e116312d40c00461dfea78dda945160ddd9 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/ca1161686df3c4fbd3c802b03cf592cd73e98a6f ca1161686df3c4fbd3c802b03cf592cd73e98a6f

2008-12-02T10:17:46-08:00

Add stored procedure support for the MySQL and JDBC adapters (Fixes #252) This commit adds support for database stored procedures, with an API similar to Sequel's prepared statement support, and implemented internally in a similar way. While it is directly callable on the Database object (via #call_sproc), that use is discouraged. Instead it should be used at the dataset level with the following API: DB[:table].call_sproc(:select, :mysp, 'first param', 'second param') # or sp = DB[:table].prepare_sproc(:select, :mysp) sp.call('first param', 'second param') sp.call('third param', 'fourth param') The only adapters with support for this are MySQL and JDBC (if using a database that supports it). Other databases don't even expose this API. Adding support to other databases should be fairly easy, though I have no plans to at present. The stored procedure implementation is similar to the prepared statement implementation at the Dataset level. #call_sproc and and returning a clone of the dataset,and overriding Dataset#execute and related functions to add options that are used by Database#execute to send the request to the Dataset#call_sproc method. While working on stored procedure support, it became necessary to fix the MySQL adapter to make it handle multiple results, since MySQL stored procedures require that. This also fixed issues with using multiple statements at once in the MySQL adapter. Before, this would cause a "commands out of sync" error message that wasn't easily recoverable from. The MySQL adapter now supports this, though the JDBC adapter connecting to MySQL still barfs when you attempt this. Additionally, fix the socket tests in the MySQL adapter to use the same user, password, and database. 1ae3c9f077e01181961866530ea3124300806f03 Jeremy Evans code@jeremyevans.net 4bbbedc717adf020e0e025bd0e0e967015cbcfef Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/fc6e8e116312d40c00461dfea78dda945160ddd9 fc6e8e116312d40c00461dfea78dda945160ddd9

2008-12-01T14:03:55-08:00

Support options when altering a column's type 6e2aa081ced675140d0d2a8e6ba32d00e307729a Jeremy Evans code@jeremyevans.net 24d790142526446e46a369d5d9107b393be6bc66 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/4bbbedc717adf020e0e025bd0e0e967015cbcfef 4bbbedc717adf020e0e025bd0e0e967015cbcfef

2008-12-01T12:18:55-08:00

Support AliasedExpressions in tables when using implicitly qualified arguments in joins This allows you to do: DB.from(:i.as(:j)).join(:k.as(:l), :a=>:b) #=> ... FROM i AS j INNER JOIN k AS l ON (l.a = j.b) 127ca1b108255b6a2eab462a29608279c337510a Jeremy Evans code@jeremyevans.net bde004dceff6f74f903300138e0a77f1258e9cbf Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/24d790142526446e46a369d5d9107b393be6bc66 24d790142526446e46a369d5d9107b393be6bc66

2008-12-01T12:06:45-08:00

Fix MySQL adapter after UnsupportedIntersectExcept addition 26968e4d04425f369da2c5e891ec647f390e93b2 Jeremy Evans code@jeremyevans.net 3a1a628eabb987998482670101c4cbce27cd54ec Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/bde004dceff6f74f903300138e0a77f1258e9cbf bde004dceff6f74f903300138e0a77f1258e9cbf

2008-12-01T11:59:43-08:00

Support Dataset#except on Oracle This commit changes the Oracle adapter to use MINUS instead of EXCEPT, since that's the syntax that Oracle supports. 0cb8ee9afab5bd8b1213b04e0cde501da2d95ab8 Jeremy Evans code@jeremyevans.net c790367020280e1495e31c5a53fe380f48980b19 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/3a1a628eabb987998482670101c4cbce27cd54ec 3a1a628eabb987998482670101c4cbce27cd54ec

2008-12-01T11:58:54-08:00

Raise Errors if EXCEPT/INTERSECT is used when not supported This adds a couple of modules to Sequel::Dataset that can be included in adapters that don't support EXCEPT/INTERSECT. UnsupportedIntersectExcept raises an error if EXCEPT/INTERSECT is used, and UnsupportedIntersectExceptAll raises an error if EXCEPT ALL/INTERSECT ALL is used (but EXCEPT/INTERSECT is allowed). The Informix, MySQL, MSSQL, and Progress adapters use UnsupportedIntersectExcept and the Oracle and SQLite adapters use UnsupportedIntersectExceptAll. Similar code was already in the MSSQL and Progress adapters, this commit removes that code. Also, it removes some commented out code from the Informix adapter. 21cd0dd4f36602b15399ec6bbaee7a0abc472838 Jeremy Evans code@jeremyevans.net cde6c93d3dd1c29b7fb1229b513c0e060d5f334f Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/c790367020280e1495e31c5a53fe380f48980b19 c790367020280e1495e31c5a53fe380f48980b19

2008-12-01T11:56:39-08:00

Fix ordering of UNION, INTERSECT, and EXCEPT statements (Fixes #253) Before, the UNION, INTERESECT, and EXCEPT statements came after ORDER BY by default, this commit moves them before ORDER BY. Some of the adapters were changed, but not all. If you use UNION, INTERSECT, or EXCEPT, please test with your database to make sure it still works. 82252d7fa74d6ec95269c925995e995246da83d1 Jeremy Evans code@jeremyevans.net 0c7c893c5093337008f59de6885bd682cf8d327b Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/cde6c93d3dd1c29b7fb1229b513c0e060d5f334f cde6c93d3dd1c29b7fb1229b513c0e060d5f334f

2008-11-25T16:34:17-08:00

Fix the oracle adapter spec 121b0aff2ec0dadd7862dba1ea0f169f5cb9679a Jeremy Evans code@jeremyevans.net 8b395139f67ddcf7f24443cb6c1d7460e409f639 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/0c7c893c5093337008f59de6885bd682cf8d327b 0c7c893c5093337008f59de6885bd682cf8d327b

2008-11-25T09:53:56-08:00

Support aliasing subselects in the Oracle adapter 018f826540d50c39f837d4dfccab98988481e9ba Jeremy Evans code@jeremyevans.net 70aa14e303693ce54b0c110c5dcee6ccfec9947b Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/8b395139f67ddcf7f24443cb6c1d7460e409f639 8b395139f67ddcf7f24443cb6c1d7460e409f639

2008-11-20T15:24:52-08:00

Make Dataset#join_table work with symbols with implicit schemas Before, in order to handle implicit aliases, it would split the symbol (and throw away the schema part). 2ffb9776690abd77f5425d43e929c23c30af8d50 Jeremy Evans code@jeremyevans.net 4a23245d3126e5830c8c1c1ecacc4150ad42d011 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/70aa14e303693ce54b0c110c5dcee6ccfec9947b 70aa14e303693ce54b0c110c5dcee6ccfec9947b

2008-11-20T14:09:29-08:00

Add a subadapter for the Progress RDBMS to the ODBC adapter, from groveriffic (Fixes #251) 1352a8a3dc7119de2683ba491b095dee197f5dbc Jeremy Evans code@jeremyevans.net c30e8e40f520aabe1d03800ddcb25a63c717dec7 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/4a23245d3126e5830c8c1c1ecacc4150ad42d011 4a23245d3126e5830c8c1c1ecacc4150ad42d011

2008-11-20T13:33:39-08:00

Make :schema__table.* work correctly This shouldn't have been as difficult as it was, but the refactoring done was for the best: Move quote_schema_table and schema_and_table from Database to Dataset, putting proxy methods in Database. Make Database#default_schema a real attribute that can be used by any database (but should remain nil for most). Allow Database.new to take a :default_schema option, and document it and other options that can be used. b6e6d5a32e58306de765d7cd20b87ed22f15949d Jeremy Evans code@jeremyevans.net a0f0dec1b2ce7c4304f186d3a9d1796166480403 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/c30e8e40f520aabe1d03800ddcb25a63c717dec7 c30e8e40f520aabe1d03800ddcb25a63c717dec7

2008-11-19T12:08:50-08:00

Fix typo in mssql.rb 0e45d357e6150c44c848f04bba4caede6619e524 Jeremy Evans code@jeremyevans.net d407190e95e48f5de778d7b6e8ef99410b259796 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/a0f0dec1b2ce7c4304f186d3a9d1796166480403 a0f0dec1b2ce7c4304f186d3a9d1796166480403

2008-11-19T11:41:14-08:00

Refactor and modularize Dataset#sql_select, and refactor database adapters that override it This is a long overdue change to Sequel that makes select_sql more modular and makes database adapters to only override the parts they need to override instead of overriding the entire method (which requires a lot of code duplication). Unfortunately, I can't test the changes I made to most of the adapters, as I don't have access to the underlying databases. If you use one of the following adapters, please test this commit and make sure it works: * Informix * MSSQL * Oracle This also makes some changes to existing code. Attempting to do a SELECT DISTINCT ON will now raise an error with the MySQL or Oracle adapters, as they support DISTINCT but not DISTINCT ON. Previously, the MySQL adapter would raise a DatabaseError when you ran the query, and the Oracle adapter would silently change the DISTINCT ON to a plain DISTINCT, which potentially changes the intended meaning. The refactoring is done by splitting the public select_sql method into a bunch of private select_*_sql methods. The select_clause_order private method is the list of methods to call in order. So if it was [:columns, :from], it would call select_columns_sql and then select_from_sql to build the string. All of the private select_*_sql methods take 2 arguments, the current SQL string and the option hash to use. The SQL string passed should be modified in place. Database adapters have been changed to override just the select_*_sql methods they need, as well as select_clause_order if they need the clauses in a different order than the default. Another small change made is that the Dataset#column_list private method now treats a nil argument the same as an [] argument. This makes other internal code that uses the method nicer. c5c03db691b46779c5b59d323e9efec02d1efbb7 Jeremy Evans code@jeremyevans.net ace69a0cb4fa916adbf7f8a7400a4ce0d0329d1f Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/d407190e95e48f5de778d7b6e8ef99410b259796 d407190e95e48f5de778d7b6e8ef99410b259796

2008-11-17T07:56:31-08:00

Some small fixes for MySQL and for upcasing identifiers on JDBC This changes Dataset#upcase_identifiers? to lazily load the setting. Previously, it was handled in Database#initialize, but on JDBC (and other adapters that have subadapters), the method that provides the default hasn't been included in the class when Database#initialize tried to use it, so this would end up with identifiers being upcased when using MySQL, PostgreSQL, or SQLite on JDBC. This fixes Database#alter_table for MySQL, for the drop_index case, and fixes the MySQL schema parser to handle the fact that the table name provided to schema_parse_table is now a string instead of a symbol. b7be4792394d1cff83155bafc4373c4c1c8bb510 Jeremy Evans code@jeremyevans.net c3c2a4f9ff09f622dc10d66b6a9fe3f29c78a5bd Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/ace69a0cb4fa916adbf7f8a7400a4ce0d0329d1f ace69a0cb4fa916adbf7f8a7400a4ce0d0329d1f

2008-11-16T14:28:35-08:00

Set standard_conforming_strings = ON by default when using PostgreSQL, turn off with Sequel::Postgres.force_standard_strings = false PostgreSQL has two string modes, escaped (E'...') and unescaped ('...'). By default, you can use string escapes in an unescaped string, but that will change in a future version. It is recommended that you set standard_conforming_strings = ON when using PostgreSQL, though that will not be the default till a future version. Sequel expects the use of standard conforming strings, so it always uses unescaped strings. This brings up PostgreSQL warnings if the standard_conforming_strings setting was not set to ON in the PostgreSQL server configuration. With this commit, Sequel will changes the setting (since it can be specified per connection), unless you set Sequel::Postgres.force_standard_strings = false. The standard_conforming_strings is only available in PostgreSQL 8.2 and greater, but checking the server version at the point we want to change the setting would be quite complex considering all the underlying drivers that we support, so just send it unconditionally with a rescue so there shouldn't be an effect if the setting isn't available. For SQL:Blob values, use the extended string format when literalizing the value, since escape_bytea seems to require it. Without the extended string format, it appears to give the wrong value. a256f51cf976071ef6531925c57d371b951fb3fa Jeremy Evans code@jeremyevans.net b7e009273c3d7242f7ce5fd749121a25e72d216e Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/c3c2a4f9ff09f622dc10d66b6a9fe3f29c78a5bd c3c2a4f9ff09f622dc10d66b6a9fe3f29c78a5bd

2008-11-16T13:41:19-08:00

Fix Database#rename_table when using PostgreSQL (Fixes #248) 0f158d6f2f4b4a6e30b348e70c95e056998f2ada Jeremy Evans code@jeremyevans.net d6d45a37e4ae29a4d1fc87c3e6046c3ece1213d5 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/b7e009273c3d7242f7ce5fd749121a25e72d216e b7e009273c3d7242f7ce5fd749121a25e72d216e

2008-11-16T13:31:43-08:00

Whether to upcase or quote identifiers can now be set separately This changes Sequel by allowing the user to specify whether to upcase identifiers. Previously, upcasing was forced when quoting by default (but not when using MySQL, PostgreSQL, or SQLite), and not used when not quoting. This separates the quoting and upcasing functionality and allows the user to choose one or the other, or both, or even turn it on upcasing identifiers for database that didn't do so before. Backwards compatibility is mostly taken care of. The Sequel default is still to upcase, but not when using the MySQL, PostgreSQL, or SQLite adapters. If you use a custom adapter and do not want to upcase by default, add a private instance method to your database subclass named upcase_identifiers_default and have it return false. I also removed some useless RDoc for the Sequel.single_threaded method, which hasn't really been valid for a long time. 24a05dc1c9a4140fe7cd6e445083481f3d7dec74 Jeremy Evans code@jeremyevans.net