065b4b4c30b7ce6731fbf0f5197d435ca9d8c502 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/0a0567b8947d80a0a2c7d0dbd2a3089f1ffebfc2 0a0567b8947d80a0a2c7d0dbd2a3089f1ffebfc2

2009-11-10T07:14:59-08:00

Update CHANGELOG 9cf782ba09ad37a933b436357c92e2f4d209c547 Jeremy Evans code@jeremyevans.net 8411e15c1445a5f310bf9c887ba7cd7b3ef47600 Cyril Rohr cyril.rohr@gmail.com http://github.com/jeremyevans/sequel/commit/065b4b4c30b7ce6731fbf0f5197d435ca9d8c502 065b4b4c30b7ce6731fbf0f5197d435ca9d8c502

2009-11-10T03:03:33-08:00

fix for correctly reading options defined under the [client] tag in the mysql configuration file 5ffeac0e730ececc51f0b03ffbc2eb1c488aa6d3 Cyril Rohr cyril.rohr@gmail.com 2a5bc3eeceff421860367056674c86708587c0a8 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/8411e15c1445a5f310bf9c887ba7cd7b3ef47600 8411e15c1445a5f310bf9c887ba7cd7b3ef47600

2009-11-02T10:19:10-08:00

Bump version to 3.6.0 6a396c94422ff7baa962556ede5f24aed8d31a5b Jeremy Evans code@jeremyevans.net fec5c0ad569f092a1e88c079cdab882eba679c84 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/2a5bc3eeceff421860367056674c86708587c0a8 2a5bc3eeceff421860367056674c86708587c0a8

2009-10-29T12:20:15-07:00

Make the MSSQL shared adapter correctly parse the column schema information for tables in the non-default database schema 05ea19910bf2d04bf7d19f49b201229bfa15730a Jeremy Evans code@jeremyevans.net 9738b08e97d930a871f5c221039eb5ab12b01e0f Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/fec5c0ad569f092a1e88c079cdab882eba679c84 fec5c0ad569f092a1e88c079cdab882eba679c84

2009-10-29T09:23:13-07:00

Use save_changes instead of save when updating existing associated objects in the nested_attributes plugin This should be significantly faster for the case where you are displaying a complex form to the user, and they make no changes to the existing associated records when they submit it. This shouldn't have a negative effect on production code, unless save_changes doesn't work correctly for the associated objects. It may break test code that checks for specific SQL or columns in the update statement. 1e7f26152fdb21e4e820109942f176ce103cfc06 Jeremy Evans code@jeremyevans.net 6f5e48ba33e2a8b9adec2158c6eb51f4fb4ec03e Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/9738b08e97d930a871f5c221039eb5ab12b01e0f 9738b08e97d930a871f5c221039eb5ab12b01e0f

2009-10-29T09:20:14-07:00

Allow Model#save_changes to accept an option hash that is passed to save, so you can save changes without validating 7b36f4d27f7ad6caf24a94d1eea9ea83b85cc6fa Jeremy Evans code@jeremyevans.net 14e8fd245d965e325294aaf985f57ff1bd088b86 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/6f5e48ba33e2a8b9adec2158c6eb51f4fb4ec03e 6f5e48ba33e2a8b9adec2158c6eb51f4fb4ec03e

2009-10-28T16:40:49-07:00

Add sequel_validation_helpers_block plugin to plugins page bbd8d253a492f24f2b790a89a140b72398423442 Jeremy Evans code@jeremyevans.net b77fdab31d088d20d2885065915532013ff28ba6 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/14e8fd245d965e325294aaf985f57ff1bd088b86 14e8fd245d965e325294aaf985f57ff1bd088b86

2009-10-28T15:36:59-07:00

Make nested_attributes plugin add newly created objects to cached association array immediately The reasoning behind this is that if this isn't done, the current object has no way to access the nested attribute records until after the save. The general use case for nested_attributes is a web form that handles dependent records. Without any access to the nested records, it is very difficult to handle validation failures and display nice error messages to the user if dependent records are not valid. This approach adds the newly created records to the cached array, so if validation fails, you can just iterate over the cached array, and it will have both previously existing and new records in it. This change does not affect many_to_one associations, since they don't have a cached association array, and setting the object in the cached association would probably cause issues. This also doesn't affect updating existing records, since those are already in the array. a8a749b3bd34b204427909207a8a94f2e99e5de9 Jeremy Evans code@jeremyevans.net 28480f9d03773b6ee8f49c69753ee4584b53598b Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/b77fdab31d088d20d2885065915532013ff28ba6 b77fdab31d088d20d2885065915532013ff28ba6

2009-10-28T15:04:23-07:00

2009-10-28T14:24:31-07:00

Allow easier overriding of default options used in the validation_helpers plugin This breaks backwards compatibility if you were relying on the change made on October 20 to set the default validation error messages. This generalizes support for overriding any of the default options. As before, you can override it on a global level: Sequel::Plugins::ValidationHelpers::DEFAULT_OPTIONS[:format]. merge!(:message=>"incorrect format", :allow_missing=>true) You can also override it on a per class basis via: class Album < Sequel::Model plugin :validation_helpers DEFAULT_VALIDATION_OPTIONS = { :format=>{:message=>"incorrect format", :allow_missing=>true}} private def default_validation_helpers_options(type) super.merge(DEFAULT_VALIDATION_OPTIONS[type] || {}) end end This removes the MESSAGE_PROCS constant from the ValidationHelpers module, and removes the private instance method default_validation_error_message_proc. It changes the API for validation_error_message and adds the default_validation_helpers_options and validatable_attributes_for_type private instance methods. I chose not to change the validatable_attributes API, even though it could be simplified now, because while the method is private, I expect there may be consumers other than the default validations. a1fd1ad236ab53f00e0bee8e2dd98ae52bf43877 Jeremy Evans code@jeremyevans.net bab0b9bc30916c0e55dcdcdd8bfed09302721eed Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/28480f9d03773b6ee8f49c69753ee4584b53598b 28480f9d03773b6ee8f49c69753ee4584b53598b

2009-10-27T15:44:56-07:00

Make add_ association method not add the associated object to the cached array if it's already there This makes the most sense for one_to_many associations, since those cannot be associated more than once. For many_to_many associations, I think it is a better default, as it's a rare case that you want duplicate items in the association. If you do want duplicate items for a many_to_many association and you want it to work well with caching, please bring it up on the Sequel mailing list and we'll work it out. Note that this exact thing was done for reciprocal associations, so Sequel is more consistent with this change. 127b36ad50b508fd6c1b0589e4b648d511cbe9da Jeremy Evans code@jeremyevans.net d31e14b563c57375cddcfb82079eb6b34816b608 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/bab0b9bc30916c0e55dcdcdd8bfed09302721eed bab0b9bc30916c0e55dcdcdd8bfed09302721eed

2009-10-27T14:36:30-07:00

Fix typo in connection_pool.rb comment, thanks exploid 2ffcca7a17387cc7739ee294323f1a9395e46f30 Jeremy Evans code@jeremyevans.net bf838130dbd3994487a1f283c0af2097d26182fb Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/d31e14b563c57375cddcfb82079eb6b34816b608 d31e14b563c57375cddcfb82079eb6b34816b608

2009-10-26T21:00:41-07:00

Update CHANGELOG b4e13520251aabbe311f1ccec1923268d20f10fa Jeremy Evans code@jeremyevans.net 5c2fa386c325de5d91afb694ee91309369989067 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/bf838130dbd3994487a1f283c0af2097d26182fb bf838130dbd3994487a1f283c0af2097d26182fb

2009-10-26T21:00:02-07:00

Fix spec failure from previous commit 2f42d1be9fdf7103d3b0d8d3ade3d66c34296178 Jeremy Evans code@jeremyevans.net 2218e513418d65239fd82be334d6e59e5e6f3ce9 michael michael@thinknasium.org http://github.com/jeremyevans/sequel/commit/5c2fa386c325de5d91afb694ee91309369989067 5c2fa386c325de5d91afb694ee91309369989067

2009-10-26T20:56:50-07:00

2009-10-26T20:50:33-07:00

Add required argument dataset to sql_literal. Add alias sql_literal for to_s. fe443b5538f3be125a2865ed5bffe4b9c7d048c6 Jeremy Evans code@jeremyevans.net 5f7b80724ab46fc669655b899ef638017a8a584d Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/2218e513418d65239fd82be334d6e59e5e6f3ce9 2218e513418d65239fd82be334d6e59e5e6f3ce9

2009-10-26T08:05:30-07:00

Add spec for AssociationReflection#associated_object_keys f37fef004a186f8045cc47ec666416676961961d Jeremy Evans code@jeremyevans.net 94348f56262ef566e9b19686d92d2220eef82f55 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/5f7b80724ab46fc669655b899ef638017a8a584d 5f7b80724ab46fc669655b899ef638017a8a584d

2009-10-25T19:43:53-07:00

Add Model#modified! for explicitly marking an object as modified, so save_changes/update will run callbacks even if no columns have been modified This allows you to explicitly mark an existing record as modified without overriding modified?. Marking a column as modified makes save_changes (and therefore update) call save even if no columns have been modified. This is necessary if you have hooks that should be run regardless of whether the object's columns have been modified. See the included change to the nested_attributes plugin for an example use case. f1a0ce632dec8fb8d0fe8f68a4651a6df4abba4c Jeremy Evans code@jeremyevans.net 025e60d1f202c14323e9fd82e1f5db7018721f61 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/94348f56262ef566e9b19686d92d2220eef82f55 94348f56262ef566e9b19686d92d2220eef82f55

2009-10-25T19:25:46-07:00

Add support for a :fields option in the nested attributes plugin, and only allow updating of the fields specified I'm a big believer in using set_only for all mass assignment, specifying explicitly the fields allowed in that mass assignment call. This patch allows you to do that when using the nested_attributes, by specifying a :fields option which should be an array of symbols, which changes the internals to use set_only with the fields specified, instead of set. This fixes the spec for the previous commit, which only passed by accident. It also reorganizes some of the private nested_attributes methods. f7f813795ffac0ce5cffd149c8010ad198972e73 Jeremy Evans code@jeremyevans.net 64da28bd672814ce0a54ef6516be78430475347f Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/025e60d1f202c14323e9fd82e1f5db7018721f61 025e60d1f202c14323e9fd82e1f5db7018721f61

2009-10-25T14:39:48-07:00

Don't allow modifying keys related to the association when updating existing associated objects in the nested_attributes plugin This fixes a possible security issue in the nested attributes plugin, allowing you to modify an associated object's fields related to the association, which could allow you to disassociate it from the current record or associate it to a different record. This security issue is only likely to be present in one_to_many assocations, but it can happen for other associations if you use non default primary key fields in the association. Here's an example of code that exploits the vulnerability: Artist.one_to_many :albums Artist.plugin :nested_attributes Artist.nested_attributes :albums artist = Artist.create artist2 = Artist.create album = Album.create artist.albums_attributes = [{:id=>album.id, :artist_id=>artist2.id}] artist.save 89e843571d5bb45702351be6d2ee79aa1df14c7d Jeremy Evans code@jeremyevans.net 769faf8db170eb9f7eca612964594211a39aa042 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/64da28bd672814ce0a54ef6516be78430475347f 64da28bd672814ce0a54ef6516be78430475347f

2009-10-25T14:38:35-07:00

Add associated_object_keys method to AssociationReflection objects, specifying the key(s) in the associated model table related to the association 3dd18c80f77b9e23067bcbf772712e3c21a0df73 Jeremy Evans code@jeremyevans.net 0e20ae34e0b401f6db9308c48e5d746d859a6e9e 4dad8ecc2374727d6d2180ee5b13a347fb6506d8 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/769faf8db170eb9f7eca612964594211a39aa042 769faf8db170eb9f7eca612964594211a39aa042

2009-10-24T22:33:27-07:00

Merge commit 'michaeldiamond/master' Conflicts: lib/sequel/dataset/sql.rb abce8c05aeeb0411001d141c8a05a5c4b73b32fa Jeremy Evans code@jeremyevans.net e0f8e947f07652f499f21106402362d5c993ae39 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/0e20ae34e0b401f6db9308c48e5d746d859a6e9e 0e20ae34e0b401f6db9308c48e5d746d859a6e9e

2009-10-23T22:49:08-07:00

Fix marshalling of model objects so that they load correctly, but you need to call marshallable! first The previous fix of not raising an error when marshalling the model instance's dataset didn't work as it broke loading. Instead of writing custom _dump and _load methods, add a marshallable! instance method that just sets the model instance's dataset to nil. Leave the changes to Model::Errors, since they aren't a bad way to handle things. Make the specs test loading the marshalled data, so we can make sure things work. 72ca553e6143c01d68440c8f06e005f3f8d664e2 Jeremy Evans code@jeremyevans.net 974f9d9c03de2d8a67b631dfef59a41ab2c2077f Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/e0f8e947f07652f499f21106402362d5c993ae39 e0f8e947f07652f499f21106402362d5c993ae39

2009-10-23T22:29:28-07:00

Remove misleading comment from Model#update ed27e6af6e946da961b36b163a8f8bb759e51b28 Jeremy Evans code@jeremyevans.net 6026af77fc65c58bc05ce63c9bae40566f92e480 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/974f9d9c03de2d8a67b631dfef59a41ab2c2077f 974f9d9c03de2d8a67b631dfef59a41ab2c2077f

2009-10-23T22:15:16-07:00

Minor caching spec fixes and update CHANGELOG 27d2a8c1c854def799c06f2f9ae6fb28ea26c0fb Jeremy Evans code@jeremyevans.net a186018bfc4968a64dc514c836050eb0a6b30b9e 666c20d6d59532f9c00a30090125ad78fc10b56a Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/6026af77fc65c58bc05ce63c9bae40566f92e480 6026af77fc65c58bc05ce63c9bae40566f92e480

2009-10-23T22:05:43-07:00

Merge commit 'eppo/master' c157e2b129e8d850b8fe1717589a45c238f8e2ee Jeremy Evans code@jeremyevans.net a61093a96e39435838b76320e599ac4734057bef Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/a186018bfc4968a64dc514c836050eb0a6b30b9e a186018bfc4968a64dc514c836050eb0a6b30b9e

2009-10-23T22:02:30-07:00

Add more documentation to hook_class_methods plugin dc2d98b0f6abef9631f8504ea2f1f1b31ed83a45 Jeremy Evans code@jeremyevans.net 4eed5d245d56090aa54743bb060f05af420881d4 230b120f18834220a9ac7c71b1836300731e3253 Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/a61093a96e39435838b76320e599ac4734057bef a61093a96e39435838b76320e599ac4734057bef

2009-10-23T21:59:47-07:00

Merge commit 'eydaimon/master' 7e597b13524654ff06cbcf4c64829a1c263e3681 Jeremy Evans code@jeremyevans.net 48cc4303a14862cb9a8690e98e38f7fd9d64cc6a Jeremy Evans code@jeremyevans.net http://github.com/jeremyevans/sequel/commit/4eed5d245d56090aa54743bb060f05af420881d4 4eed5d245d56090aa54743bb060f05af420881d4

2009-10-23T14:09:26-07:00

Don't modify array with a string and placeholders passed to Dataset#filter or related methods Thanks to sferik for pointing this out. Previously: options = ["name like ?", "%dog%"] Player.where(options) options # => ["%dog%"] 8f73c653bfddf76ff35aa069eea21949dd506ec9 Jeremy Evans code@jeremyevans.net b99a1fa283fb75c66815cda61ac20b79508029ec EppO f.monbillard@gmail.com http://github.com/jeremyevans/sequel/commit/666c20d6d59532f9c00a30090125ad78fc10b56a 666c20d6d59532f9c00a30090125ad78fc10b56a

2009-10-23T03:21:59-07:00

fixed spec for caching plugin (memcached support) all tests pass 42c12ea84904ecc8c4c2b5f62c7b95d36cc06cb6 EppO f.monbillard@gmail.com 19b34e157449a03cf4c60e7ee22dec8637fbe1e3 michael michael@thinknasium.org http://github.com/jeremyevans/sequel/commit/4dad8ecc2374727d6d2180ee5b13a347fb6506d8 4dad8ecc2374727d6d2180ee5b13a347fb6506d8

2009-10-23T01:05:48-07:00

add new dataset files to require 688f5bc76191ff656808def4fb60c4d3a88f4b6c keenanm michael@thinknasium.org 2a2aa5468886fc78c5428bae73f5ddf96cd61033 michael michael@thinknasium.org http://github.com/jeremyevans/sequel/commit/19b34e157449a03cf4c60e7ee22dec8637fbe1e3 19b34e157449a03cf4c60e7ee22dec8637fbe1e3

2009-10-23T01:01:09-07:00

2009-10-23T00:56:44-07:00

moved dataset query manipulations into dataset/query.rb 0c6ff2c4906777f827906b5cbef7bdd2612c72f5 keenanm michael@thinknasium.org