@@ -3,7 +3,7 @@ jQuery.expr = Sizzle.selectors; jQuery.expr[":"] = jQuery.expr.filters; Sizzle.selectors.filters.hidden = function(elem){ - return elem.offsetWidth === 0 || elem.offsetHeight === 0; + return elem.offsetWidth === 0 && elem.offsetHeight === 0; }; Sizzle.selectors.filters.visible = function(elem){ libs/jquery.js @@ -311,7 +311,7 @@ test("attributes", function() { }); test("pseudo (:) selectors", function() { - expect(70); + expect(78); t( "First Child", "p:first-child", ["firstp","sndp"] ); t( "Last Child", "p:last-child", ["sap"] ); t( "Only Child", "a:only-child", ["simon1","anchor1","yahoo","anchor2","liveLink1","liveLink2"] ); @@ -362,6 +362,22 @@ test("pseudo (:) selectors", function() { t( "Is Hidden", "#form input:hidden", ["text1","text2","radio1","radio2","check1","check2","hidden1","hidden2","name","search"] ); t( "Is Hidden", "#main:hidden", ["main"] ); t( "Is Hidden", "#dl:hidden", ["dl"] ); + + var $div = jQuery('#nothiddendivchild'); + $div.css({ fontSize: 0, lineHeight: 0 });// IE also needs to set font-size and line-height to 0 + $div.width(0).height(0); + t( "Is Hidden", '#nothiddendivchild:hidden', ['nothiddendivchild'] ); + t( "Is Not Hidden", '#nothiddendivchild:visible', [] ); + $div.width(1).height(0); + t( "Is Visible", '#nothiddendivchild:visible', ['nothiddendivchild'] ); + t( "Is Not Visible", '#nothiddendivchild:hidden', [] ); + $div.width(0).height(1); + t( "Is Visible", '#nothiddendivchild:visible', ['nothiddendivchild'] ); + t( "Is Not Visible", '#nothiddendivchild:hidden', [] ); + $div.width(1).height(1); + t( "Is Visible", '#nothiddendivchild:visible', ['nothiddendivchild'] ); + t( "Is Not Visible", '#nothiddendivchild:hidden', [] ); + $div.width('').height('').css({ fontSize: '', lineHeight: '' }); t( "Check position filtering", "div#nothiddendiv:eq(0)", ["nothiddendiv"] ); t( "Check position filtering", "div#nothiddendiv:last", ["nothiddendiv"] ); test/unit/selector.js e6a41b833bcfe295532a204fb4d1b1bb61b947d1 brandonaaron brandon.aaron@gmail.com http://github.com/jeresig/sizzle/commit/8c0db4f6b4b484979e4df2529faef7852866586a 8c0db4f6b4b484979e4df2529faef7852866586a 2009-05-03T17:30:05-07:00 2009-05-03T17:30:05-07:00 fix :hidden selector in jQuery 094bc771bb929b9ada652dc915cde7fd22e3134d brandonaaron brandon.aaron@gmail.com