Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoph needs unittests #29

Closed
jeroenrnl opened this issue Jul 16, 2012 · 1 comment
Closed

Zoph needs unittests #29

jeroenrnl opened this issue Jul 16, 2012 · 1 comment
Assignees
Milestone

Comments

@jeroenrnl
Copy link
Owner

Currently, Zoph cannot be automatically tested, making changes riskfull and bugprone.

@ghost ghost assigned jeroenrnl Jul 16, 2012
jeroenrnl added a commit that referenced this issue Sep 10, 2012
The UnitTests directory contains a set of tests that can be
used with phpunit. At this moment there is around 10% code
coverage.
Testdata can be generated with the scripts in createTestData

issue #29
jeroenrnl added a commit that referenced this issue Jan 19, 2013
Mainly the changes made for webconfig (#28)

#29
jeroenrnl added a commit that referenced this issue Dec 26, 2014
Also made some changes in the album class itself because the unittests
revealed some previously unknown issues.

Issue #29
jeroenrnl added a commit that referenced this issue Feb 8, 2015
jeroenrnl added a commit that referenced this issue Jul 13, 2015
jeroenrnl added a commit that referenced this issue Jul 17, 2015
Added unittests for conf class and did some cleanup so var names follow
naming convention.

Issue #29
jeroenrnl added a commit that referenced this issue Sep 3, 2015
- Added a test for the zophTable::getRecords() function.
- Added tests that call the password() function
- Merged zophTable::getAutoCoverOrder() and
zophTable::getAutoCoverOrderNew() into zophTable::getAutoCoverOrder()
- Whitespace cleanup
- Removed unused functionality from zophTable::getRecordsFromQuery()
- Changed self:: into static:: in zophTable class

Issue #29
jeroenrnl added a commit that referenced this issue Sep 3, 2015
jeroenrnl added a commit that referenced this issue Sep 3, 2015
jeroenrnl added a commit that referenced this issue Sep 23, 2015
Also simplified zophCode class, removing some unused features
Issue #29
jeroenrnl added a commit that referenced this issue Oct 4, 2015
jeroenrnl added a commit that referenced this issue Oct 11, 2015
jeroenrnl added a commit that referenced this issue Oct 11, 2015
This really is the core of Zoph, but was hardly covered by UnitTests,
until now, this change brings it to 98.5% covered with UnitTests!

Issue #29
@jeroenrnl
Copy link
Owner Author

Closing this one as it is now mostly 'normal' operation to add unittests to Zoph. Even though code coverage is not where I want it, I think keeping a bug open for it is not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant