@@ -118,8 +118,7 @@ describe "String#to_i" do "777".to_i(obj).should == 0777 end - ironruby_bug("21158: Number parser not resiliant for where the negative sign appears") do - it "requires that the sign if any appears before the base specifier" do + it "requires that the sign if any appears before the base specifier" do "0b-1".to_i( 2).should == 0 "0d-1".to_i(10).should == 0 "0o-1".to_i( 8).should == 0 @@ -129,7 +128,6 @@ describe "String#to_i" do "0o-1".to_i(8).should == 0 "0d-1".to_i(10).should == 0 "0x-1".to_i(16).should == 0 - end end it "raises an ArgumentError for illegal bases (1, < 0 or > 36)" do 1.8/core/string/to_i_spec.rb @@ -7,25 +7,23 @@ describe "Thread#inspect" do t.value.should include('run') end - ironruby_bug("bug 21157: Match MRI sleep / wakeup / run semantics in IronRuby") do - it "describes a sleeping thread" do - c = Channel.new - t = Thread.new do - sleep - c << Thread.current.inspect - sleep - end - - Thread.pass until t.status == 'sleep' - t.inspect.should include('sleep') - t.run - c.receive.should include('run') - Thread.pass until t.status == 'sleep' - t.inspect.should include('sleep') - t.run - t.join - t.inspect.should include('dead') + it "describes a sleeping thread" do + c = Channel.new + t = Thread.new do + sleep + c << Thread.current.inspect + sleep end + + Thread.pass until t.status == 'sleep' + t.inspect.should include('sleep') + t.run + c.receive.should include('run') + Thread.pass until t.status == 'sleep' + t.inspect.should include('sleep') + t.run + t.join + t.inspect.should include('dead') end compliant_on(:ruby) do 1.8/core/thread/inspect_spec.rb @@ -35,10 +35,8 @@ describe "Thread#join" do t.join.should == t end - ironruby_bug("21171: Marshal exceptions thrown within thread blocks properly to calling thread") do - it "raises any exceptions encountered in the thread body" do - t = Thread.new { raise NotImplementedError.new("test exception") } - lambda { t.join }.should raise_error(NotImplementedError) - end + it "raises any exceptions encountered in the thread body" do + t = Thread.new { raise NotImplementedError.new("test exception") } + lambda { t.join }.should raise_error(NotImplementedError) end end 1.8/core/thread/join_spec.rb @@ -2,11 +2,9 @@ require File.dirname(__FILE__) + '/../../spec_helper' require File.dirname(__FILE__) + '/fixtures/classes' describe "Thread.main" do - ironruby_bug("21171: Marshal exceptions thrown within thread blocks properly to calling thread") do - it "returns the main thread" do - Thread.new { @main = Thread.main ; @current = Thread.current}.join - @main.should_not == @current - @main.should == Thread.current - end + it "returns the main thread" do + Thread.new { @main = Thread.main ; @current = Thread.current}.join + @main.should_not == @current + @main.should == Thread.current end end 1.8/core/thread/main_spec.rb @@ -7,13 +7,11 @@ shared :thread_exit do |cmd| # sent #join from outside the thread. The 100.times provides a certain # probability that the deadlock will occur. It was sufficient to reliably # reproduce the deadlock in JRuby. - ironruby_bug("bug 21157: Match MRI sleep / wakeup / run semantics in IronRuby") do - it "does not deadlock when called from within the thread while being joined from without" do - 100.times do - t = Thread.new { Thread.stop; Thread.current.send(cmd) } - Thread.pass until t.status == "sleep" - t.wakeup; t.join - end + it "does not deadlock when called from within the thread while being joined from without" do + 100.times do + t = Thread.new { Thread.stop; Thread.current.send(cmd) } + Thread.pass until t.status == "sleep" + t.wakeup; t.join end end end 1.8/core/thread/shared/exit.rb @@ -8,11 +8,9 @@ describe "Thread#status" do t.status.should == false end - ironruby_bug("21171: Marshal exceptions thrown within thread blocks properly to calling thread") do - it "returns nil if thread terminates with exception" do - t = Thread.new { raise "test exception" } - lambda { t.join }.should raise_error(StandardError) - t.status.should == nil - end + it "returns nil if thread terminates with exception" do + t = Thread.new { raise "test exception" } + lambda { t.join }.should raise_error(StandardError) + t.status.should == nil end end 1.8/core/thread/status_spec.rb @@ -20,14 +20,12 @@ describe "Thread.stop" do end describe "Thread#stop?" do - ironruby_bug("bug 21157: Match MRI sleep / wakeup / run semantics in IronRuby") do - it "reports if a thread has stopped due to sleeping" do - t = Thread.new { Thread.stop } - Thread.pass until t.status == 'sleep' - t.stop?.should == true - t.run - t.join - t.stop?.should == true - end + it "reports if a thread has stopped due to sleeping" do + t = Thread.new { Thread.stop } + Thread.pass until t.status == 'sleep' + t.stop?.should == true + t.run + t.join + t.stop?.should == true end end 1.8/core/thread/stop_spec.rb ff7d7d15bbe671252f9829f3b1d1e13ce7f98970 Jim Deville jdeville@microsoft.com http://github.com/jflam/rubyspec/commit/1e57876b542ff19f265795f5bc69dbf41372ac33 1e57876b542ff19f265795f5bc69dbf41372ac33 2008-07-12T00:42:50-07:00 2008-07-12T00:42:50-07:00 removing ironruby_bug guard due to conversation with #rubyspec about implementation bugs f30119cbd11eea70adb692c4f2d3979cf00f81ef Jim Deville jdeville@microsoft.com