@@ -86,19 +86,6 @@ Now that you've got some versions, it would be nice to use ActiveRecord associat Don't forget the class name, or you'll get a warning - -== Method Missing - -If you call a method on a version and it's undefined, it'll be sent to the parent. For example, pages could have a creator attribute that doesn't change and is therefore unversioned. You don't need to define a creator method in the version_fu block. - - class Page < ActiveRecord::Base - version_fu - belongs_to :creator - end - -Calling Pages.first.versions.latest.creator will be the same as calling Pages.first.creator. - - == When to Version By default a new version will be saved whenever a versioned column is changed. However, you can control this at a more fine grained level. Just override the create_new_version? method. For example, let's say you only want to save a new version if both the page title and body changed. Taking advantage of the dirty attribute methods, you could do something like this: README.rdoc @@ -51,11 +51,6 @@ module VersionFu def next self.class.after(self) end - - # Pass any unknown methods to the parent object - def method_missing(method, *args) - eval(original_class.to_s.demodulize.underscore).__send__ method, *args - end end # Housekeeping on versioned class lib/version_fu.rb @@ -137,22 +137,4 @@ class VersionFuTest < Test::Unit::TestCase def test_should_take_a_block_containing_ar_extention assert_equal authors(:larry), page_versions(:welcome_1).author end - - ############################################################################# - # M E T H O D M I S S I N G # - ############################################################################# - def test_should_send_missing_associations_to_parent_object - assert_equal authors(:larry), page_versions(:welcome_1).creator - end - - def test_should_send_regular_missing_methods_to_parent_object - assert_equal "Hello World 1", author_versions(:sara_1).hello_world - assert_equal "Hello World 2", author_versions(:sara_1).hello_world(2) # Test passing params - end - - def test_should_eval_missing_methods_from_parent_in_versioned_class_binding - # TODO Should probably be "Sara Maiden" - assert_equal "Sara Smiles", author_versions(:sara_1).name - end - end \ No newline at end of file test/version_fu_test.rb 7cf1cab81f638988d2f7e33df91d6857dfabdff0 Jordan McKible jordan@mckible.com http://github.com/jmckible/version_fu/commit/a380b4c0edd7d494e5b0ec19ac508e960d35fca3 a380b4c0edd7d494e5b0ec19ac508e960d35fca3 2008-07-08T13:56:06-07:00 2008-07-08T13:56:06-07:00 Remove method_missing functionality. a131c73da4fce154d8903c480e4c3879d80d92e5 Jordan McKible jordan@mckible.com