Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformatted Changes file as per CPAN::Changes::Spec #70

Merged
merged 1 commit into from Aug 28, 2013

Conversation

neilb
Copy link
Contributor

@neilb neilb commented Aug 28, 2013

Hi John,

I've reformatted your Changes file according to the spec in CPAN::Changes::Spec. This just needed a change in the way dates are formatted.

Following this format means that various tools can more easily process your distribution automatically.

You can find out more about this at Brian Cassidy's CPAN::Changes Kwalitee Service, which is where I saw your module listed :-)

Cheers,
Neil

jmcnamara added a commit that referenced this pull request Aug 28, 2013
Reformatted Changes file as per CPAN::Changes::Spec
@jmcnamara jmcnamara merged commit 4eb6fa4 into jmcnamara:master Aug 28, 2013
@jmcnamara
Copy link
Owner

Cool, thanks for that.

John

@jmcnamara
Copy link
Owner

I should have looked at this more closely. I presume that CPAN::Changes::Spec doesn't require the date in YYYY-DD-MM format and this is an error, right?:

diff --git a/Changes b/Changes
index f8dc524..3791553 100644
--- a/Changes
+++ b/Changes
@@ -4,13 +4,13 @@ Revision history for Perl module Excel::Writer::XLSX.
      - Removed/deprecated feature.
      ! Bug fix.

-0.72 Aug 28 2013
+0.72 2013-28-08

    ! Fix for charts and images that cross rows and columns that are
      hidden or formatted but which don’t have size changes.

@neilb
Copy link
Contributor Author

neilb commented Nov 8, 2013

Bugger, sorry about that. My script obviously made a bad call. I'll let you know when I've fixed it.

@jmcnamara
Copy link
Owner

Not to worry. I've already fixed it locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants