@@ -4,6 +4,8 @@ == rufus-verbs - 0.9 released 2008/04/xx +- bug #19408 : fopen now returns a instance that has a read() method. + problem pointed at by Scott Sproule. - bug #19234 : cookie path checking broken - Fixed. - todo #19202 : EndPoint.cookies now readable - bug #19201 : :params not respected when specified in request CHANGELOG.txt @@ -3,5 +3,6 @@ == Feedback +Scott Sproule : fopen() result didn't have a read() method Maik Schmidt : missing 'rufus-lru' CREDITS.txt @@ -163,6 +163,8 @@ The Rufus::Verbs module provides as well a <tt>fopen</tt> method, which mostly f But it follows redirections (has all the rufus-verbs features). It's provided for when targets are local files or URIs. +This fopen() method makes sure to return an object that has a read() method (like a File instance has). + The tests may provide good intel as on 'rufus-verbs' usage as well : http://rufus.rubyforge.org/svn/trunk/verbs/test/ README.txt @@ -113,9 +113,15 @@ module Rufus::Verbs if block block.call r return - else - return r end + + class << r + def read + self.body + end + end unless r.respond_to?(:read) + + return r end raise "can't handle scheme '#{u.scheme}' for #{u.to_s}" lib/rufus/verbs.rb @@ -50,4 +50,11 @@ class UriTest < Test::Unit::TestCase assert_equal "{}", res.body.strip end end + + def test_1 + + assert_kind_of String, fopen("CHANGELOG.txt").read + assert_kind_of String, fopen("file:CHANGELOG.txt").read + assert_kind_of String, fopen("http://localhost:7777/items").read + end end test/fopen_test.rb b74b5651fd839631e670f68a9c98cfb3a1a45b6a John Mettraux jmettraux@gmail.com http://github.com/jmettraux/rufus-verbs/commit/1607d9e0a07a9948131aaf00268ffce71acae4c3 1607d9e0a07a9948131aaf00268ffce71acae4c3 2008-04-09T17:26:45-07:00 2008-04-09T17:26:45-07:00 making sure that the return of fopen() has a read() method (like a File instance would) a31dfa46974d5351e0c15b2ba45232b06be0e344 John Mettraux jmettraux@gmail.com